.gitignore

@@ -73,7 +73,6 @@ eslint-report.html
 /.gitlab_workhorse_secret
 /.gitlab_pages_secret
 /.gitlab_kas_secret
-/.gitlab_suggested_reviewers_secret
 /webpack-report/
 /crystalball/
 /test_results/

.gitlab-ci.yml

@@ -25,6 +25,7 @@ default:
   timeout: 90m
 
 workflow:
+  name: '$PIPELINE_NAME'
   rules:
     # If `$FORCE_GITLAB_CI` is set, create a pipeline.
     - if: '$FORCE_GITLAB_CI'
@@ -39,18 +40,23 @@ workflow:
     - if: '($CI_MERGE_REQUEST_EVENT_TYPE == "merged_result" || $CI_MERGE_REQUEST_EVENT_TYPE == "merge_train") && $CI_MERGE_REQUEST_LABELS =~ /pipeline:run-in-ruby3/'
       variables:
         RUBY_VERSION: "3.0"
+        PIPELINE_NAME: 'Ruby 3 $CI_MERGE_REQUEST_EVENT_TYPE MR pipeline'
     # For merge requests running exclusively in Ruby 3.0
     - if: '$CI_MERGE_REQUEST_LABELS =~ /pipeline:run-in-ruby3/'
       variables:
         RUBY_VERSION: "3.0"
+        PIPELINE_NAME: 'Ruby 3 $CI_MERGE_REQUEST_EVENT_TYPE MR pipeline'
     # For (detached) merge request pipelines.
     - if: '$CI_MERGE_REQUEST_IID'
+      variables:
+        PIPELINE_NAME: '$CI_MERGE_REQUEST_EVENT_TYPE MR pipeline'
     # For the scheduled pipelines, we set specific variables.
     - if: '$CI_COMMIT_BRANCH == $CI_DEFAULT_BRANCH && $CI_PIPELINE_SOURCE == "schedule"'
       variables:
         CRYSTALBALL: "true"
         CREATE_INCIDENT_FOR_PIPELINE_FAILURE: "true"
         NOTIFY_PIPELINE_FAILURE_CHANNEL: "master-broken"
+        PIPELINE_NAME: 'Scheduled $CI_COMMIT_BRANCH pipeline'
     # Run pipelines for ruby3 branch
     - if: '$CI_COMMIT_BRANCH == "ruby3" && $CI_PIPELINE_SOURCE == "schedule"'
       variables:
@@ -58,6 +64,7 @@ workflow:
         NOTIFY_PIPELINE_FAILURE_CHANNEL: "f_ruby3"
         OMNIBUS_GITLAB_RUBY3_BUILD: "true"
         OMNIBUS_GITLAB_CACHE_EDITION: "GITLAB_RUBY3"
+        PIPELINE_NAME: 'Scheduled ruby 3 pipeline'
     # This work around https://gitlab.com/gitlab-org/gitlab/-/issues/332411 whichs prevents usage of dependency proxy
     # when pipeline is triggered by a project access token.
     - if: '$CI_COMMIT_BRANCH == $CI_DEFAULT_BRANCH && $GITLAB_USER_LOGIN =~ /project_\d+_bot\d*/'

.gitlab/ci/rails/shared.gitlab-ci.yml

@@ -54,10 +54,14 @@ include:
     RECORD_DEPRECATIONS: "true"
     GEO_SECONDARY_PROXY: 0
     RSPEC_TESTS_FILTER_FILE: "${RSPEC_MATCHING_TESTS_PATH}"
+    SUCCESSFULLY_RETRIED_TEST_EXIT_CODE: 137
   needs: ["setup-test-env", "retrieve-tests-metadata", "compile-test-assets", "detect-tests"]
   script:
     - !reference [.base-script, script]
     - rspec_paralellized_job "--tag ~quarantine --tag ~level:migration"
+  allow_failure:
+    # the exit code listed here must match the one defined for the variable SUCCESSFULLY_RETRIED_TEST_EXIT_CODE
+    exit_codes: 137
 
 .base-artifacts:
   artifacts:

.gitlab/ci/review.gitlab-ci.yml

@@ -7,20 +7,13 @@ review-cleanup:
   environment:
     name: review/regular-cleanup
     action: access
-  variables:
-    KUBE_NAMESPACE: "review-apps" # gcp_cleanup.sh requires passing KUBE_NAMESPACE variable
   before_script:
     - source scripts/utils.sh
-    - source scripts/review_apps/gcp_cleanup.sh
     - !reference [".use-kube-context", before_script]
     - install_gitlab_gem
-    - setup_gcp_dependencies
+    - setup_gcloud
   script:
-    - exit_code_cmd_1=0;
-    - exit_code_cmd_2=0;
-    - scripts/review_apps/automated_cleanup.rb || exit_code_cmd_1=$?
-    - gcp_cleanup || exit_code_cmd_2=$?
-    - if [ $exit_code_cmd_1 -ne 0 ] || [ $exit_code_cmd_2 -ne 0 ]; then (scripts/slack review-apps-monitoring "☠️ \`${CI_JOB_NAME}\` failed! ☠️ See ${CI_JOB_URL} - <https://gitlab.com/gitlab-org/quality/engineering-productivity/team/-/blob/main/runbooks/review-apps.md#review-cleanup-job-failed|📗 RUNBOOK 📕>" warning "GitLab Bot" && exit 1); fi;
+    - scripts/review_apps/automated_cleanup.rb || (scripts/slack review-apps-monitoring "☠️ \`${CI_JOB_NAME}\` failed! ☠️ See ${CI_JOB_URL} - <https://gitlab.com/gitlab-org/quality/engineering-productivity/team/-/blob/main/runbooks/review-apps.md#review-cleanup-job-failed|📗 RUNBOOK 📕>" warning "GitLab Bot" && exit 1);
 
 .base-review-checks:
   extends:
@@ -28,8 +21,8 @@ review-cleanup:
   image: ${REVIEW_APPS_IMAGE}
   stage: prepare
   before_script:
-    - source scripts/review_apps/gcp_cleanup.sh
-    - setup_gcp_dependencies
+    - source scripts/utils.sh
+    - setup_gcloud
     - !reference [".use-kube-context", before_script]
 
 review-k8s-resources-count-checks:

.gitlab/ci/rules.gitlab-ci.yml

@@ -38,11 +38,16 @@
 # Once https://gitlab.com/gitlab-org/gitlab/-/issues/373904 is implemented, we should be able to change this back to
 # if: '$CI_MERGE_REQUEST_IID && $CI_MERGE_REQUEST_APPROVALS_COUNT > 0'
 # or any similar condition to check that the MR has *any* approval (not just required approval).
+#
+# Temprorarily adding || $CI_MERGE_REQUEST_LABELS =~ /pipeline:run-full-rspec/ for backward compatibility,
+# remove once https://gitlab.com/gitlab-org/quality/quality-engineering/team-tasks/-/issues/1557 is fully rolled out
 .if-merge-request-approved: &if-merge-request-approved
-  if: '$CI_MERGE_REQUEST_IID && $CI_MERGE_REQUEST_LABELS =~ /pipeline:run-full-rspec/'
+  if: '$CI_MERGE_REQUEST_IID && $CI_MERGE_REQUEST_LABELS =~ /pipeline:mr-approved/ || $CI_MERGE_REQUEST_LABELS =~ /pipeline:run-full-rspec/'
 
+# Temprorarily adding && $CI_MERGE_REQUEST_LABELS !~ /pipeline:run-full-rspec/ for backward compatibility,
+# remove once https://gitlab.com/gitlab-org/quality/quality-engineering/team-tasks/-/issues/1557 is fully rolled out
 .if-merge-request-not-approved: &if-merge-request-not-approved
-  if: '$CI_MERGE_REQUEST_IID && $CI_MERGE_REQUEST_LABELS !~ /pipeline:run-full-rspec/'
+  if: '$CI_MERGE_REQUEST_IID && $CI_MERGE_REQUEST_LABELS !~ /pipeline:mr-approved/ && $CI_MERGE_REQUEST_LABELS !~ /pipeline:run-full-rspec/'
 
 .if-automated-merge-request: &if-automated-merge-request
   if: '$CI_MERGE_REQUEST_SOURCE_BRANCH_NAME == "release-tools/update-gitaly" || $CI_MERGE_REQUEST_TARGET_BRANCH_NAME =~ /stable-ee$/'

.gitlab/issue_templates/Feature Flag Roll Out.md

@@ -66,9 +66,12 @@ _Consider adding links to check for Sentry errors, Production logs for 5xx, 302s
 
 ## Rollout Steps
 
+Note: Please make sure to run the chatops commands in the slack channel that gets impacted by the command. 
+
 ### Rollout on non-production environments
 
-- Ensure that the feature MRs have been deployed to non-production environments.
+- [ ] Verify the MR with the feature flag is merged to master.
+- Verify that the feature MRs have been deployed to non-production environments with:
     - [ ] `/chatops run auto_deploy status <merge-commit-of-your-feature>`
 - [ ] Enable the feature globally on non-production environments.
     - [ ] `/chatops run feature set <feature-flag-name> true --dev --staging --staging-ref`
@@ -79,13 +82,16 @@ _Consider adding links to check for Sentry errors, Production logs for 5xx, 302s
 
 ### Specific rollout on production
 
+For visibility, all `/chatops` commands that target production should be executed in the `#production` slack channel and cross-posted (with the command results) to the responsible team's slack channel (`#g_TEAM_NAME`).
+
 - Ensure that the feature MRs have been deployed to both production and canary.
     - [ ] `/chatops run auto_deploy status <merge-commit-of-your-feature>`
-- If you're using [project-actor](https://docs.gitlab.com/ee/development/feature_flags/#feature-actors), you must enable the feature on these entries:
+- Depending on the [type of actor](https://docs.gitlab.com/ee/development/feature_flags/#feature-actors) you are using, pick one of these options:
+  - If you're using **project-actor**, you must enable the feature on these entries:
     - [ ] `/chatops run feature set --project=gitlab-org/gitlab,gitlab-org/gitlab-foss,gitlab-com/www-gitlab-com <feature-flag-name> true`
-- If you're using [group-actor](https://docs.gitlab.com/ee/development/feature_flags/#feature-actors), you must enable the feature on these entries:
+  - If you're using **group-actor**, you must enable the feature on these entries:
     - [ ] `/chatops run feature set --group=gitlab-org,gitlab-com <feature-flag-name> true`
-- If you're using [user-actor](https://docs.gitlab.com/ee/development/feature_flags/#feature-actors), you must enable the feature on these entries:
+  - If you're using **user-actor**, you must enable the feature on these entries:
     - [ ] `/chatops run feature set --user=<your-username> <feature-flag-name> true`
 - [ ] Verify that the feature works on the specific entries. Posting the QA result in this issue is preferable.
 
@@ -124,7 +130,7 @@ To do so, follow these steps:
 
 - [ ] Create a merge request with the following changes. Ask for review and merge it.
     - [ ] Set the `default_enabled` attribute in [the feature flag definition](https://docs.gitlab.com/ee/development/feature_flags/#feature-flag-definition-and-validation) to `true`.
-    - [ ] Create [a changelog entry](https://docs.gitlab.com/ee/development/feature_flags/#changelog).
+    - [ ] Review [what warrants a changelog entry](https://docs.gitlab.com/ee/development/changelog.html#what-warrants-a-changelog-entry) and decide if [a changelog entry](https://docs.gitlab.com/ee/development/feature_flags/#changelog) is needed.
 - [ ] Ensure that the default-enabling MR has been included in the release package.
       If the merge request was deployed before [the monthly release was tagged](https://about.gitlab.com/handbook/engineering/releases/#self-managed-releases-1),
       the feature can be officially announced in a release blog post.
@@ -165,7 +171,7 @@ You can either [create a follow-up issue for Feature Flag Cleanup](https://gitla
       the feature can be officially announced in a release blog post.
     - [ ] `/chatops run release check <merge-request-url> <milestone>`
 - [ ] Close [the feature issue][main-issue] to indicate the feature will be released in the current milestone.
-- [ ] If not already done, clean up the feature flag from all environments by running these chatops command in `#production` channel:
+- [ ] Clean up the feature flag from all environments by running these chatops command in `#production` channel:
     - [ ] `/chatops run feature delete <feature-flag-name> --dev --staging --staging-ref --production`
 - [ ] Close this rollout issue.
 

.gitlab/issue_templates/Navigation - Left Sidebar Proposals.md → .gitlab/issue_templates/Navigation Proposals.md

@@ -6,8 +6,9 @@
 
 ### Checklist
 
-- [ ] If your proposal includes changes to the menu items within the left sidebar, engage the [Foundations Product Manager](https://about.gitlab.com/handbook/product/categories/#foundations-group) for approval. The Foundations DRI will work with UX partners in product design, research, and technical writing, as applicable.
+- [ ] Add relevant information to the issue description detailing your proposal, including usage and business drivers.
 - [ ] Follow the [product development workflow](https://about.gitlab.com/handbook/product-development-flow/#validation-phase-2-problem-validation) validation process to ensure you are solving a well understood problem and that the proposed change is understandable and non-disruptive to users. Navigation-specific research is strongly encouraged.
+- [ ] Engage the [Foundations Product Manager](https://about.gitlab.com/handbook/product/categories/#foundations-group) for approval. The Foundations DRI will work with UX partners in product design, research, and technical writing, as applicable.
 - [ ] Engage the [Foundations](https://about.gitlab.com/handbook/product/categories/#foundations-group) team to ensure your proposal is in alignment with holistic changes happening to the left side bar.
 - [ ] Consider whether you need to communicate the change somehow, or if you will have an interim period in the UI where your nav item will live in more than one place.
 

.gitlab/merge_request_templates/Deprecations.md

@@ -73,7 +73,6 @@ yourself as a reviewer if it's not ready for merge yet.
 - [ ] Title:
   - Length limit: 7 words (not including articles or prepositions).
   - Capitalization: ensure the title is [sentence cased](https://design.gitlab.com/content/punctuation#case).
-  - Rewrite to exclude the words `deprecation`, `deprecate`, `removal`, and `remove` if necessary.
 - [ ] Consistency:
   - Ensure that all resources (docs, deprecation, etc.) refer to the feature with the same term / feature name.
 - [ ] Content:

.gitlab/merge_request_templates/Removals.md

@@ -78,7 +78,6 @@ yourself as a reviewer if it's not yet ready for merge.
 - [ ] Title:
   - Length limit: 7 words (not including articles or prepositions).
   - Capitalization: ensure the title is [sentence cased](https://design.gitlab.com/content/punctuation#case).
-  - Rewrite to exclude the words `removal` and `remove` if necessary.
 - [ ] Consistency:
   - Ensure that all resources (docs, removal, etc.) refer to the feature with the same term / feature name.
 - [ ] Content:

.gitlab/merge_request_templates/Revert To Resolve Incident.md

+## Purpose of Revert
+
+<!-- Please link to the relevant incident -->
+
+### Check-list
+
+- [ ] Create an issue to reinstate the merge request and assign it to the author of the reverted merge request.
+- [ ] If the revert is to resolve a ['broken master' incident](https://about.gitlab.com/handbook/engineering/workflow/#broken-master), please read through the [Responsibilities of the Broken 'Master' resolution DRI](https://about.gitlab.com/handbook/engineering/workflow/#responsibilities-of-the-resolution-dri)
+
+/label ~"pipeline:expedite-master-fixing" ~"master:broken"

.rubocop.yml

@@ -53,6 +53,16 @@ AllCops:
   NewCops: disable
   SuggestExtensions: false
 
+Rails:
+  Exclude:
+    # User defined excludes on top (department) level don't cancel default
+    # includes set by child cops. Directories below are not affected (tested
+    # manually). Watch https://github.com/rubocop/rubocop/issues/11148 to
+    # know when this comment can be removed.
+    - 'danger/**/*'
+    - 'tooling/danger/**/*'
+    - 'rubocop/**/*'
+
 RSpec:
   Language:
     Includes:
@@ -272,10 +282,6 @@ Rails/FindBy:
     - 'spec/**/*.rb'
     - 'ee/spec/**/*.rb'
 
-Rails/IndexBy:
-  Exclude:
-    - 'tooling/danger/**/*.rb'
-
 Rails/InverseOf:
   Include:
     - app/models/**/*.rb

.rubocop_todo/database/multiple_databases.yml

@@ -5,14 +5,7 @@ Database/MultipleDatabases:
     - 'db/post_migrate/20210811122206_update_external_project_bots.rb'
     - 'db/post_migrate/20210812013042_remove_duplicate_project_authorizations.rb'
     - 'ee/spec/services/ee/merge_requests/update_service_spec.rb'
-    - 'spec/db/schema_spec.rb'
-    - 'spec/initializers/database_config_spec.rb'
-    - 'spec/lib/gitlab/database_spec.rb'
-    - 'spec/lib/gitlab/metrics/subscribers/active_record_spec.rb'
-    - 'spec/lib/gitlab/profiler_spec.rb'
-    - 'spec/lib/gitlab/usage/metrics/names_suggestions/relation_parsers/joins_spec.rb'
     - 'spec/support/caching.rb'
-    - 'spec/support/gitlab/usage/metrics_instrumentation_shared_examples.rb'
     - 'spec/support/helpers/database/database_helpers.rb'
     - 'spec/support/helpers/database/table_schema_helpers.rb'
     - 'spec/support/helpers/migrations_helpers.rb'

.rubocop_todo/gitlab/strong_memoize_attr.yml

@@ -592,7 +592,6 @@ Gitlab/StrongMemoizeAttr:
     - 'lib/gitlab/ci/build/auto_retry.rb'
     - 'lib/gitlab/ci/build/cache.rb'
     - 'lib/gitlab/ci/build/context/base.rb'
-    - 'lib/gitlab/ci/build/context/build.rb'
     - 'lib/gitlab/ci/build/context/global.rb'
     - 'lib/gitlab/ci/build/prerequisite/kubernetes_namespace.rb'
     - 'lib/gitlab/ci/build/rules/rule/clause/changes.rb'
@@ -620,10 +619,8 @@ Gitlab/StrongMemoizeAttr:
     - 'lib/gitlab/ci/pipeline/logger.rb'
     - 'lib/gitlab/ci/pipeline/metrics.rb'
     - 'lib/gitlab/ci/pipeline/quota/deployments.rb'
-    - 'lib/gitlab/ci/pipeline/seed/build.rb'
     - 'lib/gitlab/ci/pipeline/seed/pipeline.rb'
     - 'lib/gitlab/ci/pipeline/seed/processable/resource_group.rb'
-    - 'lib/gitlab/ci/pipeline/seed/stage.rb'
     - 'lib/gitlab/ci/project_config/auto_devops.rb'
     - 'lib/gitlab/ci/project_config/external_project.rb'
     - 'lib/gitlab/ci/project_config/parameter.rb'

.rubocop_todo/layout/empty_line_between_defs.yml

----
-# Cop supports --autocorrect.
-Layout/EmptyLineBetweenDefs:
-  Exclude:
-    - 'db/post_migrate/20220202105733_delete_service_template_records.rb'
-    - 'ee/lib/ee/gitlab/background_migration/populate_resolved_on_default_branch_column.rb'
-    - 'lib/gitlab/import_export/remote_stream_upload.rb'
-    - 'lib/gitlab/redis/multi_store.rb'

.rubocop_todo/layout/first_array_element_indentation.yml

----
-# Cop supports --autocorrect.
-Layout/FirstArrayElementIndentation:
-  Exclude:
-    - 'spec/lib/gitlab/github_import/importer/issues_importer_spec.rb'
-    - 'spec/lib/gitlab/search/found_blob_spec.rb'
-    - 'spec/models/ci/runner_version_spec.rb'
-    - 'spec/models/repository_spec.rb'
-    - 'spec/requests/api/task_completion_status_spec.rb'
-    - 'spec/services/security/merge_reports_service_spec.rb'
-    - 'spec/simplecov_env.rb'
-    - 'spec/support/atlassian/jira_connect/schemata.rb'
-    - 'spec/support/capybara.rb'
-    - 'spec/support/helpers/project_template_test_helper.rb'
-    - 'spec/support/helpers/test_env.rb'
-    - 'spec/support/helpers/usage_data_helpers.rb'
-    - 'spec/support/matchers/exceed_query_limit.rb'
-    - 'spec/support/migrations_helpers/vulnerabilities_findings_helper.rb'
-    - 'spec/support/prometheus/additional_metrics_shared_examples.rb'
-    - 'spec/support/shared_contexts/policies/group_policy_shared_context.rb'
-    - 'spec/support/shared_examples/graphql/label_fields.rb'
-    - 'spec/support/shared_examples/lib/gitlab/middleware/multipart_shared_examples.rb'
-    - 'spec/support/shared_examples/requests/api/repository_storage_moves_shared_examples.rb'
-    - 'spec/views/projects/issues/_related_branches.html.haml_spec.rb'
-    - 'tooling/lib/tooling/helm3_client.rb'

.rubocop_todo/layout/first_hash_element_indentation.yml

@@ -2,22 +2,6 @@
 # Cop supports --autocorrect.
 Layout/FirstHashElementIndentation:
   Exclude:
-    - 'app/components/diffs/stats_component.rb'
-    - 'app/controllers/admin/ci/variables_controller.rb'
-    - 'app/controllers/admin/system_info_controller.rb'
-    - 'app/controllers/concerns/milestone_actions.rb'
-    - 'app/controllers/concerns/render_service_results.rb'
-    - 'app/controllers/concerns/sourcegraph_decorator.rb'
-    - 'app/controllers/profiles/two_factor_auths_controller.rb'
-    - 'app/controllers/projects/badges_controller.rb'
-    - 'app/controllers/repositories/lfs_locks_api_controller.rb'
-    - 'app/experiments/concerns/project_commit_count.rb'
-    - 'app/graphql/mutations/clusters/agent_tokens/create.rb'
-    - 'app/graphql/mutations/notes/create/diff_note.rb'
-    - 'app/graphql/mutations/notes/create/image_diff_note.rb'
-    - 'app/graphql/mutations/notes/create/note.rb'
-    - 'app/graphql/mutations/todos/restore_many.rb'
-    - 'app/graphql/resolvers/group_packages_resolver.rb'
     - 'app/helpers/avatars_helper.rb'
     - 'app/helpers/breadcrumbs_helper.rb'
     - 'app/helpers/broadcast_messages_helper.rb'
@@ -212,7 +196,6 @@ Layout/FirstHashElementIndentation:
     - 'ee/spec/requests/api/members_spec.rb'
     - 'ee/spec/requests/api/merge_requests_spec.rb'
     - 'ee/spec/requests/groups/group_members_controller_spec.rb'
-    - 'ee/spec/requests/groups/usage_quotas_spec.rb'
     - 'ee/spec/requests/projects/issue_feature_flags_controller_spec.rb'
     - 'ee/spec/serializers/issues/linked_issue_feature_flag_entity_spec.rb'
     - 'ee/spec/serializers/license_entity_spec.rb'

.rubocop_todo/layout/line_length.yml

@@ -4699,7 +4699,6 @@ Layout/LineLength:
     - 'spec/lib/gitlab/usage/metrics/instrumentations/redis_hll_metric_spec.rb'
     - 'spec/lib/gitlab/usage/metrics/name_suggestion_spec.rb'
     - 'spec/lib/gitlab/usage/metrics/names_suggestions/generator_spec.rb'
-    - 'spec/lib/gitlab/usage/metrics/names_suggestions/relation_parsers/joins_spec.rb'
     - 'spec/lib/gitlab/usage/metrics/query_spec.rb'
     - 'spec/lib/gitlab/usage/service_ping/payload_keys_processor_spec.rb'
     - 'spec/lib/gitlab/usage/service_ping_report_spec.rb'

.rubocop_todo/layout/space_inside_parens.yml

 ---
 # Cop supports --autocorrect.
 Layout/SpaceInsideParens:
-  # Offense count: 422
-  # Temporarily disabled due to too many offenses
-  Enabled: false
+  Details: grace period
   Exclude:
     - 'db/post_migrate/20210722042939_update_issuable_slas_where_issue_closed.rb'
     - 'ee/app/models/ee/dependency_proxy/blob.rb'
@@ -11,6 +9,7 @@ Layout/SpaceInsideParens:
     - 'ee/lib/ee/gitlab/auth/ldap/access.rb'
     - 'ee/lib/gitlab/auth/smartcard/session.rb'
     - 'ee/lib/system_check/geo/current_node_check.rb'
+    - 'ee/spec/controllers/projects/mirrors_controller_spec.rb'
     - 'ee/spec/finders/ee/alert_management/http_integrations_finder_spec.rb'
     - 'ee/spec/finders/epics_finder_spec.rb'
     - 'ee/spec/finders/security/findings_finder_spec.rb'
@@ -31,6 +30,7 @@ Layout/SpaceInsideParens:
     - 'ee/spec/models/ee/iteration_spec.rb'
     - 'ee/spec/models/ee/iterations/cadence_spec.rb'
     - 'ee/spec/models/ee/key_spec.rb'
+    - 'ee/spec/models/ee/project_setting_spec.rb'
     - 'ee/spec/models/ee/system_note_metadata_spec.rb'
     - 'ee/spec/models/geo/every_geo_event_spec.rb'
     - 'ee/spec/models/incident_management/escalation_rule_spec.rb'
@@ -87,21 +87,6 @@ Layout/SpaceInsideParens:
     - 'ee/spec/support/shared_examples/services/geo/geo_request_service_shared_examples.rb'
     - 'ee/spec/workers/elastic/migration_worker_spec.rb'
     - 'ee/spec/workers/security/auto_fix_worker_spec.rb'
-    - 'lib/backup/files.rb'
-    - 'lib/gitlab/ci/reports/security/finding.rb'
-    - 'lib/gitlab/ci/runner_instructions.rb'
-    - 'lib/gitlab/database/partitioning/single_numeric_list_partition.rb'
-    - 'lib/gitlab/database/postgres_hll/buckets.rb'
-    - 'lib/gitlab/diff/parser.rb'
-    - 'lib/gitlab/gitaly_client/commit_service.rb'
-    - 'lib/gitlab/import_export/decompressed_archive_size_validator.rb'
-    - 'lib/gitlab/memory/watchdog/monitor_state.rb'
-    - 'lib/gitlab/prometheus_client.rb'
-    - 'lib/gitlab/sidekiq_daemon/memory_killer.rb'
-    - 'lib/gitlab/tracking/incident_management.rb'
-    - 'lib/gitlab/visibility_level.rb'
-    - 'lib/security/ci_configuration/sast_build_action.rb'
-    - 'lib/tasks/gitlab/sidekiq.rake'
     - 'qa/qa/page/group/settings/group_deploy_tokens.rb'
     - 'qa/qa/specs/features/ee/browser_ui/10_govern/scan_result_policy_vulnerabilities_spec.rb'
     - 'qa/qa/tools/delete_subgroups.rb'
@@ -205,6 +190,8 @@ Layout/SpaceInsideParens:
     - 'spec/mailers/emails/profile_spec.rb'
     - 'spec/migrations/20211130165043_backfill_sequence_column_for_sprints_table_spec.rb'
     - 'spec/migrations/backfill_issues_upvotes_count_spec.rb'
+    - 'spec/models/ci/pending_build_spec.rb'
+    - 'spec/models/ci/running_build_spec.rb'
     - 'spec/models/ml/candidate_metric_spec.rb'
     - 'spec/models/ml/candidate_spec.rb'
     - 'spec/policies/clusters/agent_policy_spec.rb'

.rubocop_todo/rails/active_record_callbacks_order.yml

@@ -12,8 +12,6 @@ Rails/ActiveRecordCallbacksOrder:
     - 'app/models/namespace_statistics.rb'
     - 'app/models/note.rb'
     - 'app/models/pages_domain.rb'
-    - 'app/models/personal_access_token.rb'
-    - 'app/models/project.rb'
     - 'app/models/prometheus_alert.rb'
     - 'app/models/remote_mirror.rb'
     - 'app/models/resource_label_event.rb'

.rubocop_todo/rspec/context_wording.yml

@@ -145,7 +145,6 @@ RSpec/ContextWording:
     - 'ee/spec/features/merge_requests/user_filters_by_approvers_spec.rb'
     - 'ee/spec/features/oncall_schedules/user_creates_schedule_spec.rb'
     - 'ee/spec/features/profiles/account_spec.rb'
-    - 'ee/spec/features/profiles/usage_quotas_spec.rb'
     - 'ee/spec/features/projects/active_tabs_spec.rb'
     - 'ee/spec/features/projects/audit_events_spec.rb'
     - 'ee/spec/features/projects/custom_projects_template_spec.rb'