Commits on Source (46)
-
Jacques Erasmus authored
Fixes the blob viewer to display the correct amount of line numbers Changelog: fixed
-
gdk authored
The `Group Boards Creates an issue adds an issue to the backlog` test has the ~"flakiness::1" label set, which means it has more than 1000 flakiness reports. This MR quarantines the test. This is a discussion starting point to let the responsible group know about the flakiness so that they can take action: - accept the merge request and schedule the associated issue to improve the test - close the merge request in favor of another merge request to delete the test Please follow the [Flaky tests management process](https://handbook.gitlab.com/handbook/engineering/infrastructure/engineering-productivity/flaky-tests-management-and-processes/#flaky-tests-management-process) to help us increase `master` stability. Please let us know your feedback [in the dedicated issue](gitlab-org/quality/engineering-productivity/team#447). Related to #458723. This change was generated by [gitlab-housekeeper](https://gitlab.com/gitlab-org/gitlab/-/tree/master/gems/gitlab-housekeeper) using the Keeps::QuarantineFlakyTests keep. To provide feedback on your experience with `gitlab-housekeeper` please comment in <#442003>. Changelog: other
-
Mehmet Emin INAC authored
-
Valerie Burton authored
Removes the Chemlab Gitlab::Page::Main::SignUp page and makes use of QA::Page::Registration::SignUp for E2E tests instead
-
Dan Davison authored
-
Jay McCure authored
This reverts merge request !152023
-
Sascha Eggenberger authored
Changelog: changed
-
Paul Gascou-Vaillancourt authored
Migrates the `gl-reset-bg` CSS util to its Tailwind equivalent configured as `gl-bg-inherit`.
-
Payton Burdette authored
-
Lucas Charles authored
Hide rca button for passing jobs See merge request !152648 Merged-by:
Lucas Charles <me@lucascharles.me> Approved-by:
Veethika Mishra <6115425-veethika@users.noreply.gitlab.com> Approved-by:
Vamsi Vempati <vvempati@gitlab.com> Approved-by:
Jose Ivan Vargas <jvargas@gitlab.com> Approved-by:
Lucas Charles <me@lucascharles.me> Reviewed-by:
Veethika Mishra <6115425-veethika@users.noreply.gitlab.com> Reviewed-by:
Vamsi Vempati <vvempati@gitlab.com> Co-authored-by:
Payton Burdette <pburdette@gitlab.com>
-
Sami Hiltunen authored
This reverts commit 476f41da.
-
Emerald-Jayde Henao authored
-
Jon Glassman authored
Update docs with support for html, css, sql, shell for VSCode See merge request !150300 Merged-by:
Jon Glassman <jglassman@gitlab.com> Approved-by:
Jon Glassman <jglassman@gitlab.com> Co-authored-by:
Emerald-Jayde Henao <ejhenao@gitlab.com>
-
Allen Cook authored
Dont force creation of Ci::NamespaceMirror during test runs See merge request !153002 Merged-by:
Allen Cook <acook@gitlab.com> Approved-by:
Moaz Khalifa <mkhalifa@gitlab.com> Approved-by:
Allen Cook <acook@gitlab.com> Reviewed-by:
Dan Davison <ddavison@gitlab.com> Reviewed-by:
Tim Poffenbarger <tpoffenbarger@gitlab.com> Reviewed-by:
Moaz Khalifa <mkhalifa@gitlab.com> Co-authored-by:
ddavison <ddavison@gitlab.com>
-
Anton Kalmykov authored
Later we will use this column to implement logic to display a correct access given date Related to: #24721 Changelog: added
-
Pavel Shutsin authored
Add request_accepted_at column to the members table See merge request !152584 Merged-by:
Pavel Shutsin <pshutsin@gitlab.com> Approved-by:
Abhilash Kotte <akotte@gitlab.com> Approved-by:
Pavel Shutsin <pshutsin@gitlab.com> Reviewed-by:
George Koltsov <gkoltsov@gitlab.com> Reviewed-by:
Pavel Shutsin <pshutsin@gitlab.com> Reviewed-by:
Rajendra Kadam <rkadam@gitlab.com> Co-authored-by:
Anton Kalmykov <anton.kalmykov@proton.me>
-
gitlab-housekeeper authored
Add sharding key tracking issues for feature category `feature_flags`. ## Background These tables were unable to be classified automatically, and will require manual input. Eventually all tables will need to be correctly classified, but we understand that this will be complex for some tables and completing these will take time. Instead, our goal for this task is to ensure all remaining tables are tracked in an issue, and to classify any straightforward cases that our automation may have missed (options 1 and 2 below). We have assigned a random backend engineer from ~"group::environments" as the initial DRI for this task, as well as an engineering manager for visibility. Please note that we are not requesting a large time commitment, creating one issue and linking it for all tables is perfectly acceptable. When you are finished, please assign to the ~database reviewer/maintainer suggested by Danger. If you have any questions or concerns, reach out to `#g_tenant-scale`. ## Task For each table, please select one of the following options: ### Option 1: Add a sharding key tracking issue This option is best suited to tables whose sharding behaviour is unknown, or will require additional work before a sharding key can be defined. Replace the `TODO` in the dictionary file with a link to an issue in the gitlab-org/gitlab project. ```diff - sharding_key_issue_url: TODO + sharding_key_issue_url: #1234 ``` You can create a new issue or link an existing one, and multiple entries can refer to the same issue. These issues will be used to track the work remaining on the [progress dashboard](https://cells-progress-tracker-gitlab-org-tenant-scale-g-f4ad96bf01d25f.gitlab.io/sharding_keys). If you are creating a new issue, you can copy over the following contents to the issue description: <details><summary>Click to expand</summary> Issue Title: Set sharding keys for tables in 'group::environments' Issue Description: Sharding keys need to be set for the tables: feature_gates, features This involves choosing one of the following, based on the intended behaviour of the table: - **The table is not cell-local** - Set `gitlab_schema` to `gitlab_main_clusterwide`. - **The table is cell-local and requires a sharding key** - Set `gitlab_schema` to `gitlab_main_cell` - Add a `sharding_key` or `desired_sharding_key` configuration. If the configuration is known but the chosen key doesn't yet meet not-null and foreign key requirements, you can add an exception to `allowed_to_be_missing_not_null` or `allowed_to_be_missing_foreign_key` to get the pipeline passing. Please link to a follow-up issue in a code comment next to the exception. - You may also need to set `allow_cross_joins`, `allow_cross_transactions` and `allow_cross_foreign_keys` if changing the schema causes pipeline failures. See [`db/docs/epics.yml`](https://gitlab.com/gitlab-org/gitlab/-/blob/master/db/docs/epics.yml?ref_type=heads#L12-17) for an example. - **The table is cell-local and does not require a sharding key** - Set `gitlab_schema` to `gitlab_main_cell` and - Set `exempt_from_sharding` to `true`. ### Documentation - [Choosing either the gitlab_main_cell or gitlab_main_clusterwide schema](https://docs.gitlab.com/ee/development/database/multiple_databases.html#choose-either-the-gitlab_main_cell-or-gitlab_main_clusterwide-schema) - [Defining a sharding key for all cell-local tables](https://docs.gitlab.com/ee/development/database/multiple_databases.html#defining-a-sharding-key-for-all-cell-local-tables) - [Defining a desired_sharding_key to automatically backfill a sharding_key](https://docs.gitlab.com/ee/development/database/multiple_databases.html#define-a-desired_sharding_key-to-automatically-backfill-a-sharding_key) </details> ### Option 2: Add sharding key configuration This option is best suited to tables with an easily identifiable sharding key that will require minimal work to define. Remove `sharding_key_issue_url` from the dictionary file and instead complete the classification for the table. This involves choosing one of the following, based on the intended behaviour of the table: - **The table is not cell-local** - Set `gitlab_schema` to `gitlab_main_clusterwide`. - **The table is cell-local and requires a sharding key** - Set `gitlab_schema` to `gitlab_main_cell` - Add a `sharding_key` or `desired_sharding_key` configuration. If the configuration is known but the chosen key doesn't yet meet not-null and foreign key requirements, you can add an exception to `allowed_to_be_missing_not_null` or `allowed_to_be_missing_foreign_key` to get the pipeline passing. Please link to a follow-up issue in a code comment next to the exception. - You may also need to set `allow_cross_joins`, `allow_cross_transactions` and `allow_cross_foreign_keys` if changing the schema causes pipeline failures. See [`db/docs/epics.yml`](https://gitlab.com/gitlab-org/gitlab/-/blob/master/db/docs/epics.yml?ref_type=heads#L12-17) for an example. - **The table is cell-local and does not require a sharding key** - Set `gitlab_schema` to `gitlab_main_cell` and - Set `exempt_from_sharding` to `true`. ### Documentation - [Choosing either the gitlab_main_cell or gitlab_main_clusterwide schema](https://docs.gitlab.com/ee/development/database/multiple_databases.html#choose-either-the-gitlab_main_cell-or-gitlab_main_clusterwide-schema) - [Defining a sharding key for all cell-local tables](https://docs.gitlab.com/ee/development/database/multiple_databases.html#defining-a-sharding-key-for-all-cell-local-tables) - [Defining a desired_sharding_key to automatically backfill a sharding_key](https://docs.gitlab.com/ee/development/database/multiple_databases.html#define-a-desired_sharding_key-to-automatically-backfill-a-sharding_key) Related to #455137 This change was generated by [gitlab-housekeeper](https://gitlab.com/gitlab-org/gitlab/-/tree/master/gems/gitlab-housekeeper) using the Keeps::AddShardingKeyTrackingIssues keep. To provide feedback on your experience with `gitlab-housekeeper` please comment in <#442003>. Changelog: other
-
Jon Jenkins authored
Add sharding key tracking issues for feature_flags See merge request !152820 Merged-by:
Jon Jenkins <jjenkins@gitlab.com> Approved-by:
Jon Jenkins <jjenkins@gitlab.com> Reviewed-by:
Tiger Watson <twatson@gitlab.com> Co-authored-by:
Tiger Watson <twatson@gitlab.com> Co-authored-by:
Manoj M J <mmj@gitlab.com>
-
Mehmet Emin INAC authored
Rename `VERSIONS_TO_REMOVE_IN_x` constant from 17_0 to 18_0 See merge request !153094 Merged-by:
Mehmet Emin INAC <minac@gitlab.com> Approved-by:
Thomas Hutterer <thutterer@gitlab.com> Approved-by:
Sylvester Chin <schin@gitlab.com>
-
Carla Drago authored
This ensures all cloned or moved issues do not retain any imported_from value, but sets it to :none. Changelog: fixed
-
Carla Drago authored
Update imported_from value when cloning and moving issues See merge request !152949 Merged-by:
Carla Drago <cdrago@gitlab.com> Approved-by:
Bojan Marjanovic <bmarjanovic@gitlab.com> Reviewed-by:
Luke Duncalfe <lduncalfe@gitlab.com> Reviewed-by:
Bojan Marjanovic <bmarjanovic@gitlab.com> Reviewed-by:
James Nutt <jnutt@gitlab.com>
-
Alexandr Tanayno authored
-
Marcin Sedlak-Jakubowski authored
Adds note about issues with default branch for sub subgroups See merge request !153432 Merged-by:
Marcin Sedlak-Jakubowski <msedlakjakubowski@gitlab.com> Approved-by:
Marcin Sedlak-Jakubowski <msedlakjakubowski@gitlab.com> Co-authored-by:
Alexandr Tanayno <atanayno@gitlab.com>
-
Ravi Kumar authored
-
Dmitry Gruzd authored
Elastic migration 20230911205548 test quarantined See merge request !152605 Merged-by:
Dmitry Gruzd <dgruzd@gitlab.com> Approved-by:
Jon Jenkins <jjenkins@gitlab.com> Approved-by:
Suraj Tripathi <stripathi@gitlab.com> Approved-by:
Dmitry Gruzd <dgruzd@gitlab.com> Co-authored-by:
rkumar555 <rkumar@gitlab.com>
-
Peter Leitzen authored
Revert "Add CI jobs with Gitaly transactions" See merge request !153450 Merged-by:
Peter Leitzen <pleitzen@gitlab.com> Approved-by:
Vladimir Glafirov <vglafirov@gitlab.com> Approved-by:
Peter Leitzen <pleitzen@gitlab.com> Co-authored-by:
Sami Hiltunen <shiltunen@gitlab.com>
-
Payton Burdette authored
Migrate `gl-reset-bg` to Tailwind See merge request !153430 Merged-by:
Payton Burdette <pburdette@gitlab.com> Approved-by:
Payton Burdette <pburdette@gitlab.com> Co-authored-by:
Paul Gascou-Vaillancourt <paul.gascvail@gmail.com>
-
Terri Chu authored
Improvements for Keeps::MarkOldAdvancedSearchMigrationsAsObsolete See merge request !152992 Merged-by:
Terri Chu <tchu@gitlab.com> Approved-by:
Ravi Kumar <rkumar@gitlab.com> Approved-by:
John Mason <9717668-johnmason@users.noreply.gitlab.com>
-
Javiera Tapia authored
Changelog: other
-
Gary Holtz authored
Revert "Merge branch '442899-update-project-rest-api' into 'master'" See merge request !153362 Merged-by:
Gary Holtz <gholtz@gitlab.com> Approved-by:
Alex Buijs <abuijs@gitlab.com> Approved-by:
Gary Holtz <gholtz@gitlab.com> Co-authored-by:
Jay McCure <jmccure@gitlab.com>
-
Ian Anderson authored
Changelog: added EE: true
-
Jose Ivan Vargas authored
Add pipeline validator to check identity verification Closes gitlab-org/modelops/anti-abuse/team-tasks#669 See merge request !151834 Merged-by:
Jose Ivan Vargas <jvargas@gitlab.com> Approved-by:
Rudy Crespo <rcrespo@gitlab.com> Approved-by:
Aboobacker MK <akarakath@gitlab.com> Approved-by:
Fabio Pitino <fpitino@gitlab.com> Approved-by:
Jose Ivan Vargas <jvargas@gitlab.com> Reviewed-by:
Fabio Pitino <fpitino@gitlab.com> Reviewed-by:
Ian Anderson <ianderson@gitlab.com> Co-authored-by:
imand3r <ianderson@gitlab.com>
-
Javiera Tapia authored
Quarantine `protected_branches_access_control_ce_shared_examples` See merge request !153446 Merged-by:
Javiera Tapia <jtapia@gitlab.com> Approved-by:
Peter Leitzen <pleitzen@gitlab.com>
-
Tristan Read authored
Fix blob viewer line numbers See merge request !152331 Merged-by:
Tristan Read <tread@gitlab.com> Approved-by:
Andrei Zubov <azubov@gitlab.com> Approved-by:
Tristan Read <tread@gitlab.com> Co-authored-by:
Jacques <jerasmus@gitlab.com>
-
Mark Florian authored
AI Generate commit message: Change text of button See merge request !153276 Merged-by:
Mark Florian <mflorian@gitlab.com> Approved-by:
Mark Florian <mflorian@gitlab.com> Reviewed-by:
Amy Qualls <aqualls@gitlab.com> Co-authored-by:
Sascha Eggenberger <seggenberger@gitlab.com>
-
Brett Walker authored
Quarantine a flaky test See merge request !152880 Merged-by:
Brett Walker <bwalker@gitlab.com> Approved-by:
Brett Walker <bwalker@gitlab.com> Co-authored-by:
gdk <gdk@example.com>
-
Alexandr Tanayno authored
While I'm here, let's make these tables easier to read.
-
Amy Qualls authored
Add notes on curl params required when downloading package files via API See merge request !153422 Merged-by:
Amy Qualls <aqualls@gitlab.com> Approved-by:
Amy Qualls <aqualls@gitlab.com> Co-authored-by:
Alexandr Tanayno <atanayno@gitlab.com>
-
Madelein van Niekerk authored
Add es query builder support for multi-match See merge request !153040 Merged-by:
Madelein van Niekerk <mvanniekerk@gitlab.com> Approved-by:
Madelein van Niekerk <mvanniekerk@gitlab.com> Reviewed-by:
Terri Chu <tchu@gitlab.com> Co-authored-by:
Terri Chu <tchu@gitlab.com>
-
Sofia Vistas authored
Co-authored-by:
Valerie Burton <vburton@gitlab.com>
-
Tiffany Rea authored
Remove reliable concept from docs See merge request !148708 Merged-by:
Tiffany Rea <trea@gitlab.com> Approved-by:
Valerie Burton <vburton@gitlab.com> Approved-by:
Tiffany Rea <trea@gitlab.com> Reviewed-by:
Valerie Burton <vburton@gitlab.com> Co-authored-by:
Sofia Vistas <svistas@gitlab.com>
-
Archish Thakkar authored
-
Nao Hashizume authored
Fix for Performance/StringReplacement Naming/HeredocDelimiterCase See merge request !151038 Merged-by:
Nao Hashizume <nhashizume@gitlab.com> Approved-by:
Pedro Pombeiro <noreply@pedro.pombei.ro> Approved-by:
Jason Goodman <jgoodman@gitlab.com> Approved-by:
Nao Hashizume <nhashizume@gitlab.com> Reviewed-by:
Pedro Pombeiro <noreply@pedro.pombei.ro> Co-authored-by:
Archish Thakkar <archishthakkar@gmail.com>
-
Peter Leitzen authored
E2E: Remove Chemlab Gitlab::Page::Main::SignUp Page See merge request !153135 Merged-by:
Peter Leitzen <pleitzen@gitlab.com> Approved-by:
Désirée Chevalier <dchevalier@gitlab.com> Approved-by:
Sanad Liaquat <sliaquat@gitlab.com> Approved-by:
Peter Leitzen <pleitzen@gitlab.com> Co-authored-by:
Valerie Burton <vburton@gitlab.com>
Showing
- .gitlab/ci/rails.gitlab-ci.yml 0 additions, 27 deletions.gitlab/ci/rails.gitlab-ci.yml
- .gitlab/ci/rails/shared.gitlab-ci.yml 0 additions, 4 deletions.gitlab/ci/rails/shared.gitlab-ci.yml
- .rubocop_todo/layout/line_length.yml 0 additions, 1 deletion.rubocop_todo/layout/line_length.yml
- .rubocop_todo/naming/heredoc_delimiter_case.yml 0 additions, 9 deletions.rubocop_todo/naming/heredoc_delimiter_case.yml
- .rubocop_todo/performance/string_replacement.yml 0 additions, 8 deletions.rubocop_todo/performance/string_replacement.yml
- .rubocop_todo/style/redundant_self.yml 0 additions, 1 deletion.rubocop_todo/style/redundant_self.yml
- app/assets/javascripts/blob/components/blob_content.vue 3 additions, 5 deletionsapp/assets/javascripts/blob/components/blob_content.vue
- app/assets/javascripts/ci/pipeline_details/jobs/components/failed_jobs_table.vue 1 addition, 1 deletion...ci/pipeline_details/jobs/components/failed_jobs_table.vue
- app/assets/javascripts/ci/pipeline_new/constants.js 1 addition, 1 deletionapp/assets/javascripts/ci/pipeline_new/constants.js
- app/assets/javascripts/environments/components/deploy_board_wrapper.vue 1 addition, 1 deletion...ascripts/environments/components/deploy_board_wrapper.vue
- app/assets/javascripts/work_items/components/work_item_detail_modal.vue 1 addition, 1 deletion...ascripts/work_items/components/work_item_detail_modal.vue
- app/models/member.rb 1 addition, 1 deletionapp/models/member.rb
- app/services/design_management/copy_design_collection/copy_service.rb 0 additions, 2 deletions.../design_management/copy_design_collection/copy_service.rb
- app/services/issues/clone_service.rb 1 addition, 0 deletionsapp/services/issues/clone_service.rb
- app/services/issues/move_service.rb 2 additions, 1 deletionapp/services/issues/move_service.rb
- app/services/notes/copy_service.rb 2 additions, 2 deletionsapp/services/notes/copy_service.rb
- config/tailwind.config.js 4 additions, 0 deletionsconfig/tailwind.config.js
- db/docs/feature_gates.yml 1 addition, 0 deletionsdb/docs/feature_gates.yml
- db/docs/features.yml 1 addition, 0 deletionsdb/docs/features.yml
- db/migrate/20240509192214_add_request_accepted_at_to_members.rb 9 additions, 0 deletions...rate/20240509192214_add_request_accepted_at_to_members.rb