.rubocop_todo/gitlab/documentation_links/link.yml

@@ -17,14 +17,12 @@ Gitlab/DocumentationLinks/Link:
     - 'ee/app/helpers/ee/groups/settings_helper.rb'
     - 'ee/app/helpers/ee/import_helper.rb'
     - 'ee/app/helpers/projects/learn_gitlab_helper.rb'
-    - 'ee/app/helpers/projects/security/api_fuzzing_configuration_helper.rb'
     - 'ee/app/helpers/vulnerabilities_helper.rb'
     - 'ee/lib/ee/gitlab/namespace_storage_size_error_message.rb'
     - 'ee/lib/gitlab/checks/secrets_check.rb'
     - 'ee/lib/gitlab/llm/chain/tools/tool.rb'
     - 'ee/lib/gitlab/llm/embeddings/utils/base_content_parser.rb'
     - 'ee/lib/system_check/geo/current_node_check.rb'
-    - 'ee/spec/helpers/ee/projects/security/api_fuzzing_configuration_helper_spec.rb'
     - 'ee/spec/helpers/projects/learn_gitlab_helper_spec.rb'
     - 'ee/spec/lib/gitlab/llm/embeddings/utils/base_content_parser_spec.rb'
     - 'ee/spec/presenters/gitlab_subscriptions/trials/duo_enterprise_status_widget_presenter_spec.rb'

.rubocop_todo/lint/redundant_cop_disable_directive.yml

@@ -7,24 +7,11 @@ Lint/RedundantCopDisableDirective:
   Exclude:
     - 'app/controllers/concerns/enforces_two_factor_authentication.rb'
     - 'app/controllers/groups/milestones_controller.rb'
-    - 'app/finders/autocomplete/move_to_project_finder.rb'
-    - 'app/finders/autocomplete/routes_finder.rb'
-    - 'app/finders/autocomplete/users_finder.rb'
-    - 'app/finders/ci/daily_build_group_report_results_finder.rb'
-    - 'app/finders/ci/runner_jobs_finder.rb'
-    - 'app/finders/users_finder.rb'
-    - 'app/graphql/resolvers/ci/pipeline_job_artifacts_resolver.rb'
-    - 'app/graphql/types/ci/runner_web_url_edge.rb'
     - 'app/models/work_items/type.rb'
     - 'app/policies/issue_policy.rb'
-    - 'app/presenters/ci/build_runner_presenter.rb'
-    - 'app/services/ci/register_job_service.rb'
-    - 'app/services/ci/retry_job_service.rb'
     - 'app/services/work_items/data_sync/clone_service.rb'
     - 'app/services/work_items/data_sync/move_service.rb'
     - 'app/workers/authorized_project_update/user_refresh_over_user_range_worker.rb'
-    - 'app/workers/ci/track_failed_build_worker.rb'
-    - 'app/workers/run_pipeline_schedule_worker.rb'
     - 'config/initializers/warden.rb'
     - 'db/migrate/20240701145111_add_namespace_import_users_table.rb'
     - 'db/migrate/20240829163210_create_instance_integrations_table.rb'
@@ -52,14 +39,6 @@ Lint/RedundantCopDisableDirective:
     - 'db/post_migrate/20240902014331_sync_fk_referencing_p_ci_pipelines.rb'
     - 'db/post_migrate/20240917143249_partition_ci_build_trace_metadata3.rb'
     - 'ee/app/controllers/ee/projects/settings/ci_cd_controller.rb'
-    - 'ee/app/finders/epics/with_issues_finder.rb'
-    - 'ee/app/finders/geo/registry_finder.rb'
-    - 'ee/app/finders/groups/users_finder.rb'
-    - 'ee/app/finders/search/groups_finder.rb'
-    - 'ee/app/finders/search/projects_finder.rb'
-    - 'ee/app/finders/status_page/incident_comments_finder.rb'
-    - 'ee/app/finders/status_page/incidents_finder.rb'
-    - 'ee/app/models/ci/finished_build_ch_sync_event.rb'
     - 'ee/app/services/search/zoekt/routing_service.rb'
     - 'ee/app/services/security/token_revocation_service.rb'
     - 'ee/db/geo/migrate/20210504143244_add_verification_to_merge_request_diff_registry.rb'
@@ -83,8 +62,6 @@ Lint/RedundantCopDisableDirective:
     - 'ee/spec/lib/gitlab/usage/metrics/instrumentations/count_security_scans_metric_spec.rb'
     - 'ee/spec/support/shared_examples/features/dashboard_saml_reauth_banner_shared_examples.rb'
     - 'ee/spec/views/admin/users/show.html.haml_spec.rb'
-    - 'lib/api/ci/variables.rb'
-    - 'lib/api/commit_statuses.rb'
     - 'lib/api/submodules.rb'
     - 'lib/gitlab/auth/current_user_mode.rb'
     - 'lib/gitlab/background_migration/backfill_desired_sharding_key_partition_job.rb'
@@ -125,16 +102,6 @@ Lint/RedundantCopDisableDirective:
     - 'lib/gitlab/background_migration/update_jira_tracker_data_deployment_type_based_on_url.rb'
     - 'lib/gitlab/background_migration/update_workspaces_config_version.rb'
     - 'lib/gitlab/background_migration/update_workspaces_config_version3.rb'
-    - 'lib/gitlab/ci/ansi2json/parser.rb'
-    - 'lib/gitlab/ci/build/artifacts/metadata/entry.rb'
-    - 'lib/gitlab/ci/config/external/mapper/verifier.rb'
-    - 'lib/gitlab/ci/pipeline/chain/command.rb'
-    - 'lib/gitlab/ci/pipeline/duration.rb'
-    - 'lib/gitlab/ci/reports/accessibility_reports.rb'
-    - 'lib/gitlab/ci/reports/test_report.rb'
-    - 'lib/gitlab/ci/reports/test_reports_comparer.rb'
-    - 'lib/gitlab/ci/reports/test_suite.rb'
-    - 'lib/gitlab/ci/reports/test_suite_summary.rb'
     - 'lib/gitlab/cleanup/personal_access_tokens.rb'
     - 'lib/gitlab/database/consistency_checker.rb'
     - 'lib/gitlab/database/gitlab_schema.rb'
@@ -146,7 +113,6 @@ Lint/RedundantCopDisableDirective:
     - 'lib/gitlab/database/migrations/squasher.rb'
     - 'lib/gitlab/lfs_token.rb'
     - 'lib/gitlab/popen/runner.rb'
-    - 'lib/gitlab/seeders/ci/runner/runner_fleet_seeder.rb'
     - 'qa/qa/resource/user_runners.rb'
     - 'qa/qa/service/docker_run/gitlab_runner.rb'
     - 'qa/qa/vendor/one_password/cli.rb'
@@ -163,12 +129,6 @@ Lint/RedundantCopDisableDirective:
     - 'spec/lib/gitlab/background_migration/drop_vulnerabilities_without_finding_id_spec.rb'
     - 'spec/lib/gitlab/background_migration/populate_vulnerability_dismissal_fields_spec.rb'
     - 'spec/lib/gitlab/background_migration/resolve_vulnerabilities_for_removed_analyzers_spec.rb'
-    - 'spec/lib/gitlab/ci/parsers/security/validators/schema_validator_spec.rb'
-    - 'spec/lib/gitlab/database/health_status/indicators/patroni_apdex_spec.rb'
-    - 'spec/lib/gitlab/database/health_status/indicators/prometheus_alert_indicator_spec.rb'
-    - 'spec/lib/gitlab/database/health_status/indicators/wal_rate_spec.rb'
-    - 'spec/lib/gitlab/database/load_balancing/transaction_leaking_spec.rb'
-    - 'spec/lib/gitlab/database/migration_helpers/restrict_gitlab_schema_spec.rb'
     - 'spec/lib/gitlab/doorkeeper_secret_storing/secret/pbkdf2_sha512_spec.rb'
     - 'spec/lib/gitlab/doorkeeper_secret_storing/token/pbkdf2_sha512_spec.rb'
     - 'spec/lib/gitlab/merge_requests/message_generator_spec.rb'

.rubocop_todo/rspec/receive_messages.yml

@@ -230,7 +230,6 @@ RSpec/ReceiveMessages:
     - 'ee/spec/views/trial_registrations/new.html.haml_spec.rb'
     - 'ee/spec/workers/active_user_count_threshold_worker_spec.rb'
     - 'ee/spec/workers/anti_abuse/new_abuse_report_worker_spec.rb'
-    - 'ee/spec/workers/elastic/migration_worker_spec.rb'
     - 'qa/spec/page/logging_spec.rb'
     - 'qa/spec/resource/base_spec.rb'
     - 'qa/spec/resource/events/project_spec.rb'

app/finders/autocomplete/move_to_project_finder.rb

@@ -29,7 +29,7 @@ def execute
         .excluding_project(project_id)
         .eager_load_namespace_and_owner
         .sorted_by_stars_desc
-        .limit(LIMIT) # rubocop: disable CodeReuse/ActiveRecord
+        .limit(LIMIT)
     end
   end
 end

app/finders/autocomplete/routes_finder.rb

@@ -20,7 +20,7 @@ def execute
         .sort_by_path_length
         .fuzzy_search(@search, [:path])
         .allow_cross_joins_across_databases(url: 'https://gitlab.com/gitlab-org/gitlab/-/issues/421843')
-        .limit(LIMIT) # rubocop: disable CodeReuse/ActiveRecord
+        .limit(LIMIT)
     end
 
     private

app/finders/autocomplete/users_finder.rb

@@ -101,11 +101,9 @@ def filter_users_by_push_ability(items)
       items.select { |user| user.can?(:push_code, project) }
     end
 
-    # rubocop: disable CodeReuse/ActiveRecord
     def preload_associations(items)
       ActiveRecord::Associations::Preloader.new(records: items, associations: :status).call
     end
-    # rubocop: enable CodeReuse/ActiveRecord
 
     def use_minimum_char_limit
       return if project.blank? && group.blank? # We return nil so that we use the default defined in the User model

app/finders/ci/daily_build_group_report_results_finder.rb

@@ -69,11 +69,9 @@ def sort(items)
       params[:sort].present? ? items.ordered_by_date_and_group_name : items
     end
 
-    # rubocop: disable CodeReuse/ActiveRecord
     def limit_by(items)
       items.limit(limit)
     end
-    # rubocop: enable CodeReuse/ActiveRecord
 
     def limit
       return MAX_ITEMS unless params[:limit].present?

app/finders/ci/runner_jobs_finder.rb

@@ -27,13 +27,11 @@ def execute
 
     private
 
-    # rubocop: disable CodeReuse/ActiveRecord
     def by_permission(items)
       return items if @user.can_read_all_resources?
 
       items.for_project(@user.authorized_project_mirrors(Gitlab::Access::REPORTER).select(:project_id))
     end
-    # rubocop: enable CodeReuse/ActiveRecord
 
     # rubocop: disable CodeReuse/ActiveRecord
     def by_status(items)

app/finders/users_finder.rb

@@ -180,13 +180,11 @@ def by_without_project_bots(users)
     users.without_project_bot
   end
 
-  # rubocop: disable CodeReuse/ActiveRecord
   def order(users)
     return users unless params[:sort]
 
     users.order_by(params[:sort])
   end
-  # rubocop: enable CodeReuse/ActiveRecord
 
   def user_can_read_group?(group)
     Ability.allowed?(current_user, :read_group, group)

app/graphql/resolvers/ci/pipeline_job_artifacts_resolver.rb

@@ -15,7 +15,7 @@ def resolve
 
       def find_job_artifacts
         BatchLoader::GraphQL.for(pipeline).batch do |pipelines, loader|
-          ActiveRecord::Associations::Preloader.new(records: pipelines, associations: :job_artifacts).call # rubocop: disable CodeReuse/ActiveRecord
+          ActiveRecord::Associations::Preloader.new(records: pipelines, associations: :job_artifacts).call
 
           pipelines.each { |pl| loader.call(pl, pl.job_artifacts) }
         end

app/graphql/types/ci/runner_web_url_edge.rb

@@ -2,7 +2,6 @@
 
 module Types
   module Ci
-    # rubocop: disable Graphql/AuthorizeTypes
     class RunnerWebUrlEdge < ::Types::BaseEdge
       field :edit_url, GraphQL::Types::String, null: true,
         description: 'Web URL of the runner edit page. The value depends on where you put the field in the query. You can use it for projects or groups.',

app/graphql/types/ml/model_version_type.rb

@@ -22,6 +22,8 @@ class ModelVersionType < ::Types::BaseObject
         null: true,
         description: 'Description of the version.'
 
+      field :artifacts_count, GraphQL::Types::Int, null: true, description: 'Number of files in the package.'
+
       field :version, ::GraphQL::Types::String, null: false, description: 'Name of the version.'
 
       field :package_id, ::Types::GlobalIDType[::Packages::Package],

app/presenters/ci/build_runner_presenter.rb

@@ -57,13 +57,11 @@ def refspecs
       specs
     end
 
-    # rubocop: disable CodeReuse/ActiveRecord
     def all_dependencies
       dependencies = super
       ActiveRecord::Associations::Preloader.new(records: dependencies, associations: :job_artifacts_archive).call
       dependencies
     end
-    # rubocop: enable CodeReuse/ActiveRecord
 
     def project_jobs_running_on_instance_runners_count
       # if not instance runner we don't care about that value and present `+Inf` as a placeholder for Prometheus

app/presenters/ml/model_version_presenter.rb

@@ -37,5 +37,9 @@ def import_path
 
       path.delete_suffix('(/path/)')
     end
+
+    def artifacts_count
+      model_version.package.package_files.length
+    end
   end
 end

app/services/ci/register_job_service.rb

@@ -43,7 +43,7 @@ def execute(params = {})
       if !replica_caught_up && !result.build
         metrics.increment_queue_operation(:queue_replication_lag)
 
-        ::Ci::RegisterJobService::Result.new(nil, nil, nil, false) # rubocop:disable Cop/AvoidReturnFromBlocks
+        ::Ci::RegisterJobService::Result.new(nil, nil, nil, false)
       else
         result
       end

app/services/ci/retry_job_service.rb

@@ -18,7 +18,6 @@ def execute(job, variables: [])
       end
     end
 
-    # rubocop: disable CodeReuse/ActiveRecord
     def clone!(job, variables: [], enqueue_if_actionable: false, start_pipeline: false)
       # Cloning a job requires a strict type check to ensure
       # the attributes being used for the clone are taken straight
@@ -65,7 +64,6 @@ def clone!(job, variables: [], enqueue_if_actionable: false, start_pipeline: fal
 
       new_job
     end
-    # rubocop: enable CodeReuse/ActiveRecord
 
     private
 

app/workers/ci/track_failed_build_worker.rb

@@ -2,7 +2,7 @@
 
 # Worker for tracking exit codes of failed CI jobs
 module Ci
-  class TrackFailedBuildWorker # rubocop:disable Scalability/IdempotentWorker
+  class TrackFailedBuildWorker
     include ApplicationWorker
     include PipelineBackgroundQueue
 

app/workers/run_pipeline_schedule_worker.rb

 # frozen_string_literal: true
 
-class RunPipelineScheduleWorker # rubocop:disable Scalability/IdempotentWorker
+class RunPipelineScheduleWorker
   include ApplicationWorker
 
   data_consistency :always

doc/api/graphql/reference/index.md

@@ -28774,6 +28774,7 @@ Version of a machine learning model.
 | Name | Type | Description |
 | ---- | ---- | ----------- |
 | <a id="mlmodelversion_links"></a>`_links` | [`MLModelVersionLinks!`](#mlmodelversionlinks) | Map of links to perform actions on the model version. |
+| <a id="mlmodelversionartifactscount"></a>`artifactsCount` | [`Int`](#int) | Number of files in the package. |
 | <a id="mlmodelversionauthor"></a>`author` | [`UserCore!`](#usercore) | User that created the model version. |
 | <a id="mlmodelversioncandidate"></a>`candidate` | [`MlCandidate!`](#mlcandidate) | Metrics, params and metadata for the model version. |
 | <a id="mlmodelversioncreatedat"></a>`createdAt` | [`Time!`](#time) | Date of creation. |

ee/app/finders/epics/with_issues_finder.rb

@@ -25,11 +25,9 @@ def execute
 
     attr_reader :accessible_epics, :accessible_issues
 
-    # rubocop: disable CodeReuse/ActiveRecord
     def epics_cte
       @epics_cte ||= Gitlab::SQL::CTE.new(:sorted_epics, accessible_epics)
     end
-    # rubocop: enable CodeReuse/ActiveRecord
 
     # rubocop: disable CodeReuse/ActiveRecord
     def issues_joined_with_epics