.gitlab-ci.yml

@@ -254,10 +254,6 @@ variables:
   BUILD_ASSETS_IMAGE: "true"  # Set it to "false" to disable assets image building, used in `build-assets-image`
   SIMPLECOV: "true"
 
-  # Temporary variable to enable new CSS compiler
-  # See: https://gitlab.com/gitlab-org/gitlab/-/issues/438278
-  USE_NEW_CSS_PIPELINE: "true"
-
 include:
   - local: .gitlab/ci/_skip.yml
     rules:

.gitlab/ci/database.gitlab-ci.yml

@@ -53,7 +53,7 @@ db:migrate:multi-version-upgrade:
     - gunzip -c latest_upgrade_stop.gz > gitlabhq_production
     - bundle exec rake db:drop db:create
     - apt-get update -qq && apt-get install -y -qq postgresql
-    - psql -h postgres -U postgres -d gitlabhq_test < gitlabhq_production
+    - psql --output /dev/null -v "ON_ERROR_STOP=1" -h postgres -U postgres -d gitlabhq_test < gitlabhq_production
     - bundle exec rake gitlab:db:configure
   allow_failure: true
 

.gitlab/ci/rules.gitlab-ci.yml

@@ -47,9 +47,6 @@
 .if-merge-request-approved: &if-merge-request-approved
   if: '($CI_MERGE_REQUEST_EVENT_TYPE == "merged_result" || $CI_MERGE_REQUEST_EVENT_TYPE == "detached") && $CI_MERGE_REQUEST_LABELS =~ /pipeline:mr-approved/'
 
-.if-merge-request-approved-and-specific-devops-stage: &if-merge-request-approved-and-specific-devops-stage
-  if: '($CI_MERGE_REQUEST_EVENT_TYPE == "merged_result" || $CI_MERGE_REQUEST_EVENT_TYPE == "detached") && ($CI_MERGE_REQUEST_LABELS =~ /pipeline:mr-approved/ && $CI_MERGE_REQUEST_LABELS =~ /devops::(create|govern|manage|plan|verify|package|monitor|data stores|fulfillment|systems)/)'
-
 .if-merge-request-and-specific-devops-stage: &if-merge-request-and-specific-devops-stage
   if: '($CI_MERGE_REQUEST_EVENT_TYPE == "merged_result" || $CI_MERGE_REQUEST_EVENT_TYPE == "detached") && $CI_MERGE_REQUEST_LABELS =~ /devops::(create|govern|manage|plan|verify|package|monitor|data stores|fulfillment|systems)/'
 
@@ -1473,17 +1470,23 @@
     - <<: *if-foss-schedule
     - <<: *if-merge-request-labels-update-caches
 
-.qa:rules:code-merge-request-manual:
+.qa:rules:code-merge-request:
+  rules:
+    - <<: *if-merge-request
+      changes: *code-patterns
+
+.qa:rules:code-merge-request-allowed-to-fail:
   rules:
     - <<: *if-merge-request
       changes: *code-patterns
-      when: manual
       allow_failure: true
 
-.qa:rules:code-merge-request:
+.qa:rules:code-merge-request-manual:
   rules:
     - <<: *if-merge-request
       changes: *code-patterns
+      when: manual
+      allow_failure: true
 
 .qa:rules:internal:
   rules:
@@ -1541,6 +1544,8 @@
     - <<: *if-merge-request-targeting-stable-branch
       changes: *setup-test-env-patterns
     - <<: *if-ruby-branch
+    - <<: *if-merge-request
+      changes: *qa-patterns
     - <<: *if-merge-request
       changes: *dependency-patterns
       variables:
@@ -1554,16 +1559,14 @@
       changes: *nodejs-patterns
     - <<: *if-merge-request
       changes: *ci-qa-patterns
-    - <<: *if-merge-request
-      changes: *qa-patterns
     - <<: *if-dot-com-gitlab-org-and-security-merge-request-and-qa-tests-specified
       changes: *code-patterns
     - <<: *if-force-ci
+    - <<: *if-merge-request-and-specific-devops-stage
+      changes: *code-patterns
     # From .qa:rules:package-and-test-schedule
     - <<: *if-dot-com-gitlab-org-schedule
-    # From .qa:rules:code-merge-request-manual
-    - <<: *if-merge-request
-      changes: *code-patterns
+    - !reference [".qa:rules:code-merge-request", rules]
 
 .qa:rules:package-and-test-never-run:
   rules:
@@ -1582,6 +1585,13 @@
       allow_failure: true
     - <<: *if-ruby-branch
       allow_failure: true
+    # Run tests automatically for MRs that touch QA files
+    - <<: *if-merge-request
+      changes: *qa-patterns
+      allow_failure: true
+    # Otherwise, only run tests after the MR is approved
+    - <<: *if-merge-request-not-approved
+      when: never
     - <<: *if-merge-request
       changes: *dependency-patterns
       variables:
@@ -1600,16 +1610,13 @@
     - <<: *if-merge-request
       changes: *ci-qa-patterns
       allow_failure: true
-    - <<: *if-merge-request
-      changes: *qa-patterns
-      allow_failure: true
     - <<: *if-dot-com-gitlab-org-and-security-merge-request-and-qa-tests-specified
       changes: *code-patterns
       allow_failure: true
     - <<: *if-force-ci
       when: manual
       allow_failure: true
-    - <<: *if-merge-request-approved-and-specific-devops-stage
+    - <<: *if-merge-request-and-specific-devops-stage
       changes: *code-patterns
       allow_failure: true
       # We used to have a rule at the end here that would catch any remaining code MRs and allow the job to be run
@@ -1744,7 +1751,7 @@
 
 # These are based on `.qa:rules:trigger-omnibus` except:
 # 1. Automatic jobs changed to `when: never.`
-# 2. For specific devops stage, do not run for code-patterns
+# 2. Do not run for specific devops stage
 # If any changes are made to this rule, `.qa:rules:follow-up-e2e` should also be updated.
 .qa:rules:manual-omnibus-and-follow-up-e2e:
   rules:
@@ -1759,9 +1766,7 @@
     - !reference [".qa:rules:package-and-test-never-run", rules]
     - <<: *if-merge-request-and-specific-devops-stage
       when: never
-    - <<: *if-merge-request
-      changes: *code-patterns
-      allow_failure: true
+    - !reference [".qa:rules:code-merge-request-allowed-to-fail", rules]
 
 # These are based on `qa:rules:package-and-test-ee` but with when:never in all except for code-patterns in merge requests
 .qa:rules:post-run-e2e-message:
@@ -1806,10 +1811,7 @@
     # Do not run on unapproved MR
     - <<: *if-merge-request-not-approved
       when: never
-    # From .qa:rules:code-merge-request-manual
-    - <<: *if-merge-request
-      changes: *code-patterns
-      allow_failure: true
+    - !reference [".qa:rules:code-merge-request-allowed-to-fail", rules]
 
 .qa:rules:fulfillment-e2e-quarantine-report:
   rules:
@@ -2743,6 +2745,15 @@
   rules:
     - if: '$CI_FETCH_REPO_GIT_STRATEGY == "none"'
 
+.setup:rules:check-default-pipeline-status:
+  rules:
+    - <<: *if-merge-request-labels-pipeline-expedite
+      when: never
+    - if: '$CI_MERGE_REQUEST_LABELS =~ /pipeline:ignore-master-status/'
+      when: never
+    - <<: *if-default-refs
+      allow_failure: true
+
 .setup:rules:gitlab_git_test:
   rules:
     - <<: *if-merge-request-labels-pipeline-expedite

.gitlab/ci/setup.gitlab-ci.yml

@@ -57,6 +57,18 @@ clone-gitlab-repo:
       - '*'
     expire_in: '12 hours'
 
+master-pipeline-status:
+  extends:
+    - .default-retry
+    - .setup:rules:check-default-pipeline-status
+  stage: sync
+  image: ${GITLAB_DEPENDENCY_PROXY_ADDRESS}ruby:${RUBY_VERSION}-slim
+  before_script:
+    - source ./scripts/utils.sh
+    - install_gitlab_gem
+  script:
+    - scripts/check_default_pipeline_status.rb
+
 gitlab_git_test:
   extends:
     - .predictive-job

.rubocop.yml

@@ -497,6 +497,24 @@ BackgroundMigration/DictionaryFile:
   Include:
     - 'db/post_migrate/*.rb'
 
+# See https://gitlab.com/gitlab-org/gitlab/-/issues/442751
+Gitlab/AvoidCurrentOrganization:
+  Enabled: true
+  Exclude:
+    - 'app/controllers/**/*'
+    - 'ee/app/controllers/**/*'
+    - 'app/helpers/**/*'
+    - 'ee/app/helpers/**/*'
+    - 'app/views/**/*'
+    - 'ee/app/views/**/*'
+    - 'lib/api/**/*'
+    - 'ee/lib/api/**/*'
+    - 'app/graphql/**/*'
+    - 'ee/app/graphql/**/*'
+    - 'lib/gitlab/middleware/organizations/current.rb'
+    - 'spec/**/*'
+    - 'ee/spec/**/*'
+
 # See https://gitlab.com/groups/gitlab-org/-/epics/7374
 Gitlab/AvoidGitlabInstanceChecks:
   Enabled: true

.rubocop_todo/gitlab/avoid_current_organization.yml

+---
+Gitlab/AvoidCurrentOrganization:
+  Details: grace period
+  Exclude:
+    - 'app/models/organizations/organization_setting.rb'
+    - 'app/services/groups/create_service.rb'

.rubocop_todo/layout/argument_alignment.yml

@@ -941,22 +941,6 @@ Layout/ArgumentAlignment:
     - 'ee/spec/requests/api/projects_spec.rb'
     - 'ee/spec/requests/api/protected_environments_spec.rb'
     - 'ee/spec/requests/api/provider_identity_spec.rb'
-    - 'ee/spec/requests/api/releases_spec.rb'
-    - 'ee/spec/requests/api/search_spec.rb'
-    - 'ee/spec/requests/api/settings_spec.rb'
-    - 'ee/spec/requests/api/status_checks_spec.rb'
-    - 'ee/spec/requests/api/visual_review_discussions_spec.rb'
-    - 'ee/spec/requests/api/vulnerability_findings_spec.rb'
-    - 'ee/spec/requests/ee/confirmations_controller_spec.rb'
-    - 'ee/spec/requests/ee/projects/environments_controller_spec.rb'
-    - 'ee/spec/requests/ee/projects/service_desk_controller_spec.rb'
-    - 'ee/spec/requests/groups/epics/epic_links_controller_spec.rb'
-    - 'ee/spec/requests/groups/epics/related_epic_links_controller_spec.rb'
-    - 'ee/spec/requests/groups/protected_environments_controller_spec.rb'
-    - 'ee/spec/requests/groups/settings/domain_verification_controller_spec.rb'
-    - 'ee/spec/requests/groups/two_factor_auths_controller_spec.rb'
-    - 'ee/spec/requests/smartcard_controller_spec.rb'
-    - 'ee/spec/requests/users/identity_verification_controller_spec.rb'
     - 'ee/spec/services/gitlab_subscriptions/reconciliations/check_seat_usage_alerts_eligibility_service_spec.rb'
     - 'ee/spec/services/groups/compliance_report_csv_service_spec.rb'
     - 'ee/spec/services/groups/mark_for_deletion_service_spec.rb'

.rubocop_todo/layout/line_length.yml

@@ -2170,7 +2170,6 @@ Layout/LineLength:
     - 'ee/spec/support/helpers/vulnerability_helpers.rb'
     - 'ee/spec/support/license_scanning_reports/license_scanning_report_helper.rb'
     - 'ee/spec/support/matchers/ee/epic_aggregate_matchers.rb'
-    - 'ee/spec/support/matchers/locked_schema.rb'
     - 'ee/spec/support/protected_tags/access_control_shared_examples.rb'
     - 'ee/spec/support/shared_contexts/lib/gitlab/insights/reducers/reducers_shared_contexts.rb'
     - 'ee/spec/support/shared_contexts/push_rules_checks_shared_context.rb'
@@ -3374,7 +3373,6 @@ Layout/LineLength:
     - 'spec/initializers/mail_encoding_patch_spec.rb'
     - 'spec/initializers/pages_storage_check_spec.rb'
     - 'spec/initializers/secret_token_spec.rb'
-    - 'spec/initializers/session_store_spec.rb'
     - 'spec/initializers/settings_spec.rb'
     - 'spec/lib/api/entities/ci/pipeline_spec.rb'
     - 'spec/lib/api/entities/project_import_status_spec.rb'

.rubocop_todo/lint/constant_definition_in_block.yml

@@ -26,7 +26,6 @@ Lint/ConstantDefinitionInBlock:
     - 'ee/lib/gitlab/subscription_portal/clients/rest.rb'
     - 'ee/lib/tasks/geo.rake'
     - 'ee/spec/db/schema_support.rb'
-    - 'ee/spec/support/matchers/locked_schema.rb'
     - 'lib/api/search.rb'
     - 'lib/gitlab/quick_actions/issue_actions.rb'
     - 'lib/tasks/cache.rake'

.rubocop_todo/rspec/factory_bot/avoid_create.yml

@@ -584,6 +584,7 @@ RSpec/FactoryBot/AvoidCreate:
     - 'spec/views/profiles/show.html.haml_spec.rb'
     - 'spec/views/projects/_flash_messages.html.haml_spec.rb'
     - 'spec/views/projects/_home_panel.html.haml_spec.rb'
+    - 'spec/views/projects/_issue.html.haml_spec.rb'
     - 'spec/views/projects/branches/index.html.haml_spec.rb'
     - 'spec/views/projects/commit/_commit_box.html.haml_spec.rb'
     - 'spec/views/projects/commit/branches.html.haml_spec.rb'
@@ -597,7 +598,6 @@ RSpec/FactoryBot/AvoidCreate:
     - 'spec/views/projects/hooks/edit.html.haml_spec.rb'
     - 'spec/views/projects/hooks/index.html.haml_spec.rb'
     - 'spec/views/projects/imports/new.html.haml_spec.rb'
-    - 'spec/views/projects/issues/service_desk/_issue.html.haml_spec.rb'
     - 'spec/views/projects/issues/show.html.haml_spec.rb'
     - 'spec/views/projects/jobs/_build.html.haml_spec.rb'
     - 'spec/views/projects/jobs/_generic_commit_status.html.haml_spec.rb'

.rubocop_todo/style/inline_disable_annotation.yml

@@ -2075,7 +2075,6 @@ Style/InlineDisableAnnotation:
     - 'ee/spec/services/security/token_revocation_service_spec.rb'
     - 'ee/spec/spec_helper.rb'
     - 'ee/spec/support/helpers/duo_chat_fixture_helpers.rb'
-    - 'ee/spec/support/matchers/locked_schema.rb'
     - 'ee/spec/support/shared_contexts/graphql/geo/registries_shared_context.rb'
     - 'ee/spec/support/shared_contexts/saas_registration_settings_context.rb'
     - 'ee/spec/support/shared_contexts/saas_trial_settings_context.rb'

GITLAB_SHELL_VERSION

-14.33.0
+14.34.0

Gemfile

@@ -341,8 +341,7 @@ gem 'gitlab_chronic_duration', '~> 0.12' # rubocop:todo Gemfile/MissingFeatureCa
 
 gem 'rack-proxy', '~> 0.7.7' # rubocop:todo Gemfile/MissingFeatureCategory
 
-gem 'sassc-rails', '~> 2.1.0', feature_category: :shared, require: false
-gem 'cssbundling-rails', '1.3.3', feature_category: :shared, require: false
+gem 'cssbundling-rails', '1.3.3', feature_category: :shared
 gem 'autoprefixer-rails', '10.2.5.1' # rubocop:todo Gemfile/MissingFeatureCategory
 gem 'terser', '1.0.2' # rubocop:todo Gemfile/MissingFeatureCategory
 

Gemfile.checksum

@@ -575,7 +575,7 @@
 {"name":"rubocop-rspec","version":"2.25.0","platform":"ruby","checksum":"083f8a0481dbb9969b2a9eae85670a454fe91d46812e6ec97b34e7f6227b99f3"},
 {"name":"ruby-fogbugz","version":"0.3.0","platform":"ruby","checksum":"5e04cde474648f498a71cf1e1a7ab42c66b953862fbe224f793ec0a7a1d5f657"},
 {"name":"ruby-lsp","version":"0.14.2","platform":"ruby","checksum":"d51b94c1cbd4158c84a2f99b8d397ae6051595a548c1c117d5224478a5743132"},
-{"name":"ruby-lsp-rails","version":"0.3.0","platform":"ruby","checksum":"5e4a548d9c47122b10cdfc797f3d9d6ec4051b12c8cc5e099f27a93a5fdba976"},
+{"name":"ruby-lsp-rails","version":"0.3.1","platform":"ruby","checksum":"81e0aff084c54933cc150d8f544752da9a64b714cb312c196196fb5b8aec730c"},
 {"name":"ruby-lsp-rspec","version":"0.1.10","platform":"ruby","checksum":"71b638b46b08bfda425477aff705bcc0f48d703983afd1fde50e7b43425afd5a"},
 {"name":"ruby-magic","version":"0.6.0","platform":"ruby","checksum":"7b2138877b7d23aff812c95564eba6473b74b815ef85beb0eb792e729a2b6101"},
 {"name":"ruby-openai","version":"3.7.0","platform":"ruby","checksum":"fb735d4c055e282ade264cab9864944c05a8a10e0cddd45a0551e8a9851b1850"},
@@ -591,9 +591,6 @@
 {"name":"safe_yaml","version":"1.0.4","platform":"ruby","checksum":"248193992ef1730a0c9ec579999ef2256a2b3a32a9bd9d708a1e12544a489ec2"},
 {"name":"safety_net_attestation","version":"0.4.0","platform":"ruby","checksum":"96be2d74e7ed26453a51894913449bea0e072f44490021545ac2d1c38b0718ce"},
 {"name":"sanitize","version":"6.0.2","platform":"ruby","checksum":"48c4eb8e92bb1699056b6000986ac50fc9df82f458a941abf2c4d6759bccd5cf"},
-{"name":"sassc","version":"2.4.0","platform":"ruby","checksum":"4c60a2b0a3b36685c83b80d5789401c2f678c1652e3288315a1551d811d9f83e"},
-{"name":"sassc","version":"2.4.0","platform":"x64-mingw32","checksum":"8773b917cb52c7e92c94d4bf324c1c0be3e50d9092f9f5ed4c3c6e454b451c5e"},
-{"name":"sassc-rails","version":"2.1.2","platform":"ruby","checksum":"5f4fdf3881fc9bdc8e856ffbd9850d70a2878866feae8114aa45996179952db5"},
 {"name":"sawyer","version":"0.9.2","platform":"ruby","checksum":"fa3a72d62a4525517b18857ddb78926aab3424de0129be6772a8e2ba240e7aca"},
 {"name":"sd_notify","version":"0.1.1","platform":"ruby","checksum":"cbc7ac6caa7cedd26b30a72b5eeb6f36050dc0752df263452ea24fb5a4ad3131"},
 {"name":"seed-fu","version":"2.3.7","platform":"ruby","checksum":"f19673443e9af799b730e3d4eca6a89b39e5a36825015dffd00d02ea3365cf74"},

Gemfile.lock

@@ -1515,11 +1515,11 @@ GEM
       language_server-protocol (~> 3.17.0)
       prism (>= 0.22.0, < 0.25)
       sorbet-runtime (>= 0.5.10782)
-    ruby-lsp-rails (0.3.0)
+    ruby-lsp-rails (0.3.1)
       actionpack (>= 6.0)
       activerecord (>= 6.0)
       railties (>= 6.0)
-      ruby-lsp (>= 0.14.0, < 0.15.0)
+      ruby-lsp (>= 0.14.2, < 0.15.0)
       sorbet-runtime (>= 0.5.9897)
     ruby-lsp-rspec (0.1.10)
       ruby-lsp (~> 0.14.0)
@@ -1546,14 +1546,6 @@ GEM
     sanitize (6.0.2)
       crass (~> 1.0.2)
       nokogiri (>= 1.12.0)
-    sassc (2.4.0)
-      ffi (~> 1.9)
-    sassc-rails (2.1.2)
-      railties (>= 4.0.0)
-      sassc (>= 2.0)
-      sprockets (> 3.0)
-      sprockets-rails
-      tilt
     sawyer (0.9.2)
       addressable (>= 2.3.5)
       faraday (>= 0.17.3, < 3)
@@ -2103,7 +2095,6 @@ DEPENDENCIES
   rubyzip (~> 2.3.2)
   rugged (~> 1.6)
   sanitize (~> 6.0.2)
-  sassc-rails (~> 2.1.0)
   sd_notify (~> 0.1.0)
   seed-fu (~> 2.3.7)
   selenium-webdriver (~> 4.18, >= 4.18.1)

app/assets/javascripts/ci/catalog/components/details/ci_resource_about.vue

 <script>
 import { GlIcon, GlLink } from '@gitlab/ui';
 import { n__, s__, sprintf } from '~/locale';
-import { formatDate } from '~/lib/utils/datetime_utility';
+import { getTimeago } from '~/lib/utils/datetime_utility';
 
 export default {
   components: {
@@ -39,14 +39,10 @@ export default {
     },
   },
   computed: {
-    hasVersion() {
-      return this.latestVersion;
-    },
     lastReleaseText() {
-      if (this.hasVersion) {
-        return sprintf(this.$options.i18n.lastRelease, {
-          date: this.createdAt,
-        });
+      if (this.latestVersion?.createdAt) {
+        const timeAgo = getTimeago().format(this.latestVersion.createdAt);
+        return sprintf(this.$options.i18n.lastRelease, { timeAgo });
       }
 
       return this.$options.i18n.lastReleaseMissing;
@@ -57,9 +53,6 @@ export default {
     openMergeRequestText() {
       return n__('%d merge request', '%d merge requests', this.openMergeRequestsCount);
     },
-    createdAt() {
-      return this.hasVersion && formatDate(this.latestVersion.createdAt, 'yyyy-mm-dd');
-    },
     projectInfoItems() {
       return [
         {
@@ -90,7 +83,7 @@ export default {
   },
   i18n: {
     projectLink: s__('CiCatalog|Go to the project'),
-    lastRelease: s__('CiCatalog|Last release at %{date}'),
+    lastRelease: s__('CiCatalog|Released %{timeAgo}'),
     lastReleaseMissing: s__('CiCatalog|No release available'),
   },
 };

app/assets/javascripts/ci/pipeline_details/header/graphql/queries/get_pipeline_header_data.query.graphql

@@ -54,6 +54,9 @@ query getPipelineHeaderData($fullPath: ID!, $iid: ID!) {
       configSource
       failureReason
       source
+      yamlErrors
+      yamlErrorMessages
+      trigger
       ...PipelineHeaderData
     }
   }

app/assets/javascripts/ci/pipeline_details/header/pipeline_details_header.vue

@@ -14,7 +14,7 @@ import {
 import { BUTTON_TOOLTIP_RETRY, BUTTON_TOOLTIP_CANCEL } from '~/ci/constants';
 import { timeIntervalInWords } from '~/lib/utils/datetime_utility';
 import { setUrlFragment, redirectTo } from '~/lib/utils/url_utility'; // eslint-disable-line import/no-deprecated
-import { __, s__, sprintf, formatNumber } from '~/locale';
+import { __, n__, s__, sprintf, formatNumber } from '~/locale';
 import { getIdFromGraphQLId } from '~/graphql_shared/utils';
 import ClipboardButton from '~/vue_shared/components/clipboard_button.vue';
 import CiIcon from '~/vue_shared/components/ci_icon/ci_icon.vue';
@@ -134,17 +134,6 @@ export default {
       default: '',
     },
   },
-  props: {
-    yamlErrors: {
-      type: String,
-      required: false,
-      default: '',
-    },
-    trigger: {
-      type: Boolean,
-      required: true,
-    },
-  },
   apollo: {
     pipeline: {
       context() {
@@ -249,8 +238,10 @@ export default {
       return this.pipeline?.commit?.title || '';
     },
     totalJobsText() {
-      return sprintf(__('%{jobs} Jobs'), {
-        jobs: this.pipeline?.totalJobs || 0,
+      const totalJobs = this.pipeline?.totalJobs || 0;
+
+      return sprintf(n__('%{jobs} job', '%{jobs} jobs', totalJobs), {
+        jobs: totalJobs,
       });
     },
     triggeredText() {
@@ -327,17 +318,14 @@ export default {
     isScheduledPipeline() {
       return this.pipeline.source === SCHEDULE_SOURCE;
     },
-    isInvalidPipeline() {
-      return Boolean(this.yamlErrors);
-    },
     failureReason() {
       return this.pipeline.failureReason;
     },
     badges() {
       return {
         schedule: this.isScheduledPipeline,
-        trigger: this.trigger,
-        invalid: this.isInvalidPipeline,
+        trigger: this.pipeline.trigger,
+        invalid: this.pipeline.yamlErrors,
         child: this.pipeline.child,
         latest: this.pipeline.latest,
         mergeTrainPipeline: this.isMergeTrainPipeline,
@@ -348,6 +336,9 @@ export default {
         stuck: this.pipeline.stuck,
       };
     },
+    yamlErrorMessages() {
+      return this.pipeline?.yamlErrorMessages || '';
+    },
   },
   methods: {
     reportFailure(errorType, errorMessages = []) {
@@ -543,7 +534,7 @@ export default {
             <gl-badge
               v-if="badges.invalid"
               v-gl-tooltip
-              :title="yamlErrors"
+              :title="yamlErrorMessages"
               variant="danger"
               size="sm"
             >

app/assets/javascripts/ci/pipeline_details/pipeline_details_header.js

 import Vue from 'vue';
 import VueApollo from 'vue-apollo';
-import { parseBoolean } from '~/lib/utils/common_utils';
 import PipelineDetailsHeader from './header/pipeline_details_header.vue';
 
 Vue.use(VueApollo);
@@ -12,7 +11,7 @@ export const createPipelineDetailsHeaderApp = (elSelector, apolloProvider, graph
     return;
   }
 
-  const { fullPath, pipelineIid, pipelinesPath, yamlErrors, trigger } = el.dataset;
+  const { fullPath, pipelineIid, pipelinesPath } = el.dataset;
 
   // eslint-disable-next-line no-new
   new Vue({
@@ -28,12 +27,7 @@ export const createPipelineDetailsHeaderApp = (elSelector, apolloProvider, graph
       pipelineIid,
     },
     render(createElement) {
-      return createElement(PipelineDetailsHeader, {
-        props: {
-          yamlErrors,
-          trigger: parseBoolean(trigger),
-        },
-      });
+      return createElement(PipelineDetailsHeader);
     },
   });
 };

app/assets/javascripts/ci/runner/admin_register_runner/admin_register_runner_app.vue

@@ -62,8 +62,6 @@ export default {
       @close="onToggleDrawer(false)"
     />
 
-    <gl-button :href="runnersPath" variant="confirm">{{
-      s__('Runners|Go to runners page')
-    }}</gl-button>
+    <gl-button :href="runnersPath" variant="confirm">{{ s__('Runners|View runners') }}</gl-button>
   </div>
 </template>