.gitlab/issue_templates/Pipeline Security issue implementation

+<!--
+## Implementation Issue To-Do list 
+(_NOTE: This section can be removed when the issue is ready for creation_)
+- [ ] Ensure that the issue title is concise yet descriptive.
+- [ ] Add `Frontend :` or `Backend :` to the title per group [naming conventions](https://about.gitlab.com/handbook/engineering/development/ops/verify/pipeline-security/#splitting-issues)
+- [ ] Ensure the issue containing the feature or change proposal and related discussions is linked as related to this implementation issue.
+- [ ] Aside from default labeling, please make sure to include relevant labels for `~type::`, `~workflow::`, and `~frontend` or `~backend`.
+- [ ] Issues with user-facing changes should include the `~UX` label, and `~documentation` if docs changes will be required.
+
+*This template is meant to be a reference tool. Not all sections are applicable to each feature, bug, or maintenance item. Use your best judgment when completion the sections below.*
+-->
+
+## Summary
+<!-- Briefly describe the issue. -->
+
+
+### Why this matters and how we measure
+<!-- What is the value to the customer or our business? Does this align with our OKRs? If we need to create or update existing instrumentation, please note here. -->
+
+### User Stories
+<!--
+A user story is a requirement for any functionality or feature and follows this format:
+
+- _As a `<user role/customer>`, I want to `<JTBD>` so that I can `<achieve a benefit or result>`._
+
+Please try to include one user story for the main [persona](https://about.gitlab.com/handbook/product/personas/#list-of-user-personas) who needs this feature.
+-->
+
+
+## Proposal
+<!-- Try to keep the proposal limited in scope. Plan for iterations, create follow up issues as required and add them as related. -->
+
+## Performance Considerations
+<!-- Performance concerns to be aware of and monitor when implementing the issue.-->
+
+## Out of Scope
+<!-- Include this section for specific use cases that are out of scope / out of bounds for this specific issue. -->
+
+## Acceptance Criteria 
+<!-- This needs to be true or demonstrable to consider this specific issue complete. Keep this dependent on other issues when possible -->
+
+## Additional details
+<!--
+_NOTE: If the issue has addressed all of these questions, this separate section can be removed._
+-->
+
+Some relevant technical details, if applicable, such as:
+
+- Does this need a ~"feature flag"?
+- Does there need to be an associated ~"instrumentation" issue created related to this work?
+- Is there an example response showing the data structure that should be returned (new endpoints only)?
+- What permissions should be used?
+- Which tier(s) is this for?
+  - [ ] ~"GitLab Ultimate"
+  - [ ] ~"GitLab Premium"
+  - [ ] ~"GitLab Free"
+- Additional comments:
+
+## Implementation Table
+
+<!--
+_NOTE: Use this to indicate all dependent issues related to this one which are required for launch._
+-->
+
+
+| Group | Issue Link |
+| ------ | ------ |
+| ~backend | :point_left: You are here |
+| ~frontend | [Issue Title](url) |
+| ~documentation | [Issue Title](url) |
+| Instrumentation | [Issue Title](url) |
+
+<!--
+## Documentation 
+
+_NOTE: This section is optional, but can be used for easy access to any relevant documentation URLs._
+-->
+
+## Links/References
+
+
+
+
+/label ~"group::pipeline security" 
+/milestone %Backlog
+
+<!-- select the correct category (and feature label if applicable) below: 
+/label ~"category:Build Artifacts"
+/label ~"category:Secrets Management"
+/label ~"ci variables"
+/label ~"ci job token"
+-->
+
+<!-- select the appropriate licence below (Use the highest tier applicable): 
+/label ~"GitLab Ultimate"
+/label ~"GitLab Premium"
+/label ~"GitLab Free"
+-->

.gitlab/merge_request_templates/Deprecations.md

@@ -71,8 +71,6 @@ yourself as a reviewer if it's not ready for merge yet.
 - [ ] Title:
   - Length limit: 7 words (not including articles or prepositions).
   - Capitalization: ensure the title is [sentence cased](https://design.gitlab.com/content/punctuation#case).
-- [ ] Dates:
-  - Make sure that the milestone dates are based on the dates in [Product milestone creation](https://about.gitlab.com/handbook/product/milestones/#product-milestone-creation).
 - [ ] Consistency:
   - Ensure that all resources (docs, deprecation, etc.) refer to the feature with the same term / feature name.
 - [ ] Content:

.gitlab/merge_request_templates/Removals.md

@@ -78,8 +78,6 @@ yourself as a reviewer if it's not yet ready for merge.
 - [ ] Title:
   - Length limit: 7 words (not including articles or prepositions).
   - Capitalization: ensure the title is [sentence cased](https://design.gitlab.com/content/punctuation#case).
-- [ ] Dates:
-  - Make sure that the milestone dates are based on the dates in [Product milestone creation](https://about.gitlab.com/handbook/product/milestones/#product-milestone-creation).
 - [ ] Consistency:
   - Ensure that all resources (docs, removal, etc.) refer to the feature with the same term / feature name.
 - [ ] Content:

.rubocop_todo/gitlab/strong_memoize_attr.yml

@@ -71,7 +71,6 @@ Gitlab/StrongMemoizeAttr:
     - 'app/models/alert_management/alert.rb'
     - 'app/models/application_setting_implementation.rb'
     - 'app/models/blob_viewer/go_mod.rb'
-    - 'app/models/blob_viewer/metrics_dashboard_yml.rb'
     - 'app/models/bulk_imports/export.rb'
     - 'app/models/bulk_imports/export_status.rb'
     - 'app/models/bulk_imports/file_transfer/base_config.rb'
@@ -218,28 +217,6 @@ Gitlab/StrongMemoizeAttr:
     - 'app/services/metrics/dashboard/dynamic_embed_service.rb'
     - 'app/services/metrics/dashboard/gitlab_alert_embed_service.rb'
     - 'app/services/namespaces/package_settings/update_service.rb'
-    - 'app/services/packages/cleanup/execute_policy_service.rb'
-    - 'app/services/packages/cleanup/update_policy_service.rb'
-    - 'app/services/packages/composer/create_package_service.rb'
-    - 'app/services/packages/debian/extract_changes_metadata_service.rb'
-    - 'app/services/packages/debian/generate_distribution_key_service.rb'
-    - 'app/services/packages/debian/generate_distribution_service.rb'
-    - 'app/services/packages/debian/process_changes_service.rb'
-    - 'app/services/packages/helm/process_file_service.rb'
-    - 'app/services/packages/maven/metadata/base_create_xml_service.rb'
-    - 'app/services/packages/maven/metadata/create_plugins_xml_service.rb'
-    - 'app/services/packages/maven/metadata/create_versions_xml_service.rb'
-    - 'app/services/packages/maven/metadata/sync_service.rb'
-    - 'app/services/packages/npm/create_package_service.rb'
-    - 'app/services/packages/npm/create_tag_service.rb'
-    - 'app/services/packages/nuget/metadata_extraction_service.rb'
-    - 'app/services/packages/nuget/search_service.rb'
-    - 'app/services/packages/pypi/create_package_service.rb'
-    - 'app/services/packages/rpm/parse_package_service.rb'
-    - 'app/services/packages/rubygems/dependency_resolver_service.rb'
-    - 'app/services/packages/rubygems/process_gem_service.rb'
-    - 'app/services/packages/terraform_module/create_package_service.rb'
-    - 'app/services/packages/update_tags_service.rb'
     - 'app/services/projects/container_repository/cleanup_tags_base_service.rb'
     - 'app/services/projects/container_repository/third_party/cleanup_tags_service.rb'
     - 'app/services/projects/create_from_template_service.rb'

.rubocop_todo/layout/argument_alignment.yml

@@ -1047,7 +1047,6 @@ Layout/ArgumentAlignment:
     - 'ee/lib/gitlab/subscription_portal/clients/graphql.rb'
     - 'ee/lib/gitlab/zoekt/search_results.rb'
     - 'ee/spec/components/billing/plan_component_spec.rb'
-    - 'ee/spec/components/namespaces/storage/pre_enforcement_alert_component_spec.rb'
     - 'ee/spec/elastic/migrate/20220119120500_populate_commit_permissions_in_main_index_spec.rb'
     - 'ee/spec/elastic/migrate/20221124090600_add_namespace_ancestry_ids_to_original_index_mapping_spec.rb'
     - 'ee/spec/elastic/migrate/20221221110300_backfill_traversal_ids_to_blobs_and_wiki_blobs_spec.rb'

.rubocop_todo/layout/line_continuation_spacing.yml

@@ -22,8 +22,6 @@ Layout/LineContinuationSpacing:
     - 'app/services/uploads/destroy_service.rb'
     - 'app/services/users/email_verification/validate_token_service.rb'
     - 'config/initializers_before_autoloader/003_gc_compact.rb'
-    - 'ee/app/components/namespaces/storage/pre_enforcement_alert_component.rb'
-    - 'ee/app/components/namespaces/storage/user_pre_enforcement_alert_component.rb'
     - 'ee/app/controllers/ee/ldap/omniauth_callbacks_controller.rb'
     - 'ee/app/graphql/mutations/app_sec/fuzzing/api/ci_configuration/create.rb'
     - 'ee/app/graphql/mutations/requirements_management/export_requirements.rb'

.rubocop_todo/rspec/avoid_conditional_statements.yml

@@ -8,7 +8,6 @@ RSpec/AvoidConditionalStatements:
     - 'ee/spec/features/boards/user_visits_board_spec.rb'
     - 'ee/spec/features/ci_shared_runner_warnings_spec.rb'
     - 'ee/spec/features/epic_boards/epic_boards_spec.rb'
-    - 'ee/spec/features/epics/epic_show_spec.rb'
     - 'ee/spec/features/epics/gfm_autocomplete_spec.rb'
     - 'ee/spec/features/group_protected_branches_spec.rb'
     - 'ee/spec/features/groups/analytics/cycle_analytics/filters_and_data_spec.rb'

.rubocop_todo/rspec/verified_doubles.yml

@@ -941,7 +941,6 @@ RSpec/VerifiedDoubles:
     - 'spec/support/helpers/ldap_helpers.rb'
     - 'spec/support/helpers/project_forks_helper.rb'
     - 'spec/support/helpers/stub_metrics.rb'
-    - 'spec/support/helpers/stub_spam_services.rb'
     - 'spec/support/import_export/common_util.rb'
     - 'spec/support/prometheus/additional_metrics_shared_examples.rb'
     - 'spec/support/shared_contexts/lib/gitlab/sidekiq_middleware/server_metrics_shared_context.rb'

.rubocop_todo/style/percent_literal_delimiters.yml

@@ -33,7 +33,6 @@ Style/PercentLiteralDelimiters:
     - 'app/models/blob_viewer/godeps_json.rb'
     - 'app/models/blob_viewer/license.rb'
     - 'app/models/blob_viewer/markup.rb'
-    - 'app/models/blob_viewer/metrics_dashboard_yml.rb'
     - 'app/models/blob_viewer/notebook.rb'
     - 'app/models/blob_viewer/open_api.rb'
     - 'app/models/blob_viewer/package_json.rb'

CHANGELOG.md

@@ -2,6 +2,18 @@
 documentation](doc/development/changelog.md) for instructions on adding your own
 entry.
+## 16.0.3 (2023-06-06)
+
+### Fixed (3 changes)
+
+- [Fix memory leak in CI config includes entry](gitlab-org/gitlab@1e42968f69e556d13b4765ccd685dd47c87c4493) ([merge request](gitlab-org/gitlab!122539))
+- [Fix MR approval rules sync when disabling scan result policy](gitlab-org/gitlab@d708d6e5ca85dbc806e76c320661ffc8c2ea694d) ([merge request](gitlab-org/gitlab!122466)) **GitLab Enterprise Edition**
+- [Fix serialization of pull requests in BitbucketServer Import](gitlab-org/gitlab@8b3dce34122aa9a40921db7e957353f42750d3c5) ([merge request](gitlab-org/gitlab!122395))
+
+### Performance (1 change)
+
+- [LFS: Serve pre-signed URLs in `/lfs/objects/batch`](gitlab-org/gitlab@086ded4a9ed937e44b816a2ad835bb20d99e084e) ([merge request](gitlab-org/gitlab!122349))
+
 ## 16.0.2 (2023-06-05)
 ### Fixed (1 change)
@@ -809,6 +821,21 @@ entry.
 - [Add index to group_group_links table](gitlab-org/gitlab@9a3f2c1a90b54074e61d0abf07101ce664198e81) ([merge request](gitlab-org/gitlab!117386))
 - [Validate the projects.creator_id foregin key synchronously](gitlab-org/gitlab@ed9351984a16f20506babf6eab6706b917904ed1) ([merge request](gitlab-org/gitlab!117147))
+## 15.11.8 (2023-06-06)
+
+### Fixed (2 changes)
+
+- [Fix memory leak in CI config includes entry](gitlab-org/gitlab@3e367e614c855352295e3bcab25bf5af4ec66bf5) ([merge request](gitlab-org/gitlab!122540))
+- [Fix serialization of pull_requests in Bitbucket Server Import](gitlab-org/gitlab@201ad93dfdf8f4acfb6d6eee32e2bd6a4ff68157) ([merge request](gitlab-org/gitlab!122396))
+
+### Security (1 change)
+
+- [Validate description length in labels](gitlab-org/gitlab@2c821ee0823e37a57a6dc049591097232c933713) ([merge request](gitlab-org/gitlab!122697))
+
+### Performance (1 change)
+
+- [LFS: Serve pre-signed URLs in `/lfs/objects/batch`](gitlab-org/gitlab@df3a9655a0e8f0bdab3433cefcbd37acfb8ebcff) ([merge request](gitlab-org/gitlab!122348))
+
 ## 15.11.7 (2023-06-05)
 ### Security (16 changes)

app/assets/javascripts/admin/abuse_report/components/report_actions.vue

@@ -13,6 +13,7 @@ import { getContentWrapperHeight } from '~/lib/utils/dom_utils';
 import { DRAWER_Z_INDEX } from '~/lib/utils/constants';
 import {
   ACTIONS_I18N,
+  NO_ACTION,
   USER_ACTION_OPTIONS,
   REASON_OPTIONS,
   STATUS_OPEN,
@@ -40,6 +41,10 @@ export default {
     GlDrawer,
   },
   props: {
+    user: {
+      type: Object,
+      required: true,
+    },
     report: {
       type: Object,
       required: true,
@@ -66,6 +71,12 @@ export default {
     isOpen() {
       return this.report.status === STATUS_OPEN;
     },
+    isNotCurrentUser() {
+      return this.user.username !== gon.current_username;
+    },
+    userActionOptions() {
+      return this.isNotCurrentUser ? USER_ACTION_OPTIONS : [NO_ACTION];
+    },
   },
   methods: {
     toggleActionsDrawer() {
@@ -111,7 +122,6 @@ export default {
     },
   },
   i18n: ACTIONS_I18N,
-  userActionOptions: USER_ACTION_OPTIONS,
   reasonOptions: REASON_OPTIONS,
   DRAWER_Z_INDEX,
 };
@@ -144,7 +154,7 @@ export default {
               id="action"
               v-model="form.user_action"
               data-testid="action-select"
-              :options="$options.userActionOptions"
+              :options="userActionOptions"
               :state="validationState.action"
               @change="validateAction"
             />

app/assets/javascripts/admin/abuse_report/components/report_header.vue

@@ -81,6 +81,7 @@ export default {
         {{ $options.i18n.adminProfile }}
       </gl-button>
       <report-actions
+        :user="user"
         :report="report"
         class="gl-sm-ml-3 gl-mt-3 gl-sm-mt-0"
         @closeReport="closeReport"

app/assets/javascripts/admin/abuse_report/constants.js

@@ -24,8 +24,10 @@ export const ACTIONS_I18N = {
   requiredFieldFeedback: __('This field is required.'),
 };
 
+export const NO_ACTION = { value: '', text: s__('AbuseReport|No action') };
+
 export const USER_ACTION_OPTIONS = [
-  { value: '', text: s__('AbuseReport|No action') },
+  NO_ACTION,
   { value: 'block_user', text: s__('AbuseReport|Block user') },
   { value: 'ban_user', text: s__('AbuseReport|Ban user') },
   { value: 'delete_user', text: s__('AbuseReport|Delete user') },

app/assets/javascripts/analytics/shared/constants.js

@@ -20,10 +20,13 @@ const formatDateParam = (d) => dateFormat(d, dateFormats.isoDate, true);
 
 export const METRIC_POPOVER_LABEL = s__('ValueStreamAnalytics|View details');
 
-export const KEY_METRICS = {
+export const ISSUES_COMPLETED_TYPE = 'issues_completed';
+
+export const FLOW_METRICS = {
   LEAD_TIME: 'lead_time',
   CYCLE_TIME: 'cycle_time',
   ISSUES: 'issues',
+  ISSUES_COMPLETED: ISSUES_COMPLETED_TYPE,
   COMMITS: 'commits',
   DEPLOYS: 'deploys',
 };
@@ -38,7 +41,7 @@ export const DORA_METRICS = {
 const VSA_FLOW_METRICS_GROUP = {
   key: 'key_metrics',
   title: s__('ValueStreamAnalytics|Key metrics'),
-  keys: Object.values(KEY_METRICS),
+  keys: Object.values(FLOW_METRICS),
 };
 
 export const VSA_METRICS_GROUPS = [VSA_FLOW_METRICS_GROUP];
@@ -90,7 +93,7 @@ export const METRIC_TOOLTIPS = {
     projectLink: '-/pipelines/charts?chart=change-failure-rate',
     docsLink: helpPagePath('user/analytics/dora_metrics', { anchor: 'change-failure-rate' }),
   },
-  [KEY_METRICS.LEAD_TIME]: {
+  [FLOW_METRICS.LEAD_TIME]: {
     description: s__('ValueStreamAnalytics|Median time from issue created to issue closed.'),
     groupLink: '-/analytics/value_stream_analytics',
     projectLink: '-/value_stream_analytics',
@@ -98,7 +101,7 @@ export const METRIC_TOOLTIPS = {
       anchor: 'view-the-lead-time-and-cycle-time-for-issues',
     }),
   },
-  [KEY_METRICS.CYCLE_TIME]: {
+  [FLOW_METRICS.CYCLE_TIME]: {
     description: s__(
       "ValueStreamAnalytics|Median time from the earliest commit of a linked issue's merge request to when that issue is closed.",
     ),
@@ -108,13 +111,21 @@ export const METRIC_TOOLTIPS = {
       anchor: 'view-the-lead-time-and-cycle-time-for-issues',
     }),
   },
-  [KEY_METRICS.ISSUES]: {
+  [FLOW_METRICS.ISSUES]: {
     description: s__('ValueStreamAnalytics|Number of new issues created.'),
     groupLink: '-/issues_analytics',
     projectLink: '-/analytics/issues_analytics',
     docsLink: helpPagePath('user/analytics/issue_analytics'),
   },
-  [KEY_METRICS.DEPLOYS]: {
+  [FLOW_METRICS.ISSUES_COMPLETED]: {
+    description: s__('ValueStreamAnalytics|Number of issues closed by month.'),
+    groupLink: '-/analytics/value_stream_analytics',
+    projectLink: '-/value_stream_analytics',
+    docsLink: helpPagePath('user/analytics/value_streams_dashboard', {
+      anchor: 'dashboard-metrics-and-drill-down-reports',
+    }),
+  },
+  [FLOW_METRICS.DEPLOYS]: {
     description: s__('ValueStreamAnalytics|Total number of deploys to production.'),
     groupLink: '-/analytics/productivity_analytics',
     projectLink: '-/analytics/merge_request_analytics',

app/assets/javascripts/ci/artifacts/components/artifact_row.vue

@@ -8,12 +8,10 @@ import {
   GlTooltipDirective,
 } from '@gitlab/ui';
 import { numberToHumanSize } from '~/lib/utils/number_utils';
-import glFeatureFlagsMixin from '~/vue_shared/mixins/gl_feature_flags_mixin';
 import {
   I18N_EXPIRED,
   I18N_DOWNLOAD,
   I18N_DELETE,
-  BULK_DELETE_FEATURE_FLAG,
   I18N_BULK_DELETE_MAX_SELECTED,
 } from '../constants';
 
@@ -29,7 +27,6 @@ export default {
   directives: {
     GlTooltip: GlTooltipDirective,
   },
-  mixins: [glFeatureFlagsMixin()],
   inject: ['canDestroyArtifacts'],
   props: {
     artifact: {
@@ -66,7 +63,7 @@ export default {
       return numberToHumanSize(this.artifact.size);
     },
     canBulkDestroyArtifacts() {
-      return this.glFeatures[BULK_DELETE_FEATURE_FLAG] && this.canDestroyArtifacts;
+      return this.canDestroyArtifacts;
     },
   },
   methods: {

app/assets/javascripts/ci/artifacts/components/job_artifacts_table.vue

@@ -15,7 +15,6 @@ import { createAlert } from '~/alert';
 import { getIdFromGraphQLId, convertToGraphQLId } from '~/graphql_shared/utils';
 import TimeAgo from '~/vue_shared/components/time_ago_tooltip.vue';
 import CiIcon from '~/vue_shared/components/ci_icon.vue';
-import glFeatureFlagsMixin from '~/vue_shared/mixins/gl_feature_flags_mixin';
 import { TYPENAME_PROJECT } from '~/graphql_shared/constants';
 import getJobArtifactsQuery from '../graphql/queries/get_job_artifacts.query.graphql';
 import { totalArtifactsSizeForJob, mapArchivesToJobNodes, mapBooleansToJobNodes } from '../utils';
@@ -39,7 +38,6 @@ import {
   INITIAL_NEXT_PAGE_CURSOR,
   JOBS_PER_PAGE,
   INITIAL_LAST_PAGE_SIZE,
-  BULK_DELETE_FEATURE_FLAG,
   I18N_BULK_DELETE_ERROR,
   I18N_BULK_DELETE_PARTIAL_ERROR,
   I18N_BULK_DELETE_CONFIRMATION_TOAST,
@@ -83,7 +81,6 @@ export default {
   directives: {
     GlTooltip: GlTooltipDirective,
   },
-  mixins: [glFeatureFlagsMixin()],
   inject: ['projectId', 'projectPath', 'canDestroyArtifacts'],
   apollo: {
     jobArtifacts: {
@@ -161,7 +158,7 @@ export default {
       return this.selectedArtifacts.length >= SELECTED_ARTIFACTS_MAX_COUNT;
     },
     canBulkDestroyArtifacts() {
-      return this.glFeatures[BULK_DELETE_FEATURE_FLAG] && this.canDestroyArtifacts;
+      return this.canDestroyArtifacts;
     },
     isDeletingArtifactsForJob() {
       return this.jobArtifactsToDelete.length > 0;

app/assets/javascripts/ci/artifacts/constants.js

@@ -54,7 +54,6 @@ export const I18N_FEEDBACK_BANNER_BODY = s__(
 export const I18N_FEEDBACK_BANNER_BUTTON = s__('Artifacts|Take a quick survey');
 export const FEEDBACK_URL = 'https://gitlab.fra1.qualtrics.com/jfe/form/SV_cI9rAUI20Vo2St8';
 
-export const BULK_DELETE_FEATURE_FLAG = 'ciJobArtifactBulkDestroy';
 export const SELECTED_ARTIFACTS_MAX_COUNT = 50;
 export const I18N_BULK_DELETE_MAX_SELECTED = s__(
   'Artifacts|Maximum selected artifacts limit reached',

app/assets/javascripts/ci/ci_variable_list/components/ci_variable_modal.vue

@@ -154,7 +154,9 @@ export default {
       return createJoinedEnvironments(this.variables, this.environments, this.newEnvironments);
     },
     maskedFeedback() {
-      return this.displayMaskedError ? __('This variable can not be masked.') : '';
+      return this.displayMaskedError
+        ? __('This variable value does not meet the masking requirements.')
+        : '';
     },
     maskedState() {
       if (this.displayMaskedError) {
@@ -190,6 +192,11 @@ export default {
     variableValidationState() {
       return this.variable.value === '' || (this.tokenValidationState && this.maskedState);
     },
+    variableValueHelpText() {
+      return this.variable.masked
+        ? __('Value must meet regular expression requirements to be masked.')
+        : '';
+    },
   },
   watch: {
     variable: {
@@ -324,6 +331,7 @@ export default {
         :label="__('Value')"
         label-for="ci-variable-value"
         :state="variableValidationState"
+        :description="variableValueHelpText"
         :invalid-feedback="variableValidationFeedback"
       >
         <gl-form-textarea
@@ -423,17 +431,19 @@ export default {
         >
           {{ __('Mask variable') }}
           <p class="gl-mt-2 text-secondary">
-            {{ __('Variable will be masked in job logs.') }}
-            <span
-              :class="{
-                'bold text-plain': displayMaskedError,
-              }"
-            >
-              {{ __('Requires values to meet regular expression requirements.') }}</span
+            <gl-sprintf
+              :message="
+                __(
+                  'Mask this variable in job logs if it meets %{linkStart}regular expression requirements%{linkEnd}.',
+                )
+              "
             >
-            <gl-link target="_blank" :href="maskedEnvironmentVariablesLink">{{
-              __('Learn more.')
-            }}</gl-link>
+              <template #link="{ content }"
+                ><gl-link target="_blank" :href="maskedEnvironmentVariablesLink">{{
+                  content
+                }}</gl-link>
+              </template>
+            </gl-sprintf>
           </p>
         </gl-form-checkbox>
         <gl-form-checkbox

app/assets/javascripts/ci/pipeline_editor/components/file_nav/branch_switcher.vue

@@ -229,7 +229,6 @@ export default {
     <gl-infinite-scroll
       :fetched-items="availableBranches.length"
       :max-list-height="250"
-      data-qa-selector="branch_menu_container"
       @bottomReached="fetchNextBranches"
     >
       <template #items>
@@ -238,7 +237,6 @@ export default {
           :key="branch"
           :is-checked="currentBranch === branch"
           is-check-item
-          data-qa-selector="branch_menu_item_button"
           @click="selectBranch(branch)"
         >
           {{ branch }}

app/assets/javascripts/ci/pipeline_new/components/refs_dropdown.vue

@@ -28,6 +28,13 @@ export default {
       required: false,
       default: () => ({}),
     },
+    queryParams: {
+      type: Object,
+      required: false,
+      default: () => ({
+        sort: 'updated_desc',
+      }),
+    },
   },
   computed: {
     refShortName() {
@@ -51,6 +58,7 @@ export default {
     :project-id="projectId"
     :translations="$options.i18n"
     :use-symbolic-ref-names="true"
+    :query-params="queryParams"
     toggle-button-class="gl-w-auto! gl-mb-0!"
     @input="setRefSelected"
   />