Skip to content
Snippets Groups Projects
  1. Feb 04, 2025
  2. Nov 07, 2024
  3. Nov 14, 2023
  4. Sep 21, 2022
  5. Aug 07, 2022
  6. Jul 19, 2021
  7. Jun 02, 2021
  8. Jan 21, 2021
    • Chad Woolley's avatar
      Refactor SpamActionService and its usage · 93ac9733
      Chad Woolley authored
      * Removes 'SpamCheckMethods' and makes spam-checking workflow
        explicit in callers
      * Moves captcha verification to be encapsulated in 'SpamActionService'
      * Introduces 'CaptchaVerificationService', which can be expanded upon
        on the future for additional captcha implementations.
      * Moves handling of 'request' parameter to be called only where it
        is needed.
      * Removes memoization of GitLab::Recaptcha.load_configurations! -
        it complicates testing/mocking, and it isn't clear why it was
        ever needed - it isn't memoized other places.
      * Rewrites issue and snippet service create/update tests to remove
        tests of internal behavior of other services, and instead just
        test their collaborations via mock expectations.
      * Expands and improves test coverage of SpamActionService
      * Other related changes to accomodate new interface and behavior.
      93ac9733
  9. Dec 13, 2020
  10. Nov 23, 2020
    • Achilleas Pipinellis's avatar
      Update handbook URL for Technical Writers assignments · 2dc1b3be
      Achilleas Pipinellis authored
      The previous URL had two drawbacks:
      
      1. It didn't match what the title was about (`Assignments to DevOps
         Stages and Groups`, and the anchor was `#designated-technical-writers`).
      2. It didn't account for the other sections, like development and API
         guidelines.
      2dc1b3be
  11. Oct 30, 2020
  12. May 21, 2020
  13. Feb 24, 2020
  14. Sep 17, 2019
  15. Jul 24, 2019
    • Marcel Amirault's avatar
      Clean up headers in markdown · 74a34e8b
      Marcel Amirault authored
      Some markdown headers needed tweaking to adhere
      to standards, including blank lines above and below,
      only one space after hash, first header should be
      h1, and only one h1 per doc
      74a34e8b
  16. Sep 21, 2018
  17. Sep 19, 2018
  18. Nov 30, 2017
    • Lin Jen-Shin's avatar
      Merge branch 'no-ivar-in-modules' into tmp · 91756788
      Lin Jen-Shin authored
      * no-ivar-in-modules:
        Cache allowed_ids
        Fix a few layout error
        Make it clear that this is an acceptable use
        Reword Instance variables in views
        Move ModuleWithInstanceVariables to Gitlab namespace
        Explain how to disable it in the doc
        Just define allowed_ids and override it with empty value
        Updates based on feedback
        Remove codes from bad merge
        Allow initialize method and single ivar
        Use StrongMemoize and enable/disable cops properly
        WIP
        Fix grammar: judge -> judgement
        Allow simple ivar ||= form. Update accordingly
        Add cop to make sure we don't use ivar in a module
      91756788
  19. Nov 22, 2017
  20. Nov 21, 2017
  21. Sep 19, 2017
  22. Sep 18, 2017
Loading