Skip to content
Snippets Groups Projects
  1. Feb 25, 2025
  2. Feb 24, 2025
  3. Feb 17, 2025
  4. Feb 12, 2025
  5. Feb 03, 2025
  6. Jan 16, 2025
  7. Jan 15, 2025
  8. Dec 17, 2024
  9. Dec 12, 2024
  10. Nov 29, 2024
  11. Nov 28, 2024
  12. Nov 27, 2024
  13. Nov 11, 2024
  14. Nov 05, 2024
  15. Oct 29, 2024
  16. Oct 28, 2024
  17. Oct 25, 2024
    • Paul Gascou-Vaillancourt's avatar
      Remove the Tailwind Dangerfile · a5b5073a
      Paul Gascou-Vaillancourt authored
      This Dangerfile used to report CSS utils that were built using string
      interpolation. Since introducing it, we have created an ESLint and a
      Rubocop rules to perform the same checks, thus providing a better
      developer experience for spotting this offences.
      
      The Dangerfile can therefore be removed.
      a5b5073a
  18. Oct 24, 2024
    • Dylan Griffith's avatar
      Remove Danger warning for finalizing migration required stop · 21f7559d
      Dylan Griffith authored
      Since !165146 we
      now have a CI job that enforces a required stop has passed before we can
      finalize a background migration.
      
      Additionally these danger warnings are quite noisy. For example all the
      discussions I had to resolve in
      !169518 .
      
      This note does also mention "Check the timings" and theoretically there
      may be a case to wait for 2 required stops for any migration that is
      very slow but I don't believe we do this in practice. For now I think
      we've settled on the following requirements before finalizing:
      
      1. It is finished on GitLab.com
      2. We've passed a required stop
      
      And we already have adequate enforcement for these so I don't think this
      warning is really helping us anymore.
      21f7559d
  19. Sep 23, 2024
    • David O'Regan's avatar
      Add DangerBot check for AI logging compliance · 2144bdac
      David O'Regan authored
      This commit introduces a new Dangerfile to check for AI logging compliance:
      
      - Detect usage of GitLab::Llm::Logger.build.info and .error methods
      - Warn when AI logging is not gated behind expanded_ai_logging flag
      - List files with potentially non-compliant AI logging
      - Add relevant labels to merge requests with AI logging
      
      This check helps ensure adherence to GitLab's AI data usage policies and
      promotes proper AI logging practices across the codebase.
      Verified
      2144bdac
  20. Aug 29, 2024
  21. Aug 26, 2024
  22. Aug 20, 2024
    • Andrew Evans's avatar
      Add Dangerfile reminder when setting cookies server-side · b6576b60
      Andrew Evans authored
      If a developer sets a cookie from Rails with a `:domain` attribute, they
      must remember to un-set this cookie when a user signs out. This can be
      hard to remember to do.
      
      This change adds a Danger bot reminder whenever setting cookies is
      detected in application code, and also documentation of development
      guidelines when working with cookies.
      Verified
      b6576b60
  23. Aug 12, 2024
  24. Aug 06, 2024
  25. Aug 03, 2024
  26. Aug 02, 2024
  27. Jul 29, 2024
  28. Jul 15, 2024
  29. Jul 04, 2024
  30. Jun 28, 2024
    • Lukas Eipert's avatar
      Remove Dangerfile for prettier · b984960a
      Lukas Eipert authored
      This Dangerfile dates back to when we gradually adopted prettier. Now
      our code base is fully prettier compliant and we have a separate
      static-analysis job for prettier _and_ we run it part of lefthook. So
      this Danger job just adds noise to the already long danger output and
      potentially takes a long time.
      
      Let's remove it, it outlived it's purpose.
      b984960a
  31. Jun 26, 2024
  32. Jun 25, 2024
  33. Jun 10, 2024
  34. Jun 05, 2024
    • Mayra Cabrera's avatar
      Revert "Merge branch 'list-tailwind-css-equivalents-in-danger' into 'master'" · af70b102
      Mayra Cabrera authored
      This reverts merge request !154168
      Verified
      af70b102
    • James Nutt's avatar
      Add path to feature flag fallback note · 62a478c7
      James Nutt authored
      The current fallback note for an unfilled `feature_issue_url:` does not
      provide enough context to make it obvious what it's referring to. This
      MR adds the file path to direct the author of the MR in the right
      direction.
      
      Before:
      
      ```
      - [ ] config/feature_flags/beta/flag_with_blank_feature_url.yml#L3: Consider filling `feature_issue_url:`
      - [ ] Consider filling `feature_issue_url:`
      ```
      
      After:
      
      ```
      - [ ] config/feature_flags/beta/flag_with_blank_feature_url.yml#L3: Consider filling `feature_issue_url:`
      - [ ] config/feature_flags/beta/flag_with_missing_feature_url.yml: Consider filling `feature_issue_url:`
      ```
      62a478c7
  35. Jun 04, 2024
  36. May 29, 2024
  37. May 22, 2024
Loading