- Feb 25, 2025
-
-
Pam Artiaga authored
-
- Feb 24, 2025
-
-
Pam Artiaga authored
-
- Feb 17, 2025
-
-
Marcel Amirault authored
-
- Feb 12, 2025
-
-
Marcel Amirault authored
We do not need to link to index files, and in the future it will be recommended to avoid it. Changelog: changed
-
- Feb 03, 2025
-
-
Miranda Fluharty authored
-
- Jan 16, 2025
-
-
Marcel Amirault authored
Docs reviews are not optional, but the timing is flexible
-
- Jan 15, 2025
-
-
Luke Duncalfe authored
-
- Dec 17, 2024
-
-
Nicolas Dular authored
-
- Dec 12, 2024
-
-
Rémy Coutable authored
Signed-off-by:
Rémy Coutable <remy@rymai.me>
-
- Nov 29, 2024
-
-
Andrew Jung authored
- For internal_users.rb Changelog: fixed
-
- Nov 28, 2024
-
-
Andrew Jung authored
This reverts merge request !171439
-
- Nov 27, 2024
-
-
Andrew Jung authored
This check detects changes to the `internal.rb` for *_bot users, or when they are used in `user_type: ` It adds a comment to the overall MR Changelog: changed
-
- Nov 11, 2024
-
-
Safwan Ahmed authored
Co-authored-by:
Peter Leitzen <pleitzen@gitlab.com>
-
- Nov 05, 2024
-
-
Peter Leitzen authored
-
- Oct 29, 2024
-
-
drew stachon authored
-
- Oct 28, 2024
-
-
Martin Wortschack authored
-
- Oct 25, 2024
-
-
Paul Gascou-Vaillancourt authored
This Dangerfile used to report CSS utils that were built using string interpolation. Since introducing it, we have created an ESLint and a Rubocop rules to perform the same checks, thus providing a better developer experience for spotting this offences. The Dangerfile can therefore be removed.
-
- Oct 24, 2024
-
-
Dylan Griffith authored
Since !165146 we now have a CI job that enforces a required stop has passed before we can finalize a background migration. Additionally these danger warnings are quite noisy. For example all the discussions I had to resolve in !169518 . This note does also mention "Check the timings" and theoretically there may be a case to wait for 2 required stops for any migration that is very slow but I don't believe we do this in practice. For now I think we've settled on the following requirements before finalizing: 1. It is finished on GitLab.com 2. We've passed a required stop And we already have adequate enforcement for these so I don't think this warning is really helping us anymore.
-
- Sep 23, 2024
-
-
David O'Regan authored
This commit introduces a new Dangerfile to check for AI logging compliance: - Detect usage of GitLab::Llm::Logger.build.info and .error methods - Warn when AI logging is not gated behind expanded_ai_logging flag - List files with potentially non-compliant AI logging - Add relevant labels to merge requests with AI logging This check helps ensure adherence to GitLab's AI data usage policies and promotes proper AI logging practices across the codebase.
-
- Aug 29, 2024
-
-
Andrejs Cunskis authored
-
- Aug 26, 2024
-
-
Paul Gascou-Vaillancourt authored
-
Lukas Eipert authored
Since !163878 we have a check against using legacy utilities. This makes this danger message kind of obsolete. The check against interpolated utility classes could be a rubocop / eslint rule instead.
-
- Aug 20, 2024
-
-
Andrew Evans authored
If a developer sets a cookie from Rails with a `:domain` attribute, they must remember to un-set this cookie when a user signs out. This can be hard to remember to do. This change adds a Danger bot reminder whenever setting cookies is detected in application code, and also documentation of development guidelines when working with cookies.
-
- Aug 12, 2024
-
-
Jennifer Li authored
Remove spec
-
- Aug 06, 2024
-
-
Thomas Hutterer authored
Settings sections can be searched through the command palette. But this only works if they are kept in sync with the files that drive that search.
-
- Aug 03, 2024
-
-
Jose Ivan Vargas authored
-
- Aug 02, 2024
-
-
Niko Belokolodov authored
-
- Jul 29, 2024
-
-
Jennifer Li authored
-
- Jul 15, 2024
-
-
Jennifer Li authored
Co-authored-by:
Peter Leitzen <pleitzen@gitlab.com>
-
- Jul 04, 2024
-
-
Marc Saleiko authored
-
- Jun 28, 2024
-
-
Lukas Eipert authored
This Dangerfile dates back to when we gradually adopted prettier. Now our code base is fully prettier compliant and we have a separate static-analysis job for prettier _and_ we run it part of lefthook. So this Danger job just adds noise to the already long danger output and potentially takes a long time. Let's remove it, it outlived it's purpose.
-
- Jun 26, 2024
-
-
Rémy Coutable authored
Signed-off-by:
Rémy Coutable <remy@rymai.me>
-
- Jun 25, 2024
-
-
Jennifer Li authored
Refactor with Job Struct This is a major refactor commit Finish refactor and unit tests
-
Peter Leitzen authored
Suggest to use `feature_category: ...`.
-
- Jun 10, 2024
-
-
Peter Hegman authored
To help make the migration process easier
-
- Jun 05, 2024
-
-
Mayra Cabrera authored
This reverts merge request !154168
-
James Nutt authored
The current fallback note for an unfilled `feature_issue_url:` does not provide enough context to make it obvious what it's referring to. This MR adds the file path to direct the author of the MR in the right direction. Before: ``` - [ ] config/feature_flags/beta/flag_with_blank_feature_url.yml#L3: Consider filling `feature_issue_url:` - [ ] Consider filling `feature_issue_url:` ``` After: ``` - [ ] config/feature_flags/beta/flag_with_blank_feature_url.yml#L3: Consider filling `feature_issue_url:` - [ ] config/feature_flags/beta/flag_with_missing_feature_url.yml: Consider filling `feature_issue_url:` ```
-
- Jun 04, 2024
-
-
Peter Hegman authored
To help make the migration process easier
-
- May 29, 2024
-
-
Archish Thakkar authored
Changelog: other EE: true
-
- May 22, 2024
-
-
Peter Hegman authored
Also add section about spacing and colors on official Tailwind docs and update copy in danger rule
-