- /workhorse/internal/api/api.go
- /workhorse/internal/api/api_test.go
- /workhorse/internal/git/git-http.go
- /workhorse/internal/git/receive-pack.go
- /workhorse/internal/git/upload-pack.go
- /workhorse/internal/gitaly/smarthttp.go

Return a new, custom PreAuthorizeFixedPathError error.

Changelog: other

Signed-off-by: starvader13 <ashutoshgupta1311@gmail.com>

Update the links in code and autogenerated docs

 This is to support other optional features apart from flushing

Copy implementation of `http.ResponseController` `Flush` method to work with
versions lower than go 1.20 where `http.ResponseController` was
introduced.

* Adds `stream: true` to /code_suggestions/completions API
* Allow Worhorse to flush response body every time it's received,
  instead of buffer response body chunks

Changelog: added
EE: true

Sylvester Chin authored 1 year ago and Igor Drozdov committed 1 year ago

Changelog: fixed

testify/require cannot be used in a goroutine, which might be the case in a test. See https://github.com/golang/go/issues/15758.

We moved to Go 1.20 in GitLab 16.2 and no GitLab versions in our
support policy is built using Go 1.19.

We are working on a feature based on the http.ResponseController type
that was introduced in Go 1.20 and to avoid porting this type to Go 1.19
we should simply drop the test suite.

David Fernandez authored 1 year ago and Igor Drozdov committed 1 year ago

for send_url and send_dependency functions. The dependency proxy for
packages will use a 10s timeout instead of a 30s.

In addition, if a timeout is hit, we will return a 503 error (service
unavailable) instead of the generic 500 error (internal server error).

What
---
Handle [ProtocolError](https://cs.opensource.google/go/go/+/master:src/net/textproto/textproto.go;drc=ee6b34797b66b957fdf9b7211ee3f0b80ac57758;l=46) for multipart upload.

Why
---
When a user sends an invalid `Content-Disposition` Go sends a [malformed
MIME header
line](https://cs.opensource.google/go/go/+/master:src/net/textproto/reader.go;l=526?q=%22malformed%20MIME%20header%20line%22&ss=go%2Fgo)
and we end up returning a 500 error instead of a 400 error.

Since this is an invalid value that our user sends we need to return a
400 instead of 500, so it doesn't attribute to our error rate, and
to indicate the user did something wrong.

Reference: #432533


Changelog: fixed
Signed-off-by: Steve Xuereb <sxuereb@gitlab.com>

Sylvester Chin authored 1 year ago and Ash McKenzie committed 1 year ago

Changelog: other