Changelog: other

Move /-/profile/keys to /-/user_settings/ssh_keys and
redirect end_point to new endpoint till next major release (17.0)

Changelog: changed
EE: true

This primarily affects MailDeliveryJob enqueues by ActionMailer.

Changelog: other

Gavin Hinfey authored 11 months ago and Gavin Hinfey committed 10 months ago

Move /-/profile/gpg_keys to /-/user_settings/gpg_keys and
redirect end_point to new endpoint till next major release (17.0)

Changelog: changed

See https://docs.gitlab.com/ee/development/database/avoiding_downtime_in_migrations.html#swap-the-columns-release-n--1

Changelog: changed

This MR removes some existing style violations and the associated
`.rubocop-todo` entries.

Furkan Ayhan authored 11 months ago and Leaminn Ma committed 10 months ago

We will be changing how catalog publishing works by moving
the metadata processing and publishing to release-cli.
In our ideal case, `Releases::CreateService` should not run
`Ci::Catalog::Resources::ReleaseService` and this should be in
a separate endpoint. And in the future, we'll also change the catalog
publishing service because we don't want to calculate the metadata
on the server side.

To this end, we are deferring the catalog publish decision to
release-cli;

- If release-cli sends `legacy_catalog_publish` true, then
`Releases::CreateService` publishes the catalog resource.
- Otherwise, it does not publish the catalog.
It only creates the release.

In this MR, we are adding the new `legacy_catalog_publish` parameter
to the `/releases` API endpoint. Then, we are using it in
`Releases::CreateService` to decide publishing the catalog resource.

We are also starting to send the `--catalog-publish` CLI option to
release-cli. This will notify the release-cli that "this release is a
catalog resource so send `legacy_catalog_publish` as true if you want
to publish this release". In the future, release-cli will still use this
flag but then it will not send the `legacy_catalog_publish` parameter.
Instead, it will call the catalog resource endpoint separately.

These changes are behind the FF `ci_release_cli_catalog_publish_option`.
We'll use this FF to control this change to prevent breaking changes.

MR: gitlab.com/gitlab-org/gitlab/-/merge_requests/148122

Changelog: removed

Changelog: other
EE: true

Changelog: other

This is the first step to convert pipeline_id related to bigint for:
- merge_requests.head_pipeline_id

See https://docs.gitlab.com/ee/development/database/avoiding_downtime_in_migrations.html#initialize-the-conversion-and-start-migrating-existing-data-release-n

Changelog: added

In case of `have_gitlab_http_status(-1)` we've seen an
`RuboCop::Runner::InfiniteCorrectionLoop` error after upgrading RuboCop.

This commits side-steps this problem by checking if replacement is not
identical to the previous source version.

This reverts merge request !148160

Currently users go through identity verification process as part of the
registration process. Moving forward, we want to allow users that have
already started using Gitlab to go through identity verification to
complete verification methods–phone number and/or credit card
verification–that they didn't go through during registration in exchange
for in-app benefits (e.g. more CI minutes).

Here, we move controller code that are only relevant to identity
verification during registration to a new
RegistrationsIdentityVerificationController module and move all reusable
controller code from IdentityVerificationController to a new
BaseIdentityVerificationController module.

Changelog: other

EE: true

New experiment to update empty pages
for project MRs lists

Add a new test_level :tooling which contains:
- spec/dot_gitlab_ci
- spec/tooling

This commit refactors the NamespaceSettings::UpdateService class
to NamespaceSettings::AssignAttributesService, since it does not
actually updated namespace settings, it assigns attributes.

The commit involves a complete refactoring of the class and all
references to it in other files, along with the renaming of any
ruby namespace file with "update_service" in the name to "assign_
attributes_service", and updating rubocop config files that
reference them. This is done in both the core and enterprise
directories.

Fixes #444223

Signed-off-by: Nailia Iskhakova <niskhakova@gitlab.com>

This commit removes exclusions from RuboCop TODOs and
rspec_order_todo.yml for removed/non-existent files.

EE: true
Changelog: removed

This change removes the remove-github_import_extended_events feature
flag along with all the code that is no longer used.

Changelog: removed

- app/finders/**
- app/graphql/**

- Setting feature category for rack attack tests to :rate_limiting

Changelog: other

- app/controllers/**

Changelog: other

MR: gitlab.com/gitlab-org/gitlab/-/merge_requests/146937
Issue: gitlab.com/gitlab-com/gl-infra/production/-/issues/17480

As part of the cleanup for migration related code, we remove
this internal API

Changelog: changed

Enforce `safe_format` for externalized strings with interpolations and
`.html_safe`.

  # bad
  _('string %{open}foo%{close}').html_safe % { open: '<b>'.html_safe, close: '</b>'.html_safe }
  format(_('string %{open}foo%{close}').html_safe, open: '<b>'.html_safe, close: '</b>'.html_safe)

  # good
  safe_format(_('string %{open}foo%{close}'), tag_pair(tag.b, :open, :close)
  # also good no `html_safe`
  format(_('string %{var} number'), var: var)

Changelog: removed

Gerardo Navarro authored 11 months ago and Ash McKenzie committed 11 months ago

- Removing files from the rubocop todo list

Changelog: other

Leonardo da Rosa authored 11 months ago and Matt Kasa committed 11 months ago

Pre-16.3 migration files were removed and schema
changes moved to db/init_structure.sql file

Changelog: changed