Revert "Merge branch '340800-move-checks-if-import-source-is-enabled-to-service-layer' into 'master'"

This reverts merge request !85262

Changelog: fixed

* rename validate_import!
* add missing tests

* ensure additional safety when creating projects

This is missed because ProjectSetting object is always created, but
without saving it to the database.

  - When migrating projects using GitLab Migration an exception is raised
    NoMethodError undefined method `start_with?` that is caused by
    Projects::CreateService
  - Fix this bug by not scheduling project import in this case

Changelog: fixed

Imre Farkas authored 2 years ago and charlie ablett committed 2 years ago

This will make the fix generally available for owners of personal
projects to have OWNER access level membership.

Changelog: changed

Owners of personal projects are displayed as maintainers in the members
page. This change fixes inconsistency for new projects. It is behind
the personal_project_owner_with_owner_access feature flag.

This reverts commit 63974e4d, reversing
changes made to ab524a54.

Changelog: fixed
Signed-off-by: Rémy Coutable <remy@rymai.me>

Imre Farkas authored 3 years ago and Jan Provaznik committed 3 years ago

Owners of personal projects are displayed as maintainers in the members
page. This change fixes inconsistency for new projects. It is behind
the personal_project_owner_with_owner_access feature flag.

Jeremy Jackson authored 3 years ago and Igor Drozdov committed 3 years ago

This also introduces a new way to configure the readme template on new
project creation which can be used by other services like the
`Projects::CreateService`. It utilizes ERB for customizing the contents
of the readme templates.

Changelog: added

There's a method called `project_namespace` that has nothing
to do with the model nor relationship that we've introduced.
Renaming it to `project_parent` for clarity

Replace `ProjectCreateWorker ` with
`ProjectRecalculateWorker ` to refresh
authorizations upon project creation

This experiment combines the group and project pages together to see if
we can increase the success rate of the "first mile".

part of:
https://gitlab.com/gitlab-org/gitlab/-/issues/285563

rebase conflict resolution

prettier, rubocop

Alan (Maciej) Paruszewski authored 3 years ago and Andy Schoenen committed 3 years ago

Changelog: changed
EE: true

This change uses a new service,
`ProjectRecalculatePerUserService`, to
recalculate the authorizations of a user whenever
they are added/removed/updated in a project.

Changelog: performance

Sashi Kumar Kumaresan authored 3 years ago and Sashi Kumar Kumaresan committed 3 years ago

This change adds a new paramter for security policy
target project in Projects::CreateService to create
Security::OrchestrationPolicyConfiguration associated with the project.

Changelog: added
EE: true

In order to make it easy for an admin to see which project a given
repository belongs to with hashed storages, we always write the
project path (e.g. "gitlab-com/gitlab") into the repo's gitconfig. This
is done via `#write_repository_config()` and `#write_config()`, both of
which only support writing this specific config entry.

Rename both functions to make it clear that they only support writing
the path. Direct access to the gitconfig is going away soon anyway, so
these functions can never be extended to write additional config
entries.

Technical debt maintenance: Removes most of the code for the deprecated
`service templates` feature. The code for the `PropagateServiceTemplateWorker`
and its tests are untouched.

Changelog: other

Remove feature flag `projects_post_creation_worker`

Changelog: other

Renames the general integration initialization and reflection methods
to use the 'integration' terminology.

- This adds an experiment class and moves all inline logic into the
experiment implementation.

- Experiment: new_project_readme_content

- This is designed to test new readme content (english only), and takes
advantage of the more comprehensive concepts around rendering templates
to a repo.

- This pretty much mimics the way that Thor, or more appropriately,
Rails generators renders templates.

Alterative commit title: "Move monitoring integrations to
`Integrations::`" (not chosen because GitLab use commit titles as their
changelog titles, and this is a `Changelog: deprecated` changelog).

This MR namespaces the "monitoring" integrations to the `Integrations::`
namespace as part of
#201855.

As the old `PrometheusService` model was used as a GraphQL GlobalID
argument, it adds a new deprecation to allow backwards-compatibility
with clients who still use the old GlobalID string
(`"gid://gitlab/PrometheusService/<id>"`), or name
(`PrometheusServiceID`), in arguments supplied to the mutations.

#201855
!62645

Changelog: deprecated

Contributes to #26261

Set `default_branch` value as a default branch name for non-empty
repositories.

Changelog: fixed

Changelog: performance

#201848
&2504

Let's rename the method and return `main` when default branch
is not set.

In most cases it shouldn't change the product behavior, but
in the cases when a project is empty `main` will be created
by default instead of `master` if for some action a branch
is required.

This change reduces the number of DB queries when importing a gitlab
project.

Contributes to #20759

This optimization should reduce the number of queries that
Projects::CreateService generates.