Justin Ho Tuan Duong authored 1 year ago and Bob Van Landuyt committed 1 year ago

Changelog: removed

We have to ensure that input which is not conforming the RFC (e.g.
in case email address is truncated) is still obfuscated properly.

Fix Layout/ArgumentAlignment offenses in models

Adds more coverage to shared protected ref access examples
Removes ProtectedRefAccess specs
Adds ee spec coverage for ProtectedBranch access levels

Related to #12776

Luke Duncalfe authored 1 year ago and Thong Kuah committed 1 year ago

This change is part of
#355896 to move all GitLab
for Slack app code to Core.

This MR moves:

- The `slack/trigger` API endpoint
- Related handling code

Previously the alert when a runner is linked to a project used a
"notice" style, this changes the feedback to have a "success" style.

Changelog: changed

Luke Duncalfe authored 1 year ago and Brian Williams committed 1 year ago

This change is part of
#355896 to move all GitLab
for Slack app code to Core.

This MR moves:

- The `integrations/slack/events` and `integrations/slack/interactions`
  API endpoints
- Related handling services and workers

Alex Buijs authored 1 year ago and Miguel Rincon committed 1 year ago

Adds the AbuseReportApp for displaying an Abuse Report

Changelog: added

Fix Layout/ArgumentAlignment offenses in spec/services/app_sec

Fixes the rubocop ambiguous operator violation in the
Namespaces::Storage::RootSize class

Removes the Rubocop todo for a class
(Namespaces::Storage::CliNotification) which was recently removed

Fixes the rubocop strong memoize violation in the
Namespaces::Storage::RootExcessSize class

Fixes the unused block arg rubocop violation in
Namespace::RootStorageStatistics

Relocates the EE::Gitlab::Namespaces::Storage::Enforcement class to live
alongside it's counterparts in `ee/app/models/namespaces/storage`.

This is consistent with the other classes, e.g. `RootSize` and also
similar features such as the FreeUserCap classes.

Removes admin override for
ProtectedBranch push
ProtectedBranch merge
ProtectedBranch unprotect
ProtectedTag create

Related to #12776

Changelog: changed

Tianwen Chen authored 1 year ago and Marius Bobin committed 1 year ago

Changelog: added

This cop ensures that only static strings are passed to gettext
translation methods `_()`, `s_()`, `n_()`, `N_()`.

Any kind of interpolation, formatting, or concatenation is disallowed.

The following definitions are allowed:
* Local variables
* Method calls which are not mentioned above
* Constants

Generate TODOs for pending offenses in Ruby code.

Rémy Coutable authored 1 year ago and David Dieulivol committed 1 year ago

This uses an external source of truth at
https://gitlab-org.gitlab.io/quality/engineering-productivity/fast-quarantine/rspec/fast_quarantine-gitlab.txt


so that we'll be able to quickly & temporarily qurantine problematic
tests without having to open/merge a merge request.

Signed-off-by: Rémy Coutable <remy@rymai.me>

Vijay Hawoldar authored 1 year ago and Rajendra Kadam committed 1 year ago

Ensures the pre-enforcement storage banner will re-display to users 14
days after being dismissed

This reverts commit 1e4b1709, reversing
changes made to 7e409bcb.

The user and group associtations for ProtectedRefAccess classes only
exist in EE so these scopes are invalid in CE. Calling them would raise
errors.

Changelog: removed
EE: true

CreateCrossProjectPipelineWorker has been replaced by CreateDownstreamPipelineWorker
in #11081 and so the former has been
scheduled for removal.

Changelog: deprecated

Fix Layout/ArgumentAlignment offenses in services/notes

Fix Layout/ArgumentAlignment offenses in requests/projects

Dmitry Gruzd authored 1 year ago and John Mason committed 1 year ago

All the wiki_blobs will get migrated to a new separate wiki index.
Any newly created project_wikis will get indexed on this new index.
Project wiki search will happen in the new index.

Changelog: changed
MR: !107365
EE: true

Nikola Milojevic authored 1 year ago and Jon Glassman committed 1 year ago

We are already using Sidekiq Memory Watchdog for several releases by default

Changelog: removed

The import was deprecated 15.8 and is now being removed

Changelog: removed

Fix Layout/ArgumentAlignment in shared_contexts

Fix Layout/ArgumentAlignment offenses in shared_examples/requests