GitLab UI dropdowns don't expose a `popperOptions` prop anymore. It has
been replaced with `dropdownOffset` which only controls the dropdown's
offsets relative to its reference elements. This migrates existing
usages of the deprecated prop to the new one.

Olena Horal-Koretska authored 1 year ago and Paul Gascou-Vaillancourt committed 1 year ago

The failure was expected due to the update
of the categorical data palette

Olena Horal-Koretska authored 1 year ago and Paul Gascou-Vaillancourt committed 1 year ago

As we added the scrim overlay items
which also match the `li` selector
the test was failing. Targeting items with [role="option"]
fixes this issue

Merge branch 'ag/377413-checkout-cannot-modify-payment-method-details-after-submission' into 'master'

Update payment method step edit button text

See merge request !121548



Merged-by: Himanshu Kapoor <info@fleon.org>
Approved-by: Himanshu Kapoor <info@fleon.org>
Approved-by: Minahil Nichols <minahilnichols@gitlab.com>
Co-authored-by: Angelo Gulina <agulina@gitlab.com>

Fix Rubocop offences: ee/application_setting

See merge request !122457



Merged-by: Roy Zwambag <rzwambag@gitlab.com>
Approved-by: Roy Zwambag <rzwambag@gitlab.com>
Co-authored-by: Aleksei Lipniagov <alipniagov@gitlab.com>

Add  view_component's deprecated slot setters to disallowed_warnings

See merge request !120085



Merged-by: Dylan Griffith <dyl.griffith@gmail.com>
Approved-by: Aakriti Gupta <agupta@gitlab.com>
Approved-by: Dylan Griffith <dyl.griffith@gmail.com>
Reviewed-by: Aakriti Gupta <agupta@gitlab.com>
Co-authored-by: Thomas Hutterer <thutterer@gitlab.com>

Update "if-jh" rules

See merge request !121155



Merged-by: Lin Jen-Shin <jen-shin@gitlab.com>
Approved-by: Lin Jen-Shin <jen-shin@gitlab.com>
Approved-by: Kevin Morrison <kmorrison@gitlab.com>
Reviewed-by: Martin Tan <lmtan@jihulab.com>
Co-authored-by: 路小鹿 <1551755561@qq.com>

Labels as a facet - minor visual updates - part 2

See merge request gitlab-org/gitlab!121037



Merged-by: Natalia Tepluhina <ntepluhina@gitlab.com>
Approved-by: Annabel Dunstone Gray <annabel.dunstone@gmail.com>
Approved-by: Stanislav Lashmanov <slashmanov@gitlab.com>
Approved-by: Natalia Tepluhina <ntepluhina@gitlab.com>
Reviewed-by: Natalia Tepluhina <ntepluhina@gitlab.com>
Co-authored-by: Tomas Bulva <tbulva@gitlab.com>

Tomas Bulva authored 1 year ago and Natalia Tepluhina committed 1 year ago

Changelog: changed

Bump gitlab-qa and pipeline-common versions

See merge request !122477



Merged-by: David Dieulivol <ddieulivol@gitlab.com>
Approved-by: David Dieulivol <ddieulivol@gitlab.com>
Approved-by: Chloe Liu <yliu@gitlab.com>
Co-authored-by: Sanad Liaquat (Personal) <sliaquat@gitlab.com>

Cleanup Rubocop todo

See merge request !122608



Merged-by: Ahmed Hemdan <ahemdan@gitlab.com>
Approved-by: Gregory Havenga <11164960-ghavenga@users.noreply.gitlab.com>
Approved-by: Ahmed Hemdan <ahemdan@gitlab.com>
Co-authored-by: Vijay Hawoldar <vhawoldar@gitlab.com>

Fixed issues with rubocop -a.

Display completed training urls

See merge request !122366



Merged-by: David Pisek <dpisek@gitlab.com>
Approved-by: David Pisek <dpisek@gitlab.com>
Approved-by: Lorenz van Herwaarden <lvanherwaarden@gitlab.com>
Co-authored-by: Samantha Ming <sming@gitlab.com>

Samantha Ming authored 1 year ago and David Pisek committed 1 year ago

Issue: #355940

Changelog: changed
EE: true

Improve group issues query for Reporters and above

See merge request !122423



Merged-by: Jarka Košanová <jarka@gitlab.com>
Approved-by: Jarka Košanová <jarka@gitlab.com>
Approved-by: Matt Kasa <mkasa@gitlab.com>
Co-authored-by: Heinrich Lee Yu <heinrich@gitlab.com>

Update gitlab-metrics-exporter version

See merge request !122604



Merged-by: Matthias Käppler <mkaeppler@gitlab.com>
Approved-by: Matthias Käppler <mkaeppler@gitlab.com>
Co-authored-by: Ash McKenzie <amckenzie@gitlab.com>

Created Dependency Scanning tutorial

See merge request !109928



Merged-by: Kati Paizee <kpaizee@gitlab.com>
Approved-by: Kati Paizee <kpaizee@gitlab.com>
Reviewed-by: Mario Mora <mmora@gitlab.com>
Reviewed-by: Kati Paizee <kpaizee@gitlab.com>
Co-authored-by: Russell Dickenson <rdickenson@gitlab.com>
Co-authored-by: Lyn Landon <llandon@gitlab.com>

Improve test suite performance

See merge request !121854



Merged-by: John Mason <9717668-john-mason@users.noreply.gitlab.com>
Approved-by: Jay McCure <jmccure@gitlab.com>
Approved-by: John Mason <9717668-john-mason@users.noreply.gitlab.com>
Co-authored-by: Vasilii Iakliushin <viakliushin@gitlab.com>

Remove yarn-audit Dependency Scanning

See merge request !122372



Merged-by: David Dieulivol <ddieulivol@gitlab.com>
Approved-by: Philippe Lafoucrière <30915-plafoucriere@users.noreply.gitlab.com>
Approved-by: David Dieulivol <ddieulivol@gitlab.com>
Co-authored-by: Olivier Gonzalez <52092-gonzoyumo@users.noreply.gitlab.com>

Merge branch 'bdenkovych-gitlab-admin-should-bypass-group-sso-enforcement-issue-413568' into 'master'

GitLab Admins should bypass Group SSO enforcement

See merge request !122169



Merged-by: Mikołaj Wawrzyniak <mwawrzyniak@gitlab.com>
Approved-by: Drew Blessing <drew@gitlab.com>
Approved-by: Kevin Morrison <kmorrison@gitlab.com>
Co-authored-by: Bogdan Denkovych <bdenkovych@gitlab.com>

Tidy up codeowners E2E use Commit over ProjectPush

See merge request !122392



Merged-by: Andrejs Cunskis <acunskis@gitlab.com>
Approved-by: Harsha Muralidhar <hmuralidhar@gitlab.com>
Approved-by: Andrejs Cunskis <acunskis@gitlab.com>
Co-authored-by: John McDonnell <jmcdonnell@gitlab.com>

Removes a argument alignment rubocop todo for a file/class that no
longer exists

[Audit Events] Provide all audit events under a group via the API

See merge request gitlab-org/gitlab!115898



Merged-by: Adam Hegyi <ahegyi@gitlab.com>
Approved-by: Adam Hegyi <ahegyi@gitlab.com>
Approved-by: Aaron Huntsman <ahuntsman@gitlab.com>
Reviewed-by: Jarka Košanová <jarka@gitlab.com>
Reviewed-by: Evan Read <eread@gitlab.com>
Reviewed-by: Sincheol (David) Kim <dkim@gitlab.com>
Co-authored-by: Michael Becker <11881043-wandering_person@users.noreply.gitlab.com>
Co-authored-by: Evan Read <eread@gitlab.com>

Michael Becker authored 1 year ago and Adam Hegyi committed 1 year ago

Background Context
------------------------

We want to be able to return all audit events under a given groups via
a single endpoint. We have an issue, [_API endpoint to retrieve all
audit events under a given group_][0], to track this feature.

We actually had already implemented that feature, but the performance
was so poor in production that it functionally did not work. The
database query timed out almost 100% of the time.

The proposal was to improve the existing query's performance by using
the [`InOperatorOptimization`][1] library.

Attempts to do this did not show a good performance boost (details
[here][2])

Another Approach
----------------

We then thought about implementing this feature with a new
approach. The Idea is that we can add a new column, `group_rollup`, to
the `audit_events` table. This column will be the `id` of the
top-level group the audit event belongs to.

We could then update the Auditor to write this value at audit event
creation, allowing us to implement the endpoint with a simple query:

```sql
SELECT *
FROM "audit_events"
WHERE "audit_events"."group_rollup_id" == @group.id
```

This query performed much better in database lab (details in this
[spike issue][3])

Back to InOperatorOptimization
---------------------------------
In the MR for the `group_rollup_id` approach, it was discovered that
with some tweaking and adding a new index, the InOperatorOptimization
might just work

So this commit adds the application code for that approach.

The index additions are tracked in these issues:

- [asynchronous database index addition][4]
- [synchronous database index addition][5]

[0]:#337757
[1]:https://docs.gitlab.com/ee/development/database/efficient_in_operator_queries.html
[2]:#337757 (comment 1312002908)
[3]:#396778 (comment 1325762680)
[4]:#411167
[5]:#411129

Changelog: changed
EE: true

Update file details for project access token limits in Trials

See merge request !122486



Merged-by: Jon Glassman <jglassman@gitlab.com>
Approved-by: Andrew Kelly <akelly@gitlab.com>
Approved-by: Jon Glassman <jglassman@gitlab.com>
Co-authored-by: Tim Poffenbarger <tpoffenbarger@gitlab.com>

Add single-redis jobs to coverage dependency

See merge request !122421



Merged-by: David Dieulivol <ddieulivol@gitlab.com>
Approved-by: David Dieulivol <ddieulivol@gitlab.com>
Approved-by: Michael Becker <11881043-wandering_person@users.noreply.gitlab.com>
Reviewed-by: Michael Becker <11881043-wandering_person@users.noreply.gitlab.com>
Co-authored-by: Sylvester Chin <schin@gitlab.com>

Add Background Migration to Backfill Root Storage Statistics Fork Sizes

See merge request !120916



Merged-by: Suraj Tripathi <stripathi@gitlab.com>
Approved-by: Suraj Tripathi <stripathi@gitlab.com>
Reviewed-by: Krasimir Angelov <kangelov@gitlab.com>
Reviewed-by: Vijay Hawoldar <vhawoldar@gitlab.com>
Co-authored-by: Jason Goodman <jgoodman@gitlab.com>

Jason Goodman authored 1 year ago and Suraj Tripathi committed 1 year ago

Backfill the following columns for namespace_root_storage_statistics:
 - public_forks_storage_size
 - internal_forks_storage_size
 - private_forks_storage_size

Changelog: added