- Feb 08, 2023
-
-
Andreas Deicha authored
Changelog: added
-
- Nov 13, 2022
-
- Nov 09, 2022
-
-
Stan Hu authored
This is a follow-up merge request to !98010, which enabled job artifacts to be served by Google Cloud CDN for specific API endpoints. This extends this functionality to artifact downloads from the Web UI via the `Download` artifact button. This functionality is behind the `use_cdn_with_job_artifacts_ui_downloads` feature flag. This feature should not only make artifacts downloads faster for users, but it also helps reduce network egress bandwidth costs. Since UI downloads can have `response-content-disposition` and `response-content-type` query parameters, we also need to modify the Cloud CDN implementation to allow passing of query parameters to Google Cloud Storage. Note that Cloud CDN requires that the `Expires`, `KeyName`, and `Signature` query parameters appear at the end of the URL, or the request will fail with a 403 error. Relates to #378473 Changelog: added
-
- May 06, 2022
-
-
Kamil Trzciński authored
This removes all `default_enabled: :yaml | true | false`
-
- Nov 06, 2020
-
-
Aleksei Lipniagov authored
We controlled the Image Resizing feature with two separate FFs. We want to have a separate Feature Flags with an ops type. Also, we want this flag to be enabled by default.
-
- Sep 04, 2020
-
-
- Aug 31, 2020
-
-
- Aug 26, 2020
-
-
Matthias Käppler authored
This is to constraint this experimental feature more for now and acts as an additional safety check. We decided it's OK to rely on just the filename extension for now, since we're already checking file contents during upload.
-
- Aug 10, 2020
-
-
This will create a workhorse instruction to trigger an image download + resize on-the-fly.
-
- Jan 29, 2020
-
-
Removes patches that are already in Rails 6: Gitlab::ContentDisposition patch ActiveRecord::QueryCache patch ActiveJob::Arguments patch Gitlab::ActionViewOutput patch Updates Activerecord::Locking::Optimistic patch to follow changes in https://github.com/rails/rails/blob/v6.0.1/activerecord/lib/active_record/locking/optimistic.rb Fix missing timezone for datetime_with_timezone by adding this custom type to ActiveRecord's time_zone_aware_attributes
-
- Feb 13, 2019
-
-
Stan Hu authored
Due to a regression in https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/24919, Content-Disposition is hard-coded to `attachment` instead of `inline`. We now use the argument `disposition` to fix that problem. Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/57660
-
- Feb 05, 2019
-
-
Stan Hu authored
Users downloading non-ASCII attachments would see garbled characters. When used with object storage, AWS S3 would return an InvalidArgument error: Header value cannot be represented using ISO-8859-1. Per RFC 5987 and RFC 6266, Content-Disposition should be encoded properly. This commit takes the Rails 6 implementation of ActiveSuppport::Http::ContentDisposition (https://github.com/rails/rails/pull/33829) and ports it here. Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/47673
-
- Nov 07, 2018
-
-
Kamil Trzciński authored
This makes to always proxy reports
-
Kamil Trzciński authored
This makes to always proxy reports
-
- Sep 19, 2018
-
-
gfyoung authored
Enables frozen string for the following: * app/controllers/*.rb * app/controllers/admin/**/*.rb * app/controllers/boards/**/*.rb * app/controllers/ci/**/*.rb * app/controllers/concerns/**/*.rb Partially addresses #47424.
-
gfyoung authored
Enables frozen string for the following: * app/controllers/*.rb * app/controllers/admin/**/*.rb * app/controllers/boards/**/*.rb * app/controllers/ci/**/*.rb * app/controllers/concerns/**/*.rb Partially addresses #47424.
-
- Sep 06, 2018
-
-
Stan Hu authored
There were several issues: 1. With Google Cloud Storage, we can't override the Content-Type with Response-Content-Type once it is set. Setting the value to `application/octet-stream` doesn't buy us anything. GCS defaults to `application/octet-stream`, and AWS uses `binary/octet-stream`. Just remove this `Content-Type` when we upload new files. 2. CarrierWave and fog-google need to support query parameters: https://github.com/fog/fog-google/pull/409/files, https://github.com/carrierwaveuploader/carrierwave/pull/2332/files. CarrierWave has been monkey-patched until an official release. 3. Workhorse also needs to remove the Content-Type header in the request (https://gitlab.com/gitlab-org/gitlab-workhorse/blob/ef80978ff89e628c8eeb66556720e30587d3deb6/internal/objectstore/object.go#L66), or we'll get a 403 error when uploading due to signed URLs not matching the headers. Upgrading to Workhorse 6.1.0 for gitlab-workhorse!297 will make Workhorse use the headers that are used by Rails. Closes #49957
-
- May 14, 2018
-
-
Stan Hu authored
If you upload a file with a .js extension, Rails' cross-origin JavaScript protection will prevent a user from downloading the file with a 422 error. Setting the content-type to `text/plain` will allow the user to download the file as a plaintext file. Closes #45826
-
- Mar 22, 2018
-
-
Micaël Bergeron authored
-
- Mar 09, 2018
-
-
Micaël Bergeron authored
-
- Mar 08, 2018
-
-
Micaël Bergeron authored
-
- Mar 07, 2018
-
-
Kamil Trzciński authored
-
- Nov 21, 2017
-
-
Dmytro Zaporozhets (DZ) authored
Signed-off-by:
Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
-
- Sep 07, 2017
-
-
James Edwards-Jones authored
-