All other type of note event payloads had a url in them
except for snippet.

Changelog: added

Previously, we had to check if user is present before passing it to
Group#member? because it'd fail due to the EE override.

This commit handles the case where user is nil and returns false.

The previous nil checks are not no longer necessary.

The default_value_for is not regularly maintained, so let's
gradually remove the usages and finally the gem

and remove version in `helpers/markup_helper`

Igor Drozdov authored 2 years ago and GitLab Release Tools Bot committed 2 years ago

Merge branch 'security-id-snippets-description-validation' into 'master'

See merge request gitlab-org/security/gitlab!2669

Changelog: security

The spamcheck service has been updated with a new
model to detect spam in snippets. This MR updates
the Snippet create/update functionality to check
for spam using the newly available gRPC endpoint in
spamcheck.

Changelog: added

Thiago Figueiró authored 2 years ago and Nikola Milojevic committed 2 years ago

In app/models

Bogdan Denkovych authored 2 years ago and GitLab Release Tools Bot committed 2 years ago

Merge branch 'security-maintainer-can-change-the-visibility-of-project-and-group' into 'master'

See merge request gitlab-org/security/gitlab!2591

Changelog: security

phaneendra marisa authored 2 years ago and Tetiana Chupryna committed 2 years ago

Changelog: changed

In a future commit we will be calling #resource_parent on an object we
don't know the exact type of. But all of them respond to that method,
except for Snippet. With this change we can safely call it without
getting a NoMethodError.

Since create_repository_if_exists takes a default_branch argument, use
that in the initial call to create the repository rather than changing
it after the fact. This avoids potential racy calls to WriteRef, as well
as saves a roundtrip to Gitaly.

Changelog: changed

Currently when rails wants to ensure a default branch name, it will call
the Gitaly WriteRef RPC to manually change it. If this call happens in a
racy way eg: it gets called when another RPC is operating on the same
repository, it will fail. Rather than do this, the Gitaly
CreateRepository RPC has a default_branch parameter.

Allow rails callers to set this value. If it is not provided, then the
default branch in Gitaly will be used, which is main.

Chad Woolley authored 3 years ago and GitLab Release Tools Bot committed 3 years ago

Merge branch 'security-snippets-warn-unretrievable-files' into 'master'

See merge request gitlab-org/security/gitlab!2187

Changelog: security

When an issue or some other issauble is updated, we previously would
check whether the original author was the support bot instead of the
user who updated this issue. As a result, the spam check would be
triggered unnecessarily and causing spam logs to be attributed to the
support bot.

Relates to https://gitlab.com/gitlab-org/gitlab/-/issues/335971

Changelog: fixed

As we migrate from master to main, let's rename the branch in
views as well

Extract the main over master logic into a separate module
This module can be removed when the migration is over

Shubham Kumar authored 3 years ago and Heinrich Lee Yu committed 3 years ago

Fixes auto correct rubocop offenses

In this commit we move some snippet related classes to the
`Snippets` namespace. This is an effort to have everything
in the codebase aligned.

Snippets Vue code, doesn't expect to receive any nil blob,
and it doesn't make sense to have it. In this commit, we
remove nil values from the list.

In this commit remove the pick_repository_storage method
from repository containers and, instead, we created its own
method in the `Repository` class.

When a new snippet repository is created, the ref inside
HEAD is `master` even when the default branch is different.

This also happens with projects and wikis. These resources fix
this by explicitly rewrite the HEAD reference and we're applying
the same behavior to snippets.

When the repository is pushed or pulled we update the reference
inside the HEAD file.

This new class will store the repository storage
changes for snippets.

We're going to allow snippets to move the repository storage of
their repositories (and later with group wikiws). For this, we
need to reuse some of the existent functionality in projects.

Therefore, the best way to do it is to extract it into a concern
and include it in snippets.

Move user mentions saving as a callback on models that save related
markdown field cache(_html)

We originally added this out of concern that the `snippets` component
in the path could clash with groups or projects named `snippets`, which
we allow for projects and child groups, and only forbid for toplevel
groups.

But we already use the path without '@' for SSH/HTTP clone URLs, and
also include the snippet ID, so this change should be unlikely to cause
problems in practice.

This also makes snippets more consistent with the other `HasRepository`
classes, and allows us to remove some special handling for snippets.

The feature flag :additional_repo_storage_by_namespace check in
EE::Gitlab::RepositorySizeChecker was done globally. Now it will check
if it's enabled for the given namespace.

Add storage enforcement based on purchased excess storage. This logic is
behind a feature flag.

Francisco Javier López authored 4 years ago and Paul Slaughter committed 4 years ago

Removing the FF snippet_multiple_files and releasing
snippet with multiples files.

Markus Koller authored 4 years ago and Francisco Javier López committed 4 years ago

Also add a `Snippet.default_branch` helper with a fallback to the
currently hardcoded 'master'.

Moves default "current" repository access to GlRepository rather than in
each specific container.