Fix participants detection for system notes

See merge request !120883



Merged-by: Doug Stull <dstull@gitlab.com>
Approved-by: Doug Stull <dstull@gitlab.com>
Approved-by: Eugenia Grieff <egrieff@gitlab.com>
Reviewed-by: Vasilii Iakliushin <viakliushin@gitlab.com>
Reviewed-by: Doug Stull <dstull@gitlab.com>
Reviewed-by: Eugenia Grieff <egrieff@gitlab.com>
Co-authored-by: Vasilii Iakliushin <viakliushin@gitlab.com>

Vasilii Iakliushin authored 1 year ago and Doug Stull committed 1 year ago

Contributes to #409006

**Problem**

Previously we implemented an optimization to improve the performance of
participants detection.

Merge request:
!98116

Instead of checking permissions for each element on the page, we started
checking permissons for issuable object (issue, merge request, epic).

However, this approach doesn't work well for system notes. System note
requires a permission check on Note object itself. Checking it on
issuable will skip the verification for system note content.

**Solution**

Fallback to verifying permissions for system notes on Note objects.

Changelog: fixed

Update file vs_code_debugging.md

See merge request !121249



Merged-by: Amy Qualls <aqualls@gitlab.com>
Approved-by: Jon Glassman <jglassman@gitlab.com>
Approved-by: Tomas Vik <tvik@gitlab.com>
Co-authored-by: Jon Glassman <jglassman@gitlab.com>
Co-authored-by: Jayson Salazar <jsalazar@gitlab.com>

Jayson Salazar Rodriguez authored 1 year ago and Amy Qualls committed 1 year ago

- /doc/development/vs_code_debugging.md
- /doc/development/vscode_debugging.md
- /doc/development/feature_development.md

Add missing audit event schema

See merge request gitlab-org/gitlab!121201



Merged-by: Gary Holtz <gholtz@gitlab.com>
Approved-by: Gary Holtz <gholtz@gitlab.com>
Approved-by: Harsimar Sandhu <hsandhu@gitlab.com>
Co-authored-by: nrosandich <nrosandich@gitlab.com>

CTRT - Refine content on Environment-specific CI/CD variables

See merge request !114540



Merged-by: Phillip Wells <pwells@gitlab.com>
Reviewed-by: Shinya Maeda <shinya@gitlab.com>
Co-authored-by: Russell Dickenson <rdickenson@gitlab.com>

Migrate usage CiRunner.active to CiRunner.paused

See merge request !120878



Merged-by: Enrique Alcántara <ealcantara@gitlab.com>
Approved-by: Enrique Alcántara <ealcantara@gitlab.com>
Reviewed-by: Laura Meckley <lmeckley@gitlab.com>
Co-authored-by: Miguel Rincon <mrincon@gitlab.com>

Miguel Rincon authored 1 year ago and Enrique Alcántara committed 1 year ago

The "paused" field is preferred to "active" in the CiRunner GraphQL API
since 14.8, this change updates our queries to use it.

Added Code Suggestions Beta Alert

See merge request !121282



Merged-by: Doug Stull <dstull@gitlab.com>
Approved-by: Doug Stull <dstull@gitlab.com>
Approved-by: Mike Nichols <mnichols@gitlab.com>
Approved-by: Serhii Yarynovskyi <syarynovskyi@gitlab.com>
Reviewed-by: Phil Hughes <me@iamphill.com>
Reviewed-by: Doug Stull <dstull@gitlab.com>
Co-authored-by: Ross Byrne <robyrne@gitlab.com>
Co-authored-by: rliu-int <rliu-int@gitlab.com>

Ross Byrne authored 1 year ago and Doug Stull committed 1 year ago

behind feature flag so no changelog

Fix trial and company form jumping on resize

See merge request !121084



Merged-by: Olena Horal-Koretska <ohoralkoretska@gitlab.com>
Approved-by: Olena Horal-Koretska <ohoralkoretska@gitlab.com>
Approved-by: Gina Doyle <gdoyle@gitlab.com>
Approved-by: Alex Pennells <apennells@gitlab.com>
Reviewed-by: Doug Stull <dstull@gitlab.com>
Co-authored-by: Doug Stull <dstull@gitlab.com>

Doug Stull authored 1 year ago and Olena Horal-Koretska committed 1 year ago

- ui polish

Changed: other
EE: true

Defers loading of package assets on package details page

See merge request !120828



Merged-by: Jose Ivan Vargas <jvargas@gitlab.com>
Approved-by: Jose Ivan Vargas <jvargas@gitlab.com>
Approved-by: Alex Fracazo <afracazo@gitlab.com>
Approved-by: Tomas Bulva <tbulva@gitlab.com>
Reviewed-by: Jose Ivan Vargas <jvargas@gitlab.com>
Reviewed-by: Tomas Bulva <tbulva@gitlab.com>
Co-authored-by: Rahul Chanila <rchanila@gitlab.com>

Rahul Chanila authored 1 year ago and Jose Ivan Vargas committed 1 year ago

Changelog: changed

Merge branch '390887-update-the-jira_issue_key_regex-to-conform-to-the-jira-issue-key-default-format' into 'master'

Fix the Jira issue key default format

See merge request gitlab-org/gitlab!120995



Merged-by: Kerri Miller <kerrizor@kerrizor.com>
Approved-by: Kerri Miller <kerrizor@kerrizor.com>
Approved-by: Joseph Wambua <jjoshua@gitlab.com>
Co-authored-by: bmarjanovic <bmarjanovic@gitlab.com>

Quarantine three flaky examples

See merge request !121421



Merged-by: Marc Shaw <mshaw@gitlab.com>
Approved-by: Joseph Wambua <jjoshua@gitlab.com>
Approved-by: Marc Shaw <mshaw@gitlab.com>
Co-authored-by: Rémy Coutable <remy@rymai.me>

Log when deprecated Jira DVCS endpoints are hit

See merge request gitlab-org/gitlab!121095



Merged-by: Tetiana Chupryna <tchupryna@gitlab.com>
Approved-by: Tetiana Chupryna <tchupryna@gitlab.com>
Approved-by: Carla Drago <cdrago@gitlab.com>
Co-authored-by: Luke Duncalfe <lduncalfe@eml.cc>

Luke Duncalfe authored 1 year ago and Tetiana Chupryna committed 1 year ago

This will allow us to gather data about who is using the endpoints.

Revise protected-branch entitlement for clarity

See merge request gitlab-org/gitlab!121283



Merged-by: Phillip Wells <pwells@gitlab.com>
Approved-by: Phillip Wells <pwells@gitlab.com>
Co-authored-by: Amy Qualls <aqualls@gitlab.com>

Amy Qualls authored 1 year ago and Phillip Wells committed 1 year ago

Reverse the order to make a little clearer what version is available
to everyone, and what version is available to higher tiers. Also,
clarify that two particular fields have more selection available to
higher tiers.

Adding JobKind: BUILD to failed jobs query

See merge request !120652



Merged-by: Jose Ivan Vargas <jvargas@gitlab.com>
Approved-by: Payton Burdette <pburdette@gitlab.com>
Approved-by: Jose Ivan Vargas <jvargas@gitlab.com>
Co-authored-by: Max Fan <mfan@gitlab.com>

Protect metric services via firewall when exposing them

See merge request !119577



Merged-by: Achilleas Pipinellis <axil@gitlab.com>
Reviewed-by: Achilleas Pipinellis <axil@gitlab.com>
Co-authored-by: Anton Smith <asmith@gitlab.com>

Adds a deploy collection for groups and projects

See merge request !120860



Merged-by: John Mason <9717668-john-mason@users.noreply.gitlab.com>
Approved-by: John Mason <9717668-john-mason@users.noreply.gitlab.com>
Approved-by: Thomas Hutterer <thutterer@gitlab.com>
Reviewed-by: Sam Beckham <sbeckham@gitlab.com>
Co-authored-by: Sam Beckham <sbeckham@gitlab.com>

Sam Beckham authored 1 year ago and John Mason committed 1 year ago

Moves package registry to the new menu

Update code suggestions documentation

See merge request !121435



Merged-by: Stan Hu <stanhu@gmail.com>
Approved-by: Stan Hu <stanhu@gmail.com>
Approved-by: Suzanne Selhorn <sselhorn@gitlab.com>
Approved-by: Michelle Gill <mgill@gitlab.com>
Co-authored-by: Suzanne Selhorn <sselhorn@gitlab.com>
Co-authored-by: Wayne Haber <whaber@gitlab.com>
Co-authored-by: Michelle Gill <mgill@gitlab.com>

Persist gists import failures

See merge request !120346



Merged-by: Ahmed Hemdan <ahemdan@gitlab.com>
Approved-by: Ahmed Hemdan <ahemdan@gitlab.com>
Approved-by: Tianwen Chen <tchen@gitlab.com>
Approved-by: Gregory Havenga <11164960-ghavenga@users.noreply.gitlab.com>
Reviewed-by: Adam Hegyi <ahegyi@gitlab.com>
Reviewed-by: Mehmet Emin INAC <minac@gitlab.com>
Reviewed-by: Ahmed Hemdan <ahemdan@gitlab.com>
Reviewed-by: Tianwen Chen <tchen@gitlab.com>
Co-authored-by: cervols <paprikamail@gmail.com>

Tetiana Zavediuk authored 1 year ago and Ahmed Hemdan committed 1 year ago

If a gist fails to be imported we will save the failure to the database
in order to present any failed imports back to the user.

Details: #384173

Changelog: added

Ignore jitsu_key when snowplow support is enabled

See merge request !120957



Merged-by: John Mason <9717668-john-mason@users.noreply.gitlab.com>
Approved-by: John Mason <9717668-john-mason@users.noreply.gitlab.com>
Approved-by: Halil Coban <hcoban@gitlab.com>
Reviewed-by: Halil Coban <hcoban@gitlab.com>
Co-authored-by: Elwyn Benson <ebenson@gitlab.com>

Elwyn Benson authored 1 year ago and John Mason committed 1 year ago

After updating mock data json to snowplow specific keys, the test case
for jitsu failed.

What's new content for 16.0

See merge request !121413



Merged-by: Brian Williams <bwilliams@gitlab.com>
Approved-by: Brian Williams <bwilliams@gitlab.com>
Co-authored-by: Kai Armstrong <karmstrong@gitlab.com>

Allow escaping code block

See merge request !121314



Merged-by: Enrique Alcántara <ealcantara@gitlab.com>
Approved-by: Amelia Bauerly <abauerly@gitlab.com>
Approved-by: Enrique Alcántara <ealcantara@gitlab.com>
Co-authored-by: Himanshu Kapoor <hkapoor@gitlab.com>

Update docs to link project and admin text

See merge request !121364



Merged-by: Amy Qualls <aqualls@gitlab.com>
Approved-by: Amy Qualls <aqualls@gitlab.com>
Co-authored-by: Michael Le <mle@gitlab.com>

Document changelog creation via GitLab CLI

See merge request !121279



Merged-by: Phillip Wells <pwells@gitlab.com>
Approved-by: Phillip Wells <pwells@gitlab.com>
Approved-by: Gary Holtz <gholtz@gitlab.com>
Co-authored-by: Amy Qualls <aqualls@gitlab.com>

Amy Qualls authored 1 year ago and Phillip Wells committed 1 year ago

Adjust H2 and H3 for subsections. Rename a subheading to make
clearer what it's about, and bump it down to the bottom of the page
because it's more of an edge case.

Add "locked" field to create runner form

See merge request !121250



Merged-by: Anna Vovchenko <avovchenko@gitlab.com>
Approved-by: Anna Vovchenko <avovchenko@gitlab.com>
Approved-by: Matthew Nearents <mnearents@gitlab.com>
Approved-by: Diana Zubova <dzubova@gitlab.com>
Approved-by: Sashi Kumar Kumaresan <skumar@gitlab.com>
Reviewed-by: Pedro Pombeiro <noreply@pedro.pombei.ro>
Co-authored-by: Miguel Rincon <mrincon@gitlab.com>

Merge branch '408682-migrate-glfilteredsearch-to-use-terms-as-tokens-in-app-assets-javascripts-analytics' into 'master'

Enable "terms-as-tokens" prop on filter bar in Plan Analytics pages

See merge request !121170



Merged-by: Anna Vovchenko <avovchenko@gitlab.com>
Approved-by: Anna Vovchenko <avovchenko@gitlab.com>
Approved-by: Sharmad Nachnolkar <snachnolkar@gitlab.com>
Co-authored-by: Rudy Crespo <rcrespo@gitlab.com>