Skip to content
Snippets Groups Projects
  1. Jan 20, 2022
  2. Oct 12, 2021
  3. Jul 07, 2021
  4. Feb 01, 2021
  5. Nov 18, 2020
  6. Aug 28, 2020
  7. Aug 26, 2020
  8. Jun 10, 2020
  9. Jun 09, 2020
  10. Apr 27, 2020
    • Vitaly Slobodin's avatar
      [EE] Prefer toHaveLength in Jest · b0c1c349
      Vitaly Slobodin authored
      'toHaveLength' is preferred over other expect functions.
      It gives more clear messages and prepares our codebase for
      recommended style rules for Jest.
      b0c1c349
  11. Jan 16, 2020
  12. Jan 10, 2020
    • Illya Klymov's avatar
      Remove { sync: false } · f745fbbd
      Illya Klymov authored
      This commit removes { sync: false } accross entire codebase
      This is useless since upgrade to @vue/test-utils 1.0.0.beta-30
      f745fbbd
  13. Jan 09, 2020
  14. Jan 08, 2020
  15. Jan 02, 2020
  16. Dec 20, 2019
    • Enrique Alcántara's avatar
      Mock gitlab-ui tooltip directive and component · 06bd4dbd
      Enrique Alcántara authored and Martin Wortschack's avatar Martin Wortschack committed
      gitlab-ui tooltip component is based on bootstrap-vue tooltip
      component. Starting with bootstrap-vue 2.0, testing Vue components
      that use BV tooltip requires to attach the component under test to the
      document object using vue-test-utils attachToDocument mounting option.
      It also requires setting the `sync` option to true.
      
      This change affected a significant amount of unit tests in GitLab
      codebase. These effects impede GitLab from upgrading to
      bootstrap-vue 2.0. To address this problem we first attempted to fix
      all the affected tests. The list is broken tests is located in
      !18913.
      
      Over time, more tests appeared broken as they were using the tooltip
      directive too. The goal to fix broken tests became a moving target,
      so we desisted. This new approach mocks the tooltip directive and
      tooltip component to decouple the unit tests from the bootstrap-vue
      dependency.
      06bd4dbd
  17. Dec 11, 2019
  18. Dec 05, 2019
Loading