This reverts merge request !81833

Francisco Javier López authored 2 years ago and Aleksei Lipniagov committed 2 years ago

In this commit we're introducing a new way of registering markups
to the Wiki. This way, introducing new ones or handling the
existing ones is easier.

David O'Regan authored 2 years ago and Luke Duncalfe committed 2 years ago

Remove the wiki_front_matter
Feature flag to add
the feature by default.

Changelog: added

Fix and enable `Layout/EmptyLinesAroundAttributeAccessor`

In this commit we allow wiki pages to be empty (mostly removing
the validation in the backend).

This aligns the existing behavior because users can push
wiki empty pages through git and that will trigger an error
because of the existing validator.

Changelog: changed

Zeger-Jan van de Weg authored 3 years ago and Bob Van Landuyt committed 3 years ago

The wiki interface to the Git data leverages the Wiki Service in Gitaly.
This service uses LibGit2, and the Ruby sidecar. As such there's a
maintainance burden to the Wiki RPCs.

This change changes the Gitaly RPC that the `Wiki#versions` call uses to
FinddAllCommits. This RPC uses Git itself, and as such will allow the
remove of the PageVersions RPC on the Gitaly side in the next release.

Furthermore, it's expected that this change resolves other bugs too, for
example: #330295 (comment 572087692)
In this instance, `git-fsck(1)` can inflate a ZLib'ed Git object, where
Libgit2 for some reason fails. While I don't yet know why Libgit2 fails,
leveraging the same implementation as `git-fsck(1)` should resolve it.

Changelog: changed

- decouple messaging from error
- update tests

Replaces `WikiPage.group_by_directory` with `WikiDirectory.group_pages`,
which groups the pages recursively by their path.

The views were already set up for recursive partials, so we only had
to change them to show the basename of each directory, rather than
their full path. This is done through a new `WikiDirectory#title`
helper.

This new validation didn't work correctly yet because of two reasons:

- When loading the wiki page in the `#update` controller action, the
  content in `attributes[:content]` won't be initialized which causes
  `content_changed?` to return true. Our factory on the other hand
  sets `attributes[:content]` as part of its initialization.

  We can fix this by using `raw_content` instead in `content_changed?`,
  and verify this in the specs by reloading the existing page from the
  wiki.

- Gollum converts CRLF line endings ("\r\n") to LFs ("\n"), so we also
  need to do this conversion in `WikiPage#content_changed?`.

Alex Kalderimis authored 4 years ago and Adam Hegyi committed 4 years ago

Adds a new columns on events (fingerprint) and an index
on fingerprint and target_type

Markus Koller authored 4 years ago and Imre Farkas committed 4 years ago

This adds a new validation to restrict the maximum size of a wiki page,
which is only enforced when the content is updated, and only when using
the GitLab UI or API (not for Git pushes yet).

The default limit is 50MB, and can be changed through the Rails console
or the API.

Introduces a new `diff` action on the wiki controllers which shows
the diff for the selected file and commit.

- Add `Gitlab::Diff::FileCollection::WikiPage`.
- Override diff helpers in wiki controller.
- Unify wiki views:
  - Always use limited container width.
  - Always add breadcrumbs for wiki page path.
  - Show sidebar in diff view.
  - Align title in diff view with history view.
  - Add helpers for wiki page headers.

Markus Koller authored 4 years ago and Igor Drozdov committed 4 years ago

- Add generic `wiki_path` / `wiki_page_path` helpers.
- Move views into `app/views/shared`.
- Move JS assets into `app/assets/javascripts/pages/shared`.
- Refer to `@wiki` instead of `@Project` in views.
- Use constants on `Wiki` instead of `ProjectWiki`.

Luke Duncalfe authored 4 years ago and Mayra Cabrera committed 4 years ago

A page's `title` will be returned from Gollum/Gitaly with any +<>
characters changed to -, whereas the `path` preserves these characters.

Previously, if a title had one of these characters in it, this method
would inaccurately return true, as we would be comparing `my+page` with
`my page` (after unhyphenization).

#218230

This makes the assumption that a page is valid an error condition, and
moves a long chain of accessors to the page model.

This is preferred over using instance variables, to avoid e.g. typos.

- Refactor existing `ProjectWiki` into `Wiki`, and add new child classes
  `ProjectWiki` and `GroupWiki`.
- Rename `project` to `container` in the wiki classes.
- Add `HasWiki` concern for use in `Project` and `Group`.
- Add `@groups` prefix in `Storage::Hashed`.
- Refactor existing specs into shared examples.

This adds wiki page front-matter parsing library code, behind a
feature flag. The parser abstracts front-matter recognition and
extraction and explanation of failure.

The WikiPage model is provided with a new attribute `front_matter`,
which is derived from the content. This attribute can be updated and
serialized to the wiki-page repository.

The feature flag is gated on a project-by-project basis.

Front-matter parsing is unified across concerns, by
re-using our existing front-matter parsing Regexp in the new
front-matter parser, to ensure consistency.

A new module, `Gitlab::WikiPages` is used by model and library code.

`parse_string` is made a separate method so that different languages can
be supported without modifying other code.

this was only ever needed in tests, and having it on the actual
wiki-page model is just incurring technical debt and installing a
permanent footgun. It is removed and replaced with factories.

This also refactors the event spec to be much more declarative for
visibility tests.

Adds wiki page slug model:

A slug represents a historical set of slugs that identify wiki pages. At
most one can be canonical at any one time, per page.

Adds wiki page meta model:

The wiki page metadata model contains the current title, and has access
to a collection of slugs, at most one of which may be canonical at any
one point (all others are historic).

Rather than polluting the model namespace, and to clarify the meaning of
the class names, these classes are placed under the `WikiPage`
namespace.

Adds adds wiki page meta/spec factories with sequences for use in the
specs, guaranteeing unique titles and slugs

Exposes `@user` as `user`, so that the current page author can be
identified.

Change equality to match other DB objects: pages with equal slugs are
equal.

If a wiki page is inside a directory with spaces, the change detection
didn't account for hyphenated spaces and mistakenly assumed the title
was changed when it wasn't, causing a validation error.

This also fixes the specs to catch this case.

- Add specs for handling of special characters.
- Fix `title_changed?` for all cases.
- Remove redundant `persisted` argument.
- Don't unescape title returned by gollum, it's not escaped anymore now.

Since the directory names can get very long and break the layout if they
don't contain spaces, we tweak the `form_errors` helper to optionally
truncate some error messages.

Many common file systems have a limit of 255 bytes for file and
directory names, and while Git and GitLab both support paths exceeding
those limits, the presence of them makes it impossible for users on
those file systems to checkout a wiki repository locally.

To avoid this situation, we enforce these limits when editing pages
through the GitLab web interface and API:

- 245 bytes for page titles (reserving 10 bytes for the file extension)
- 255 bytes for directory names

Link ActiveModel Blob classes to policy

This RPC has gone unused as far as I can see, so I'm removing it to
decrease the API surface for Gitaly.

This reverts commit d8fafdf5.

Alex Kalderimis authored 5 years ago and Douglas Barbosa Alexandre committed 5 years ago

This uses an intermediate index to transform the function from `O(n^2)`
to `O(n.logn)`, which will be very important for large wikis with lots
of directories, which is definitely something we want to support.

Previously, when the wiki page format was anything other than `markdown`
or `asciidoc` the formatted content would be returned though a Gitaly
call. Gitaly in turn would delegate formatting to the gitlab-gollum-lib
gem, which in turn would delegate that to various gems (like RDoc for
`rdoc`) and then apply some very liberal sanitization.

It was too liberal!

This change brings our wiki content formatting in line with how we
format other markdown at GitLab, so we have a SSOT for sanitization.

#30540

We are currently using Object#presence in many places (>65). This commit
fixes the Rubocop TODO offenses running rubocop --auto-correct.

If a page has the same name as a directory
the WikiPage#group_by_directory method can have
a wrong behaviour

This commit fixes it

- Add controls for sorting by title and date
- Execute Gitaly call which now accepts sorting params for wikis

- Add controls for sorting by title and date
- Execute Gitaly call which now accepts sorting params for wikis

This style change enforces `return if ...` instead of
`return nil if ...` to save maintainers a few minor review points.

Style change discussed in
https://gitlab.com/gitlab-org/gitlab-ce/issues/57454