Changes the service to only accept `milestone_id` param and not
`milestone`.

When a project is transferred between groups we also transfer
objects like labels or milestones. For transfered milestones
we should keep the status of the transfered milestone.

re #367045

Changelog: fixed

What:

- Continuation of refactoring discussed and started in
  !30979 (comment 337747596)
- Refactors Issuable-related service classes to subclass
  `BaseContainerService` instead of `BaseService`.

Why:

- This provides a greater degree of type safety in order to
  more easily and safely introduce a new named argument
  `spam_params` to support
  !58603
- The additional type safety will also make future refactors
  easier and less risky

How:

- Note that this is an incremental commit.
  In a subsequent commit, the
  first argument will be changed to `group` in the
  `Epics::BaseService` hierarchy.

Valery Sizov authored 3 years ago and Arturo Herrero committed 3 years ago

This change also makes count independent of
user authorisation. It's a logical step in a
light of 99eec020

Doug Stull authored 4 years ago and Rémy Coutable committed 4 years ago

- make use of new cops and gitlab-styles updates

This fixes a bug where only direct parent group
milestones were checked

Vladimir Shushlin authored 5 years ago and Mayra Cabrera committed 5 years ago

Add milestone close issues count service
Add milestone issue count service
Use count issue services in milestoneish
Clear milestone issue counters cache on issue creation
Clear milestone closed issue counters cache
Clear milestone issue counters cache on updating issue
Clear milestone issue counters on project transfer
Add a changelog for milestones page improvement
Fix milestones issue count cache keys

Eugenia Grieff authored 5 years ago and Mike Kozono committed 5 years ago

- Add new service that transfers milestones
from a group to a project
- Include new service in Projects transfer service
- Include FromUnion module in Milestone model
to use in transfer service
- Add specs for new milestones service
- Add specs for transferring milestones in
project transfer service

All instances of injecting an EE specific module have been changed to
use the new methods for this: prepend_if_ee, extend_if_ee, and
include_if_ee. This allows these lines to be included in CE, even when
the modules to inject do not exist. This in turn allows us to backport
these lines to CE and keep them there, instead of having to strip them
out.

Martin Wortschack authored 5 years ago and Lin Jen-Shin committed 5 years ago

- Externalize strings in milestones_helper
- Externalize strings in app/services
- Update PO file

Martin Wortschack authored 5 years ago and Lin Jen-Shin committed 5 years ago

- Externalize strings in milestones_helper
- Externalize strings in app/services
- Update PO file

Instead of querying relations into ids we just pass them to the model
scope because the scope supports it now.

Also changes other calls to `Milestone.for_projects_and_groups`

This moves all instances of `prepend EE::Something` and `include
EE::Something` in service classes to the last line of the corresponding
service class.  This pushes EE specific code further down the files,
reducing the likelihood of developers running into merge conflicts.

This whitelists all existing offenses for the various CodeReuse cops, of
which most are triggered by the CodeReuse/ActiveRecord cop.

This whitelists all existing offenses for the various CodeReuse cops, of
which most are triggered by the CodeReuse/ActiveRecord cop.

This whitelists all existing places where we use "destroy_all".

This whitelists all existing places where we use "destroy_all".

1. When milestone's dates changes
2. When issue changes milestone
3. When epic's issues change
4. When Epic changes date fields

Convert use of any_instance as it does not work with prepend

Partially addresses #47424.

* update-rubocop:
  Use stable gitlab-styles and eliminate offenses
  Updates from `rubocop -a`
  Update rubocop to get rid of a warning in other MR

some changes introduced by 4daa6da5, 26b6e299, 17898ce0 were regressed during today's merge conflict resolution of !11573.

This commit serves to reapply those changes.

/cc: @rspeicher @stanhu @mikegreiling