- Jun 05, 2024
-
-
Omar Qunsul authored
Add and backfill project_id for operations_strategies See merge request !155286 Merged-by:
Omar Qunsul <oqunsul@gitlab.com> Approved-by:
Tiger Watson <twatson@gitlab.com> Co-authored-by:
bmarjanovic <bmarjanovic@gitlab.com>
-
Eugenia Grieff authored
Quarantine a flaky test See merge request !155368 Merged-by:
Eugenia Grieff <egrieff@gitlab.com> Approved-by:
Eugenia Grieff <egrieff@gitlab.com> Co-authored-by:
Auto-quarantining bot <gitlab-auto-quarantine-bot@gitlab.com>
-
Heinrich Lee Yu authored
Fix flaky issue detail spec See merge request !154694 Merged-by:
Heinrich Lee Yu <heinrich@gitlab.com> Approved-by:
Serhii Yarynovskyi <syarynovskyi@gitlab.com> Approved-by:
Jessie Young <jessieyoung@gitlab.com>
-
Fiona Neill authored
Fixes a small typo in the CI/CD steps page See merge request !155303 Merged-by:
Fiona Neill <fneill@gitlab.com> Co-authored-by:
Lysanne Pinto <lpinto@gitlab.com>
-
Lysanne Pinto authored
-
Dmitry Gruzd authored
Developer documentation for adding data to elasticsearch See merge request !155237 Merged-by:
Dmitry Gruzd <dgruzd@gitlab.com> Approved-by:
Dmitry Gruzd <dgruzd@gitlab.com> Reviewed-by:
Dmitry Gruzd <dgruzd@gitlab.com> Co-authored-by:
maddievn <mvanniekerk@gitlab.com>
-
Madelein van Niekerk authored
-
Dylan Griffith authored
Add sharding key tracking issues for geo_replication See merge request !152829 Merged-by:
Dylan Griffith <dyl.griffith@gmail.com> Approved-by:
Fabien Catteau <fcatteau@gitlab.com> Approved-by:
Manoj M J <mmj@gitlab.com> Approved-by:
Dylan Griffith <dyl.griffith@gmail.com> Reviewed-by:
Michael Kozono <mkozono@gitlab.com> Reviewed-by:
Manoj M J <mmj@gitlab.com> Co-authored-by:
Michael Kozono <mkozono@gitlab.com> Co-authored-by:
Manoj M J <mmj@gitlab.com>
-
gitlab-housekeeper authored
Add sharding key tracking issues for feature category `geo_replication`. ## Background These tables were unable to be classified automatically, and will require manual input. Eventually all tables will need to be correctly classified, but we understand that this will be complex for some tables and completing these will take time. Instead, our goal for this task is to ensure all remaining tables are tracked in an issue, and to classify any straightforward cases that our automation may have missed (options 1 and 2 below). We have assigned a random backend engineer from ~"group::geo" as the initial DRI for this task, as well as an engineering manager for visibility. Please note that we are not requesting a large time commitment, creating one issue and linking it for all tables is perfectly acceptable. When you are finished, please assign to the ~database reviewer/maintainer suggested by Danger. If you have any questions or concerns, reach out to `#g_tenant-scale`. ## Task For each table, please select one of the following options: ### Option 1: Add a sharding key tracking issue This option is best suited to tables whose sharding behaviour is unknown, or will require additional work before a sharding key can be defined. Replace the `TODO` in the dictionary file with a link to an issue in the gitlab-org/gitlab project. ```diff - sharding_key_issue_url: TODO + sharding_key_issue_url: #1234 ``` You can create a new issue or link an existing one, and multiple entries can refer to the same issue. These issues will be used to track the work remaining on the [progress dashboard](https://cells-progress-tracker-gitlab-org-tenant-scale-g-f4ad96bf01d25f.gitlab.io/sharding_keys). If you are creating a new issue, you can copy over the following contents to the issue description: <details><summary>Click to expand</summary> Issue Title: Set sharding keys for tables in 'group::geo' Issue Description: Sharding keys need to be set for the tables: geo_cache_invalidation_events, geo_event_log, geo_events, geo_node_statuses, geo_nodes, geo_repositories_changed_events, group_wiki_repository_states, merge_request_diff_details, upload_states This involves choosing one of the following, based on the intended behaviour of the table: - **The table is not cell-local** - Set `gitlab_schema` to `gitlab_main_clusterwide`. - **The table is cell-local and requires a sharding key** - Set `gitlab_schema` to `gitlab_main_cell` - Add a `sharding_key` or `desired_sharding_key` configuration. If the configuration is known but the chosen key doesn't yet meet not-null and foreign key requirements, you can add an exception to `allowed_to_be_missing_not_null` or `allowed_to_be_missing_foreign_key` to get the pipeline passing. Please link to a follow-up issue in a code comment next to the exception. - You may also need to set `allow_cross_joins`, `allow_cross_transactions` and `allow_cross_foreign_keys` if changing the schema causes pipeline failures. See [`db/docs/epics.yml`](https://gitlab.com/gitlab-org/gitlab/-/blob/master/db/docs/epics.yml?ref_type=heads#L12-17) for an example. - **The table is cell-local and does not require a sharding key** - Set `gitlab_schema` to `gitlab_main_cell` and - Set `exempt_from_sharding` to `true`. ### Documentation - [Choosing either the gitlab_main_cell or gitlab_main_clusterwide schema](https://docs.gitlab.com/ee/development/database/multiple_databases.html#choose-either-the-gitlab_main_cell-or-gitlab_main_clusterwide-schema) - [Defining a sharding key for all cell-local tables](https://docs.gitlab.com/ee/development/database/multiple_databases.html#defining-a-sharding-key-for-all-cell-local-tables) - [Defining a desired_sharding_key to automatically backfill a sharding_key](https://docs.gitlab.com/ee/development/database/multiple_databases.html#define-a-desired_sharding_key-to-automatically-backfill-a-sharding_key) </details> ### Option 2: Add sharding key configuration This option is best suited to tables with an easily identifiable sharding key that will require minimal work to define. Remove `sharding_key_issue_url` from the dictionary file and instead complete the classification for the table. This involves choosing one of the following, based on the intended behaviour of the table: - **The table is not cell-local** - Set `gitlab_schema` to `gitlab_main_clusterwide`. - **The table is cell-local and requires a sharding key** - Set `gitlab_schema` to `gitlab_main_cell` - Add a `sharding_key` or `desired_sharding_key` configuration. If the configuration is known but the chosen key doesn't yet meet not-null and foreign key requirements, you can add an exception to `allowed_to_be_missing_not_null` or `allowed_to_be_missing_foreign_key` to get the pipeline passing. Please link to a follow-up issue in a code comment next to the exception. - You may also need to set `allow_cross_joins`, `allow_cross_transactions` and `allow_cross_foreign_keys` if changing the schema causes pipeline failures. See [`db/docs/epics.yml`](https://gitlab.com/gitlab-org/gitlab/-/blob/master/db/docs/epics.yml?ref_type=heads#L12-17) for an example. - **The table is cell-local and does not require a sharding key** - Set `gitlab_schema` to `gitlab_main_cell` and - Set `exempt_from_sharding` to `true`. ### Documentation - [Choosing either the gitlab_main_cell or gitlab_main_clusterwide schema](https://docs.gitlab.com/ee/development/database/multiple_databases.html#choose-either-the-gitlab_main_cell-or-gitlab_main_clusterwide-schema) - [Defining a sharding key for all cell-local tables](https://docs.gitlab.com/ee/development/database/multiple_databases.html#defining-a-sharding-key-for-all-cell-local-tables) - [Defining a desired_sharding_key to automatically backfill a sharding_key](https://docs.gitlab.com/ee/development/database/multiple_databases.html#define-a-desired_sharding_key-to-automatically-backfill-a-sharding_key) Related to #455137 This change was generated by [gitlab-housekeeper](https://gitlab.com/gitlab-org/gitlab/-/tree/master/gems/gitlab-housekeeper) using the Keeps::AddShardingKeyTrackingIssues keep. To provide feedback on your experience with `gitlab-housekeeper` please comment in <#442003>. Changelog: other
-
Dylan Griffith authored
Removes temporary index on project_statistics See merge request !154410 Merged-by:
Dylan Griffith <dyl.griffith@gmail.com> Approved-by:
Ethan Urie <eurie@gitlab.com> Approved-by:
Dylan Griffith <dyl.griffith@gmail.com> Co-authored-by:
Vijay Hawoldar <vhawoldar@gitlab.com>
-
Ankit Panchal authored
Remove product_stage from metrics 17: verify See merge request !154438 Merged-by:
Ankit Panchal <apanchal@gitlab.com> Approved-by:
Ankit Panchal <apanchal@gitlab.com> Co-authored-by:
michold <mwielich@gitlab.com>
-
Ankit Panchal authored
Remove product_stage from events 2: create, growth and more stages See merge request !155067 Merged-by:
Ankit Panchal <apanchal@gitlab.com> Approved-by:
Ankit Panchal <apanchal@gitlab.com> Co-authored-by:
michold <mwielich@gitlab.com>
-
Jessie Young authored
Remove ai_gateway_docs_search flag See merge request !154876 Merged-by:
Jessie Young <jessieyoung@gitlab.com> Approved-by:
Lesley Razzaghian <lrazzaghian@gitlab.com> Approved-by:
Suzanne Selhorn <sselhorn@gitlab.com> Approved-by:
Jessie Young <jessieyoung@gitlab.com> Reviewed-by:
Mark Chao <mchao@gitlab.com> Reviewed-by:
Mohamed Hamda <mhamda@gitlab.com> Co-authored-by:
Mark Chao <mchao@gitlab.com>
-
Jessie Young authored
Remove the user_detail creation derisk feature flag See merge request !153770 Merged-by:
Jessie Young <jessieyoung@gitlab.com> Approved-by:
Max Orefice <morefice@gitlab.com> Approved-by:
Jessie Young <jessieyoung@gitlab.com> Reviewed-by:
Max Orefice <morefice@gitlab.com> Co-authored-by:
Doug Stull <dstull@gitlab.com>
-
Gosia Ksionek authored
Merge branch 'quarantine-flaky-tests-ee-spec-lib-gitlab-llm-ai_gateway-docs_client_spec-rb-75' into 'master' Quarantine a flaky test See merge request !155352 Merged-by:
Gosia Ksionek <mksionek@gitlab.com> Approved-by:
Gosia Ksionek <mksionek@gitlab.com> Co-authored-by:
Auto-quarantining bot <gitlab-auto-quarantine-bot@gitlab.com>
-
Omar Qunsul authored
Merge branch 'quarantine-flaky-tests-spec-features-dashboard-datetime_on_tooltips_spec-rb-29' into 'master' Quarantine a flaky test See merge request gitlab-org/gitlab!155355 Merged-by:
Omar Qunsul <oqunsul@gitlab.com> Approved-by:
Omar Qunsul <oqunsul@gitlab.com> Co-authored-by:
Auto-quarantining bot <gitlab-auto-quarantine-bot@gitlab.com>
-
Adam Hegyi authored
GraphQL: Add fullPath argument in runnerUsage query See merge request !154462 Merged-by:
Adam Hegyi <ahegyi@gitlab.com> Approved-by:
Hordur Freyr Yngvason <hfyngvason@gitlab.com> Approved-by:
Adam Hegyi <ahegyi@gitlab.com> Reviewed-by:
Pedro Pombeiro <noreply@pedro.pombei.ro> Reviewed-by:
Hordur Freyr Yngvason <hfyngvason@gitlab.com> Reviewed-by:
Adam Hegyi <ahegyi@gitlab.com> Co-authored-by:
Pedro Pombeiro <noreply@pedro.pombei.ro>
-
Pedro Pombeiro authored
EE: true Changelog: added
-
Jonas Larsen authored
Merge branch 'quarantine-flaky-tests-spec-lib-gitlab-instrumentation-redis_spec-rb-53' into 'master' Quarantine a flaky test See merge request gitlab-org/gitlab!154655 Merged-by:
Jonas Larsen <jlarsen@gitlab.com> Approved-by:
Javiera Tapia <jtapia@gitlab.com> Co-authored-by:
gdk <gdk@example.com>
-
Rémy Coutable authored
Update Gitaly version See merge request gitlab-org/gitlab!155344 Merged-by:
Rémy Coutable <remy@rymai.me> Approved-by:
release-tools approver bot <project278964_bot6@example.com> Co-authored-by:
GitLab Release Tools Bot <delivery-team+release-tools@gitlab.com>
-
Lorena Ciutacu authored
Document supported label filter metrics in VSD See merge request !155389 Merged-by:
Lorena Ciutacu <lciutacu@gitlab.com> Approved-by:
Lorena Ciutacu <lciutacu@gitlab.com> Co-authored-by:
Adam Hegyi <ahegyi@gitlab.com>
-
Adam Hegyi authored
-
Adam Hegyi authored
Consider 2 more events as daily usage of Code Suggestion feature See merge request !153970 Merged-by:
Adam Hegyi <ahegyi@gitlab.com> Approved-by:
Adam Hegyi <ahegyi@gitlab.com> Co-authored-by:
Pavel Shutsin <pshutsin@gitlab.com>
-
Ashraf Khamis authored
Merge branch '460716-create-a-new-documentation-page-for-the-exact-code-search-zoekt' into 'master' Create a new documentation page for the Exact code search: Zoekt See merge request gitlab-org/gitlab!154027 Merged-by:
Ashraf Khamis <akhamis@gitlab.com> Co-authored-by:
rkumar555 <rkumar@gitlab.com>
-
Ravi Kumar authored
-
Heinrich Lee Yu authored
Merge branch 'quarantine-flaky-tests-spec-features-projects-work_items-linked_work_items_spec-rb-79' into 'master' Quarantine a flaky test See merge request !155358 Merged-by:
Heinrich Lee Yu <heinrich@gitlab.com> Approved-by:
Heinrich Lee Yu <heinrich@gitlab.com> Co-authored-by:
Auto-quarantining bot <gitlab-auto-quarantine-bot@gitlab.com>
-
Marcel Amirault authored
Updated title to be more descriptive See merge request !153111 Merged-by:
Marcel Amirault <mamirault@gitlab.com> Approved-by:
Marcel Amirault <mamirault@gitlab.com> Co-authored-by:
Fiona Neill <fneill@gitlab.com>
-
Fiona Neill authored
-
Thong Kuah authored
Fix flaky fake repo creation See merge request !155205 Merged-by:
Thong Kuah <tkuah@gitlab.com> Approved-by:
Abdul Wadood <awadood@gitlab.com>
-
Evan Read authored
Deprecate support for Ubuntu 18.04 See merge request gitlab-org/gitlab!155384 Merged-by:
Evan Read <eread@gitlab.com> Approved-by:
Evan Read <eread@gitlab.com> Co-authored-by:
Peter Lu <plu@gitlab.com>
-
Ash McKenzie authored
Allow Beyond Identity Integration to be inheritable See merge request !154310 Merged-by:
Ash McKenzie <amckenzie@gitlab.com> Approved-by:
Max Orefice <morefice@gitlab.com> Approved-by:
Ivane Gkomarteli <igkomarteli@gitlab.com> Approved-by:
Prabakaran Murugesan <pmurugesan@gitlab.com> Approved-by:
Ash McKenzie <amckenzie@gitlab.com> Reviewed-by:
Ash McKenzie <amckenzie@gitlab.com> Reviewed-by:
Max Orefice <morefice@gitlab.com> Co-authored-by:
j.seto <jseto@gitlab.com>
-
Tiger Watson authored
Validate the not null constraint on epics.issue_id See merge request gitlab-org/gitlab!154956 Merged-by:
Tiger Watson <twatson@gitlab.com> Approved-by:
Tiger Watson <twatson@gitlab.com> Co-authored-by:
Alexandru Croitor <acroitor@gitlab.com>
-
Ash McKenzie authored
Update environment_unprotected See merge request !155149 Merged-by:
Ash McKenzie <amckenzie@gitlab.com> Approved-by:
Evan Read <eread@gitlab.com> Approved-by:
Ash McKenzie <amckenzie@gitlab.com> Co-authored-by:
nrosandich <nrosandich@gitlab.com>
-
Nate Rosandich authored
-
Auto-quarantining bot authored
The `Epic show Epic sidebar Labels select when dropdown is open creates new label using create view` test has either ~"flakiness::1" or ~"flakiness::2" label set, which means the number of reported failures is at or above 95 percentile, indicating unusually high failure count. This MR quarantines the test. This is a discussion starting point to let the responsible group know about the flakiness so that they can take action: - accept the merge request and schedule the associated issue to improve the test - close the merge request in favor of another merge request to delete the test Please follow the [Flaky tests management process](https://handbook.gitlab.com/handbook/engineering/infrastructure/engineering-productivity/flaky-tests-management-and-processes/#flaky-tests-management-process) to help us increase `master` stability. Please let us know your feedback [in the dedicated issue](gitlab-org/quality/engineering-productivity/team#447). Related to #446136. This change was generated by [gitlab-housekeeper](https://gitlab.com/gitlab-org/gitlab/-/tree/master/gems/gitlab-housekeeper) using the Keeps::QuarantineFlakyTests keep. To provide feedback on your experience with `gitlab-housekeeper` please comment in <#442003>. Changelog: other
-
Vitali Tatarintev authored
Merge branch '441523-fix-exclusive-lease-usage-in-transaction-for-app-mailers-previews-notify_preview-rb' into 'master' Update code comment in notify preview See merge request gitlab-org/gitlab!155252 Merged-by:
Vitali Tatarintev <vtatarintev@gitlab.com> Approved-by:
Sylvester Chin <schin@gitlab.com> Approved-by:
Vitali Tatarintev <vtatarintev@gitlab.com> Co-authored-by:
David Kim <dkim@gitlab.com>
-
Auto-quarantining bot authored
The `Work item linked items for signed in user links a new item with work item wildcard iid` test has either ~"flakiness::1" or ~"flakiness::2" label set, which means the number of reported failures is at or above 95 percentile, indicating unusually high failure count. This MR quarantines the test. This is a discussion starting point to let the responsible group know about the flakiness so that they can take action: - accept the merge request and schedule the associated issue to improve the test - close the merge request in favor of another merge request to delete the test Please follow the [Flaky tests management process](https://handbook.gitlab.com/handbook/engineering/infrastructure/engineering-productivity/flaky-tests-management-and-processes/#flaky-tests-management-process) to help us increase `master` stability. Please let us know your feedback [in the dedicated issue](gitlab-org/quality/engineering-productivity/team#447). Related to #444914. This change was generated by [gitlab-housekeeper](https://gitlab.com/gitlab-org/gitlab/-/tree/master/gems/gitlab-housekeeper) using the Keeps::QuarantineFlakyTests keep. To provide feedback on your experience with `gitlab-housekeeper` please comment in <#442003>. Changelog: other
-
Auto-quarantining bot authored
The `Tooltips on .timeago dates on the activity tab has the datetime formated correctly` test has either ~"flakiness::1" or ~"flakiness::2" label set, which means the number of reported failures is at or above 95 percentile, indicating unusually high failure count. This MR quarantines the test. This is a discussion starting point to let the responsible group know about the flakiness so that they can take action: - accept the merge request and schedule the associated issue to improve the test - close the merge request in favor of another merge request to delete the test Please follow the [Flaky tests management process](https://handbook.gitlab.com/handbook/engineering/infrastructure/engineering-productivity/flaky-tests-management-and-processes/#flaky-tests-management-process) to help us increase `master` stability. Please let us know your feedback [in the dedicated issue](gitlab-org/quality/engineering-productivity/team#447). Related to #444850. This change was generated by [gitlab-housekeeper](https://gitlab.com/gitlab-org/gitlab/-/tree/master/gems/gitlab-housekeeper) using the Keeps::QuarantineFlakyTests keep. To provide feedback on your experience with `gitlab-housekeeper` please comment in <#442003>. Changelog: other
-