Even though we are now counting minutes when shared runners are
disabled, we don't want to show that information in the UI, since it may
be confusing to users to see minutes being counted after they have
disabled shared runners. Avoiding changes to the UI involves re-adding a
check for Namespace#any_project_with_shared_runners_enabled? in some
places.

This commit follows up the protected environment
refactoring.

This commit removes the artifacts attribute from pipeline details
entity. We are now lazy loading all artifacts when a user request
them instead of loading everything on page load.

Changelog: performance

Matthias Käppler authored 3 years ago and Arturo Herrero committed 3 years ago

This fixes an N+1 when rendering the pipeline tab.

This MR stops exposing tests_total_count data from our
PipelineEntity as we don't use it in our frontend.
It also starts memoizing test_report_summary.

Apply code review feedback

Now that we have tested the feature in prod
we can remove this build_report_summary
feature flag. Most of what was hidden is still
behind another feature flag anyway.

It fixes N + 1 issue

Fabio Pitino authored 4 years ago and Sean McGivern committed 4 years ago

Allow frontend to display which job triggered the downstream
pipeline.

The plan for RSpec 4.0 is to disable monkey patching, reference:
https://rspec.info/blog/2013/07/the-plan-for-rspec-3/#zero-monkey-patching-mode
https://relishapp.com/rspec/rspec-core/docs/configuration/zero-monkey-patching-mode

This commit stops using RSpec monkey patching in several specs.

Vitali Tatarintev authored 5 years ago and Heinrich Lee Yu committed 5 years ago

Removes usage of `set` in specs

Erick Bajao authored 5 years ago and Stan Hu committed 5 years ago

Non archive artifacts are not keepable so don't return
the keep_path for them.

Use has_expiring_archive_artifacts in BuildArtifactEntity.

Move has_expiring_artifacts to be private.

Preload job_artifacts_archive when loading bunch of pipelines
to avoid N+1 query.

!20615 introduced a
performance regression: each failed build would generate additional SQL
queries, since they would be rendered by JobEntity. This commit fixes
that by preloading failed builds among other items and adds an N+1 query
test. This adds 4 additional queries per pipeline:

1. user
2. latest_statuses_ordered_by_stage
3. failed_builds
4. failed_builds metadata

Closes #118427

This reverts merge request !19759

This commit handles N+1 calls being
submited at 'GET /projects/:id/repository/branches'
endpoint for protected branches.

It does so by using properly eagerloaded protected branches
relations, which also avoids N+1 ActiveRecord cached
calls.

Ran: bundle exec rubocop --only RSpec/EmptyLineAfterSubject -a

Marius Bobin authored 5 years ago and Lin Jen-Shin committed 5 years ago

Allow jobs to use CI_JOB_TOKEN to trigger downstream pipelines

Moves exposing test reports to PipelinesController#test_report instead
of having it in the PipelineDetailsEntity.

Exposes test report data in the PipelineDetailsEntity. This includes but
is not limited to the total running time, total test count and total
status.

#27703

Yorick Peterse authored 5 years ago and Achilleas Pipinellis committed 5 years ago

This changes any mention of gitlab-ce to gitlab-foss, and any mention of
gitlab-ee to just gitlab.

These are not required because MySQL is not
supported anymore

These are not required because MySQL is not
supported anymore

Mayra Cabrera authored 5 years ago and Douglas Barbosa Alexandre committed 5 years ago

- Adds an endpoint on PipelinesController
- Adds a service that iterates over every build in a stage and
plays it.
- Includes 'play_manual' details on EntitySerializer
- Builds a new Stage state: PlayManual. An stage can take this status if
it has manual builds or an skipped, scheduled or manual status
- Includes FE modifications and specs

Mayra Cabrera authored 5 years ago and Douglas Barbosa Alexandre committed 5 years ago

- Adds an endpoint on PipelinesController
- Adds a service that iterates over every build in a stage and
plays it.
- Includes 'play_manual' details on EntitySerializer
- Builds a new Stage state: PlayManual. An stage can take this status if
it has manual builds or an skipped, scheduled or manual status
- Includes FE modifications and specs

Add spec

Fix

Fix

Add changelog

Drop attached

Remove attached

Update changelog

ok

Make it sane

Include merge ref head

Fix union

Improve a bit

Add spec

remove

add spec

Add changelog

fix coding offence

Apply suggestion to spec/models/merge_request_spec.rb

ok

ok

Fix

Fix spec

Fix spec

fix

Simplify the things

Memoize

OK

a

Add preload

Fix

ok

Write tests

test only postgresql

ok

add more test
;

Improve wording

Add changelog

Fix

Adam Mulvany authored 6 years ago and Rémy Coutable committed 6 years ago

Signed-off-by: Rémy Coutable <remy@rymai.me>