* Adds missing optimize fixtures to pipeline execution
* Prevents EE from running the same fixtures twice

Co-authored-by: Lorena Ciutacu <lciutacu@gitlab.com>

This reverts merge request !160063

Co-authored-by: Jay McCure <jmccure@gitlab.com>

Reverting !125861

Changelog: other

Always build assets image when tagging

See merge request !162584



Merged-by: Dat Tang <dattang@gitlab.com>
Approved-by: David Dieulivol <ddieulivol@gitlab.com>


(cherry picked from commit 4ab24a70)

4a303817 Always build assets image when tagging

Co-authored-by: Dat Tang <dattang@gitlab.com>

Removes tests related to markdown snapshots and the
glfm-verify job. This is the first step to completely remove
all tests related to GLFM snapshot specs.

For #468194, we want to add
a new set of jobs that run Jest specs with Vue 3 in merge requests.

This makes it clearer that the hidden job definition is specifically for
the nightly pipeline run, and not just for Vue 3 Jest jobs in general.

Signed-off-by: Rémy Coutable <remy@rymai.me>

Signed-off-by: Rémy Coutable <remy@rymai.me>

The label in question is is ~"pipeline:run-e2e-omnibus-once".

If this label is not present, we should NOT run the child pipeline.

If the label is present, we should continue the rules for the child pipeline
to see if the job should be run in the pipeline.

Previously, we only ran release-environments with the canonical GitLab
repo. Because the security MRs were only synced to canonical GitLab repo
`gitlab-org/gitlab` after tagging, release-environments didn't run on
any commit. In that situation, we need to run release-environments on
tagging to validate the security MRs.

We now run release-environments on security mirror
`gitlab-org/security/gitlab` after finishing
gitlab-com/gl-infra/delivery#20285. Thus,
merging happens before tagging, so all the security MRs are validated by
release-environments. It is not needed to rerun release-environments
once more when tagging.

This commit also avoids possible failures because the trigger build
template `.gitlab/ci/cng/main.gitlab-ci.yml` does not support run on
tagging yet.

When !157451 was
backported to `16-11-stable-ee`, we noticed that none of the Workhorse
CI tests ran. We would have noticed that the bump to Ruby 3.1.5 would
have failed in CI since no image with Go 1.20 and Git 2.36 was built
with Ruby 3.1.5. The following merge requests were needed to build
with this combination:

* gitlab-build-images!836
* gitlab-build-images!837

Release Environments pipeline has the job
[`release-environment-build-cng-env`](https://gitlab.com/gitlab-org/gitlab/-/blob/8de86be7ec63ae0e06ee14f1ba5ae4239e2c28ff/.gitlab/ci/release-environments/main.gitlab-ci.yml#L31)
that always requires the artifact from the `build-assets-image` job in
the parent pipeline
([link](https://gitlab.com/gitlab-org/gitlab/-/blob/4c8b52c5d8aab5a7bd12428236115d4ff2d153b5/.gitlab/ci/cng/main.gitlab-ci.yml#L23)).
Thus, this change add the rule triggering release environments to the
rule building the assets image, so they always run together.

Lin Jen-Shin authored 7 months ago and Jennifer Li committed 7 months ago

The automated `e2e:package-and-test-ee` might only run in tier 3
pipelines, and in some cases we might want to run it earlier.
While this can be done by using `pipeline:run-all-e2e` label,
we'll need to trigger a new pipeline after the label has been applied.

Simply always having a way to manually trigger it is just simpler and
easier.

Note that the manual actions are always allowed to fail though.
Even if the manual `follow-up:e2e:package-and-test-ee` failed,
it'll not be shown as an error in the pipeline, but a warning.

After the pipeline reached tier 3, we run the automated one,
which is not allowed to fail, therefore blocking from merging
if it's failing.

Remove test mapping

Reduce pattern to only gitlab ci

Override after_script

Remove lefthook reminder for ci config tests

Signed-off-by: Rémy Coutable <remy@rymai.me>

Rémy Coutable authored 7 months ago and Jennifer Li committed 7 months ago

Signed-off-by: Rémy Coutable <remy@rymai.me>

If we run it when needed jobs failed, we can be missing metadata from
those failed jobs.

Even before any approvals. This is a follow up from
!157337
where it moved it completely after approval (tier 3)

Signed-off-by: Rémy Coutable <remy@rymai.me>

As docs pages get moved around or deleted, docs links that we display in
the product might become outdated without us noticing.
This adds an ESLint rule that ensures `helpPagePath` always points to
files and anchors that still exist.
In future iterations, we should add a similar rule to check usages of
the `HelpPageLink` Vue component, and a Rubocop rule for the backend
`help_page_path` helper.

This should not affect any actual behaviour because it should still read
and write with the described strategy. We just additionally also write
another mapping file for coverage strategy so that we can compare them.

Signed-off-by: Rémy Coutable <remy@rymai.me>

Fix cng unit tests

Update .qa:rules:e2e:test-on-cng rule to skip running in stable branches until gitlab-org/quality/quality-engineering&89 is completed