Jacques Erasmus authored 5 years ago and Paul Slaughter committed 5 years ago

- Also refactors the environment text function into smaller functions

Samantha Ming authored 5 years ago and Paul Slaughter committed 5 years ago

- Remove last commit column
- Move matching branch and detail to branch column
- Make badge inline

This commit reduces the lock contention of internal iid

Which fixes gitlab-org/gitlab#33255 and also
includes
gitlab-org/gitlab-elasticsearch-indexer!39

Igor Drozdov authored 5 years ago and Stan Hu committed 5 years ago

Currently the full potential of lazy_author
is not used
Let's try and use lazy_author&.itself instead
of lazy_author.__sync to load authors in batches

Simon Knox authored 5 years ago and Martin Wortschack committed 5 years ago

- stacked table on sm
- truncate error text more intelligently
- display error.type instead of title

This also adds a new update endpoint for setting
the group's max_artifacts_size.

Documentation is also updated to include instructions
for setting project and group level max_artifacts_size.

Sam Beckham authored 5 years ago and Fatih Acet committed 5 years ago

- Adds actions and mutations to fetch the new endpoint
- Conditionally fetches the old or new reports dependant on a feature
flag
- Tells the LC getter to fetch the new report if it's there, and the old
one if not.
- Adds a bit of a hack to morph the new data in to the old format
(temporarily)
- Pulls in the proper polling endpoints
- Adds tests for all the above

Rubén Dávila authored 5 years ago and Mayra Cabrera committed 5 years ago

Helper was incorrectly returning `true` when user was moving from Step 2
(Lead generation) to Step 3 (Selection of namespace). When landing at
Step 3. `trial_result` is `nil` so helper show return `false`.

- Send notifications when a private group is
mentioned in the title or description of and issue
or merge request
- Do not create a new todo for group members when
editing a note where a private group was mentioned

Initial limit is set at 5000. System notes are still allowed
to be created even when the noteable is over the limit.

Stan Hu authored 5 years ago and Kushal Pandya committed 5 years ago

If the number of activities on the page were less than the limit (20),
the pager would display the set of activities but also insert a "No
activities found" banner underneath. This was happening because the
pager attempted to load more data because it thought it needed to
display more information in the window.

This commit fixes the problem by disabling the pager if the number of
activities received is less than the total limit.

Closes #27118

There were three sources of N+1 queries here: the license check, the
path and namespace information, and the root namespace.

The license check was the worst. We were checking the license
information on each project individually. This meant we couldn't
paginate in SQL, but did so in Ruby, so it was not only an N+1, it was
loading too many records.

To fix this, we use the fact that this API endpoint can only return
projects in a particular namespace. License checks end up at one of two
places: for most instances, it's the instance's license itself. For
GitLab.com, where individual namespaces have their own plan, it's the
root namespace (subgroups can't have plans; they inherit their plan from
the root).

This means that we only ever need a single check. If it passes, every
project returned has the feature available. If it fails, we return a
404, like the other endpoints here. That way we can paginate in SQL, as
we should.

The path and namespace information N+1 was simple to fix: just preload
that information.

The final N+1 was on the root namespace, which we return as the `owner`
field for compatibility with GitHub. Again, this was always the same for
all items in the response, but we can't preload it easily because
different projects will be at different levels of the hierarchy.
Instead, we just calculate the root namespace once, and pass that as an
option to the entity. The entity uses that value if it's given, and
falls back to calculating it if it's not (in case this entity is used
elsewhere without that option).

This association will be used for a cluster to indicate which project is
used to manage it.

Validate against duplicate scope for same project. If multiple clusters
with the same scope points to the same management_project, it will be
impossible to deterministically select a cluster

with i18n (internationalization)

Coung Ngo authored 5 years ago and Mike Greiling committed 5 years ago

Before in issue boards, a card showed labels including the list label.
The list label is redundant since you can see the list label at the top
of the card collection and adds noise. This commit removes list labels
from inside list label cards.

Coung Ngo authored 5 years ago and Clement Ho committed 5 years ago

Before, notes (discussions.json) would be fetched twice in the following
case:
* User has a "Show comments only" or "Show history only" filter
* User then goes to an issue with a note hash, i.e. #note_*
* Frontend then makes two notes requests:
  1. Notes for the user's original filter
  2. Notes for "Show all activity" so that the note is definitely shown

This commit fixes this race condition so that there is always only
one note request made whether it is for a specific note or not.

The artifacts endpoint needs to be polled while
we don't have the content.

This commit creates an vuex app to handle the polling

Sarah Yasonik authored 5 years ago and Rémy Coutable committed 5 years ago

Adds a new endpoint which proxies calls to the grafana endpoint
which proxies calls to any grafana datasource configured to
support it. This will be used as a part of embedding prometheus
metrics in GFM via grafana.

This commit ports over some files I missed
in my first commit because I forgot to stage
them in the first commit.

This commmit is the start for issue 30807 and
resolving usability problems with file templates.
I've moved the exisiting UI and changed some functionality.

Use toast component to undo template actions

Set active class to template type

Fix failing rspec tests

Fixed failing rspec tests due to refactor
of the UI. New functionality was introduced
so the tests needed to be reworked.

Fix failing test and add mobile styles

Generate changelog for merge request

Fix eslint errors for i18n

Fix failed job due to locale/gitlab.pot

Fix linting error in haml file

Change dropdown labels and fix dropdown headers

Adjust rspec for template selectors

Change toggle text after undo template action

Fix broken toast due to udpated master

Remove toggle label on template selector

Fix failing rspec tests due to toggle text change

Remove un-need conditional check

Add template selection to toast

Adjust rspec to pass for undo action

Avielle Wolfe authored 5 years ago and Grzegorz Bizon committed 5 years ago

Project security dashboards were displaying no vulnerabilities for
public projects, even when the latest pipeline reported
vulnerabilities.

The issue was our Namespace#store_security_reports_available? method,
which had no knowledge of the project or whether it was public, and
only checked for availability based on the instance's license.

I've added Project#can_store_security_reports?, which calls into
Namespace to check for license availability and _also_ checks
whether the project is public. Now public projects can get the
security scanning they've been wanting!

#13422

This change prevents deactivated users from
using slash commands.

GitHub releases will have a null `published_at` field if they are in
the draft state. If no date is available in the release, just fill
it in with today's date since our database schema requires this.

Closes #33732

It creates a separate endpoint to return just
metadata of the diffs, but not the actual
serialized diff lines, which are _very_
expensive to serialize.

Manoj M J authored 5 years ago and Ash McKenzie committed 5 years ago

This change adds the ability to
deactivate a user that has no recent activity i
in the last 14 days.
A deactivated user can still login
and this will reactivate the user.

Call MigratePagesMetadata for batches of projects to populate
`project_pages_metadata` table.

Related to #28781.

Oswaldo Ferreira authored 5 years ago and Mayra Cabrera committed 5 years ago

Prepares the diffs_batch endpoint to return the
latest MR diff files version and the pagination data
(page, total pages, etc).

It doesn't read from cache as it's not worth today, given
the read/write can't be done in chunks.
This will be worked further at:
#30550

Nicolò Maria Mezzopera authored 5 years ago and Clement Ho committed 5 years ago

- use modal title
- adjust tests
- update locales
- changelog

Signed-off-by: Balasankar "Balu" C <balasankar@gitlab.com>