Lukas Eipert authored 4 years ago and Heinrich Lee Yu committed 4 years ago

This moves the following things to Core:
- Jira DVCS Connector
- Jira Connect App
- Usage ping for those two features

and removes any license check related to them.

Co-authored-by: Craig Norris <cnorris@gitlab.com>

Since ActiveRecord is instantiating the objects directly by calling
`.allocate` on the model classes, mocking with `next_instance_of` mock
helpers is not possible as it is depending on the `.new` method being
called. To make it possible to mock next instance of ActiveRecord
models, we had to implement a new set of mock helpers which rely on
the `.allocate` method to be called.

Nicolò Maria Mezzopera authored 4 years ago and Lin Jen-Shin committed 4 years ago

- module utility
- test case

This commit introduces the param `exclude_internal` in the
users GET REST endpoint to exclude non internal users from
the list.

Only on spec directory

This only compared using `==` which means that we misidentify a lot of
open-ranges when calculating `move_to_end`/`move_to_start`.

Phil Hughes authored 4 years ago and Igor Drozdov committed 4 years ago

Removes all the code around the single merge request diff
view code.

Dmitry Gruzd authored 4 years ago and Mark Chao committed 4 years ago

- rename metric to search_unique_visits_for_any_target_weekly
- remove to_date calls
- replace Date.today with Date.current

Brett Walker authored 4 years ago and Imre Farkas committed 4 years ago

when test settings are run

Zamir Martins authored 4 years ago and charlie ablett committed 4 years ago

CiliumNetworkPolicy kubernetes resources

This is motivated by errors such as
https://sentry.gitlab.net/gitlab/gitlabcom/issues/1766076, where
attempts to move nulls fail even with rebalancing due to the fact that
the gap found is not big enough for all the nulls.

We address this in two ways:

- we try to consolidate multiple gaps. Up to 10 gaps will be found and
consolidated to make enough room. This is expected to be effective in
most cases.

- if we still cannot make enough space, rather than failing, we stack
all overflow elements at the edge. So if we need to move 10 nulls to the
end, and we only have space for 5, all the extras (5 of them) will be
placed at the maximum position.

Adds a changelog entry since this is a bug-fix

Fork of a project takes more than a second in tests
If we specify a target project that has been created using a factory
We can reduce this time to ~0.4s

Fix Rais/SaveBang cop for ee/spec/support/shared_examples/services/*

Add changelog for the cop fixes

Disable cop for create method in shared examples

Fix spec failure

Fix specs

Nathan Friend authored 4 years ago and Mark Chao committed 4 years ago

This commit adds RSpec feature tests that cover the functionality of
the "New Release" page.

Justin Ho Tuan Duong authored 4 years ago and Dylan Griffith committed 4 years ago

To follow order on the project level

Move enums related modules to a separate directory

This merge request was originally introduced in
!40026 but reverted
in !40245. We fix
the issue it caused by using `Gitlab::Redis::SharedState.url`, which
handles the differences between the GDK and CI `resque.yml`
configuration formats.

We started using Workhorse in feature tests, but no `config.toml` was
 provided. As a result, we missed a startup issue that could have been
caught by testing the config loading.

A small subset of Workhorse functionality also relies on Workhorse and
Rails sharing a Redis database. If we configure it here, we can enhance
the runner API testing in rails to ensure it behaves as expected.

Closes #209245

This MR also fixes the Rails/SaveBang offenses for
ee/spec/support/shared_examples/requests/*.

It also adds the changelog for the fix

Add changelog for the cop fixes

Disable cop for create method in specs

Disable cop for create method in specs

Justin Ho Tuan Duong authored 4 years ago and Phil Hughes committed 4 years ago

Use GlFormCheckbox instead of GlToggle for setting
of "Active" integration.

This reverts merge request !40026

Remove analytics icon from top nav bar
Move Cohorts and DevOps Score pages to Admin panel
under Analytics submenu
Keep old paths but redirect to new pages under /admin
Make sure that Cohorts and DevOps Score are
visible only to Admin, remove a toggle that
was enabling instance statistics to be seen
by not admin user
Ignore instance_statistics_visibility_private
column as the first step to drop it,
remove obsolete condition from global policy
and ignored application setting

Giorgenes Gelatti authored 4 years ago and Sean McGivern committed 4 years ago

Extend composer specs to test for auth token
from private token param

Introduce TestProf::FactoryDefault:
https://github.com/test-prof/test-prof/blob/master/docs/recipes/factory_default.md

It allows us to avoid cascading factories problem by creating a
default factory:

let(:project) { create_default(:project) }

Next created factory that has project as an association will use
the default record instead of creating a new one.

In combination with let_it_be we'll also avoid creating multiple
records for a test suite

Philip Cunningham authored 4 years ago and Dylan Griffith committed 4 years ago

Switches feature flag over to new policy with additional checks.

We started using Workhorse in feature tests, but no `config.toml` was
provided. As a result, we missed a startup issue that could have been
caught by testing the config loading.

A small subset of Workhorse functionality also relies on Workhorse and
Rails sharing a Redis database. If we configure it here, we can enhance
the runner API testing in rails to ensure it behaves as expected.

Closes #209245

Sarah Yasonik authored 4 years ago and Peter Leitzen committed 4 years ago

Adds a class to represent an alert payload, along with
subclasses for different sources of alerts. This is meant
to ultimately replace a subset of alert presenter logic,
Gitlab::Alerting::Alert, and
Gitlab::Alerting::NotificationPayloadParser.

Previously, we would do separate checks for project membership and
confidentiality checks.

This commit adds an optimization that will limit the confidentiality
check to be within the limited projects, if such a limit exists.

This commit streamlines all the initializers to simplify the
inheritance logic for:

- `Gitlab::SearchResults`
    -> `…::ProjectSearchResults`
    -> `…::GroupSearchResults`
    -> `…::SnippetSearchResults`

- `Gitlab::Elastic::SearchResults`
    -> `…::ProjectSearchResults`
    -> `…::GroupSearchResults`

The tests were also deduplicated and streamlined.

These cases are implemented:
* A nuget package upload
* A maven package upload
* A CI artifact upload
* A GraphQL upload
* A user avatar upload
* A git LFS upload
* A group import upload
* A project import upload

Lukas Eipert authored 4 years ago and Justin Ho Tuan Duong committed 4 years ago

Fix all tests relating to GlIcon

When moving to the start / end, the min / max position must also be
available to position the new item to

Mehmet Emin INAC authored 4 years ago and Mayra Cabrera committed 4 years ago

The `require_migration!` helper method can be used to require migration
files in our specs.

Unpositioned designs are sorted by ID, so we need to explictly specify
that order when calling `move_nulls_to_end`.

We also always need to reload the design objects in case their position
was changed in the DB by the `move_nulls_to_end` call.

Create a resource_iteration_event record when iteration changes
on issues or merge_request.