Added the ablity to apply a suggestion with a custom commit message

Adds the widget resources to StartupJS

Replace how to merge HAML
modal with new Vue compenent
and delete old code.

Closes #241784

Payton Burdette authored 4 years ago and Miguel Rincon committed 4 years ago

Move status scss into a
page bundle.

Jean du Plessis authored 4 years ago and Phil Hughes committed 4 years ago

Since the styles in diff.scss does not relate to a specific page,
and is used in many parts of the site, it is more relevant to have
it placed in the framework directory.

Brandon Labuschagne authored 4 years ago and Simon Knox committed 4 years ago

And into a page specific bundle which is imported in the
merge requests page.

Miguel Rincon authored 4 years ago and Jacques Erasmus committed 4 years ago

In this change we wrap the CSS of the pipeline table that only appears
in 4 pages, inside a `[data-page]` selector to scope where it is used.

Additionally some unused/abandoned styles are removed.

Nathan Friend authored 4 years ago and Gabriel Mazetto committed 4 years ago

This commit strips markdown from og:description meta tags by providing
page_description with the HTML-rendered version of the page's
description. The end result is that og:description is rendered with a
plain version of the text, because page_description strips out HTML.

It has been enabled for a while without major issues, we can rm it

This reverts merge request !42625

This reverts merge request !40424

Samantha Ming authored 4 years ago and Martin Wortschack committed 4 years ago

Issue: #237921

- This is part 1 of 2.
- In this MR we will be setting up support of adding
Reviewers in the sidbar widget.
- Part 2 will be adding the corresponding Vue components.

Phil Hughes authored 4 years ago and Igor Drozdov committed 4 years ago

Closes #230991

euko authored 4 years ago and Kushal Pandya committed 4 years ago

Also added a js class in haml as a render target

Apply suggested patch

Update relevant specs

Add js-lock-issue-data and update mock noteable data
Test issuable_header_warnings for both mr and issue

Move to vue_shared

Update issuable header warning component

Also update the spec

Apply the suggestions from the second review round

Re-organize the spec
Remove not needed mock data

André Luís authored 4 years ago and Igor Drozdov committed 4 years ago

Basically we want to avoid adding the diffs_metadata.json
request to startup.js if the page is not rendering the
Changes tab right away.

This adds a user preference to view diffs file-by-file instead
of viewing all the diff files in one big list.
This helps with performance on large merge request,
but it can also be handy sometimes to view merge requests
file-by-file instead of in a full list of files.

The option to enable this feature is inside of user prefences.
For now this is also behind a feature flag so we can roll
this out safely.

gitlab-org/gitlab#222790

Update page and breadcrumb titles to support
internationalization

Update PO files

This moves all the frontend batch comments related code
out of the EE folder and into core

Part of #28154

Closes #119036

This MR migrates the old fa-spinner class to the newer
spinner class.

This bring the loading icons inline with our design system.

Phil Hughes authored 5 years ago and Douglas Barbosa Alexandre committed 5 years ago

This moves the description of the merge request
into a 'Overview' tab. The overview tab will now hold
the merge request widget, description and discussions.

gitlab-org/gitlab#33813

Justin Boyson authored 5 years ago and Martin Wortschack committed 5 years ago

File navigation is broken though.

Add missing import

Make tooltip unique

Add support for reports_approval type in UI

Additional UI

- Show report_approval type of approval rules in MR iwdget text
* Add toolips to report approval types in the approvals section
* Add tooltip help links from rails view helper

Refactor approver check popover to use in MR widget

* Decouple from project list vue component

* Refactor approver check component and decouple it from

Add tooltips to MR approvals widget

Add path helper for approval rules docs

Run prettier, linter, add changelog

Update Pot file and fix unit test errors

Add additional unit tests

Fix haml linter errors

Tweak tooltip layout

Update approval_check_popover to use config

* Refactor to use config object instead of several computed props

Refactor popover to not use internal _uuid

Run prettier

Igor Drozdov authored 5 years ago and Mayra Cabrera committed 5 years ago

- Extract MR fields for notes into a separate serializer
- Check if pipelines are empty via count

Stan Hu authored 5 years ago and Ash McKenzie committed 5 years ago

A nonce-based Content-Security-Policy thwarts XSS attacks by allowing
inline JavaScript to execute if the script nonce matches the header
value. Rails 5.2 supports nonce-based Content-Security-Policy headers,
so provide configuration to enable this and make it work.

To support this, we need to change all `:javascript` HAML filters to the
following form:

```
= javascript_tag nonce: true do
  :plain
    ...
```

We use `%script` throughout our HAML to store JSON and other text, but
since this doesn't execute, browsers don't appear to block this content
from being used and require the nonce value to be present.

Stan Hu authored 5 years ago and Ash McKenzie committed 5 years ago

A nonce-based Content-Security-Policy thwarts XSS attacks by allowing
inline JavaScript to execute if the script nonce matches the header
value. Rails 5.2 supports nonce-based Content-Security-Policy headers,
so provide configuration to enable this and make it work.

To support this, we need to change all `:javascript` HAML filters to the
following form:

```
= javascript_tag nonce: true do
  :plain
    ...
```

We use `%script` throughout our HAML to store JSON and other text, but
since this doesn't execute, browsers don't appear to block this content
from being used and require the nonce value to be present.

Tomislav Nikić authored 5 years ago and Dan Davison committed 5 years ago

All the changes done to files that are also inside CE and need to be
ported.

Fixed an old ui test creating comments and resolving discussions.
There was need to delete and change some specific selectors using the
new way to define selectors.

The merge request widget has a section that includes which issues may be
closed or mentioned based on the merge request description. The problem
is that rendering and redacting Markdown can be expensive, especially
since the browser polls for the data every 10 seconds.

Since these links don't change much and are just nice to have, we only
load them on first page load. The frontend will use the existing data if
the data doesn't appear on subsequent requests.

This saves about 30% of the rendering time of this endpoint, which adds
up to significant savings considering that
`MergeRequestsController#show.json` is called over a million times a day
on GitLab.com.

Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/63546

Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/56523

Annabel Dunstone Gray authored 5 years ago and Phil Hughes committed 5 years ago

- Makes activity dropdown and resolved counter smaller
- Uses grid for spacing
- Removes scrolling on MR tabs