Fix Layout/ArgumentAlignment offenses in models

The `ancestor?` check needs to be expired after the source branch is
fetched.

Phil Hughes authored 1 year ago and Stan Hu committed 1 year ago

Previously, the following was happening:

1. Merge request form gets submitted.
2. User gets direct to merge request page, which loads the widget.
3. The value for `ff_merge_possible?` gets cached incorrectly.

In between steps 1 and 2, the async diff creation is happening, which
actually fetches the ref into the project. If the ref is fetched after
the page is loaded, the widget will cache the wrong value, and the
state won't expire until either the target branch SHA changes or the
diff head SHA changes.

Changelog: fixed

Fixes auto-correctable RuboCop offenses for Style/EmptyElse in excludes

Changelog: other

Vasilii Iakliushin authored 1 year ago and Andy Schoenen committed 1 year ago

Contributes to #395480

**Problem**

Empty repositories can have an default branch that doesn't point
anywhere. Attempt to access their `sha` will raise a NoMethodError.

**Solution**

Verify that the default branch points to an existing commit before
requesting `sha`.

Changelog: fixed

Toon Claes authored 1 year ago and Matthias Käppler committed 1 year ago

Getting all the License metadata turned to be working well, so now we
can remove the feature flag and fully rely on Gitaly providing that
information.

Issue: #374300
Changelog: added

yanhui authored 1 year ago and Kassio Borges committed 1 year ago

1.app/models/repository.rb
 add move_file move_dir_files function
2.app/models/wiki.rb
 call move_dir_files when update wiki page
3.spec/models/repository_spec.rb
 add repository tests
4.spec/models/wiki_page_spec.rb
 add wiki page test

Changelog: changed
MR: gitlab-org/gitlab!112275

Jerry Seto authored 2 years ago and Vasilii Iakliushin committed 2 years ago

* Update gitaly gem
* Update FindCommit requests for the commits view to include tags

Contributes to: #18795
Changelog: added

Accept kwargs instead to be able to pass target_sha.
Target sha is used to avoid a race condition on merge

Changelog: other

Contributes to #386627

* Remove `FindCommit` request to Gitaly

Changelog: performance

Part of #389522

Contributes to #386627

**Problem**

Each request to fetch `readme_path` or `avatar_path` causes two Gitaly
requests: `FindCommit` and `GetTreeEntries`. It's not efficient.

**Solution**

Remove `FindCommit` request and rely on the default branch to fetch
repository tree.

Contributes to #387703

Unfortunately, the proposed solution was not performant enough during
testing. `SearchFilesByName` requests cannot be cached and worsen the
performance instead of improving it.

I remove the feature flag and new experimental code, in favor of a
different solution.

Changelog: other

Contributes to #388252

The feature was released in 15.8. It should be safe to remove it.

Changelog: other

Contributes to gitlab-org/gitlab#386627

**Problem**

The same way as in
gitlab-org/gitlab!108609, we
unefficiently fetch avatar from the repository. We use two Gitaly calls,
however only one is enough.

**Solution**

Apply the same logic as for `readme_url` discovery.

Contributes to #386627

**Problem**

`readme_path` detection is not optimized and triggers two Gitaly queries
just to detect the readme path.

**Solution**

* Remove unnecessary `FindCommit` call
* Use `SearchFileByName` API instead of `GetTreeEntries`

Contributes to #386479

**Problem**

Trailing spaces in the search query prevent users from finding commits.

**Solution**

Remove trailing spaces from the search query.

Alan (Maciej) Paruszewski authored 2 years ago and GitLab Release Tools Bot committed 2 years ago

Merge branch 'security-blind-ssrf-import' into 'master'

See merge request gitlab-org/security/gitlab!2191

Changelog: security

Feature flags in Gitaly was in a weird state. GitLab Rails pre-evaluates
the flags, then passes to Gitaly via gRPC metadata or indirectly through
internal APIs and workhorse. When evaluate gRPC metadata, feature flags
are not evaluated with any actors. In other words, all feature flags are
global in the context of RPCs. In contrast, feature flags in other
locations support actors partially—only Project actor is allowed. This
inconsistency creates plenty of troubles while delivering Gitaly
changes.

This commit enhances the feature flag situation by:
* Introduce Repository actor, dedicated for Gitaly
* Implement a collector in Gitaly client to collect possible actors for
pre-evaluation
* Apply actor collector to Gitaly commit service as a POC for this
approach

Issue: gitaly#4459


Changelog: other
EE: true
Signed-off-by: Quang-Minh Nguyen <qmnguyen@gitlab.com>

Contributes to gitlab-org/gitlab#325871

**Problem**

Method `tag_names_contains` supports limit parameter, but it's missing
for `branch_names_contains`.

Gitaly has changed it's interface so it provides all the details about
the software license of a repo.

This change, behind a feature flag, removes the use of the Licensee gem
for this purpose, and solely depends on Gitaly to provide all
information on the license.

Licensee is still used for license templates and linking to a license in
for example the specs.

Changelog: performance
Roll-out-Issue: #374300

We're about to remove the use of Licensee for license detection and
getting all the metadata about a license.

With this change we're preparing the code to support a different class
that provides all the license data.

This reverts merge request !77041

Changelog: fixed

Gitaly has changed it's interface so it provides all the details about
the software license of a repo.

This change, behind a feature flag, removes the use of the Licensee gem
for this purpose, and solely depends on Gitaly to provide all
information on the license.

Licensee is still used for license templates and linking to a license in
for example the specs.

Changelog: performance
Roll-out-Issue: #374300

We're about to remove the use of Licensee for license detection and
getting all the metadata about a license.

With this change we're preparing the code to support a different class
that provides all the license data.

Allen Cook authored 2 years ago and Alexander Turinske committed 2 years ago

Changelog: added

`multi_action` is not very specific. The RPC that this method uses is
called UserCommitFiles so it makes sense to name the method after this.

Now that we want to fetch context commits based on author and committed
date filters as well, fetch context commits api was updated to use
list_commits grpc call and required parameters being passed.

Changelog: added

Igor Drozdov authored 2 years ago and GitLab Release Tools Bot committed 2 years ago

Merge branch 'security-id-skip-flat-paths-for-tree-entries' into 'master'

See merge request gitlab-org/security/gitlab!2596

Changelog: security

Contributes to #366724

**Problem**

Testing of protected branches cache discovered a missing use-case for
expiration logic. When the new branch is created, we should expire
cache for protected branches too.

**Solution**

Extend `expire_branches_cache` logic with expiration of protected
branches cache.

Changelog: fixed

Contributes to https://gitlab.com/gitlab-org/gitlab/-/issues/368614

**Problem**

We expire the branch cache after every new created branch. It's
inefficient and leads to N extra Redis calls.

**Solution**

Expire cache once after adding all new branches.

Changelog: performance

George Koltsov authored 2 years ago and GitLab Release Tools Bot committed 2 years ago

Merge branch 'security-remove-prohibited-branches-after-import' into 'master'

See merge request gitlab-org/security/gitlab!2587

Changelog: security

Linjie Zhang authored 2 years ago and Mayra Cabrera committed 2 years ago

Add `config_file` param for repository changelog api to specify
the changelog configuration file path.

Changelog: changed

Patrick Steinhardt authored 2 years ago and Sean Arnold committed 2 years ago

Remove the feature flag that guards the use of the quarantine directory
when enumerating new commits for access checks. With this feature flag
gone, enumerating new commits is going to be a lot faster in repos with
many references given that we don't have to walk the repository's object
graph anymore, but instead only have to take a peek into the quarantine
directory that contains all new objects.

With the feature flag gone, there are no callers of `#new_commits`
anymore which disable use of the quarantine directory. So let's also
drop that parameter while at it.

Changelog: performance

Currently we list all non-standard ref namespaces, e.g.
`refs/merge-requests` in the `Repository` model with the sole exception
of `refs/tmp`, making the latter difficult to discover.

Let's add `tmp` to this list so we have a single location that contains
all custom ref directories used by GitLab.

Explicitly require licensee/license file in order to use
Licensee::InvalidLicense class defined in
https://github.com/licensee/licensee/blob/v9.14.1/lib/licensee/license.rb#L6

The problem is that nested classes are not automatically preloaded
which may lead to uninitialized constant exception being raised:
#356658

The exception is usually raised in dev environment causing
inconvenience

Changelog: fixed

Timo Furrer authored 2 years ago and Vasilii Iakliushin committed 2 years ago

This change adds support for a `execute_filemode` field in the
[Repository Files
API](https://docs.gitlab.com/ee/api/repository_files.html)
endpoints, much like it's already available in the
[Commits API](https://docs.gitlab.com/ee/api/commits.html).

The driver for this change is the `gitlab_repository_file` resource in
the Terraform GitLab Provider. This resource allows to manage a file
using the Repository Files API, but wasn't supporting to control the
executable flag on those files.

Changelog: added
MR: !83499