John Mason authored 2 years ago and Dmitry Gruzd committed 2 years ago

Changelog: changed

John Mason authored 2 years ago and Dylan Griffith committed 2 years ago

Changelog: changed

Rate limit several endpoints where
users can lookup other users by email

Changelog: added

We currently get quite a few `ActiveRecord::QueryCancelled`
errors. This adds handling for this error in the following:

* The autocomplete web action
* All API actions

Changelog: changed

This allows us to use the same categorization for endpoints as we do
for Sidekiq workers.

It allows us to not use subjective names for these categories, but use
urgencies as users would expect the endpoints to behave.

Quang-Minh Nguyen authored 3 years ago and Bob Van Landuyt committed 3 years ago

Changelog: added

Changelog: fixed

The current timeout defaults to 15s. Per
https://gitlab.com/gitlab-org/gitlab/-/issues/327106 this endpoint
consumes a considerable amount of DB time. Since this endpoint is not as
essential as the primary task the user is performing (since it is used
to generate tab counts for other tabs you aren't searching) it makes
sense to reduce the timeout so slower counts don't consume too much
resources.

These requests are typically loaded by the same user repeatedly as they
switch tabs on the search page. Considering that Elasticsearch indexing
is only updated every 1-2 minutes anyway the 1 minute browser side cache
shouldn't really be noticeable to users except for loading counts
faster.

This is also using a `private` cache (default for `expires_in`) so that
it is not cached by intermediate proxies. This is important since each
user's permissions is considered in a search.

  - Use feature flag defaul_enabled: :yaml
  - Remove individual check from RedisTracking concern
  - Remove check for feature flag in shared example

Zack Cuddy authored 4 years ago and Scott Hampton committed 4 years ago

This reverts merge request
!47344

This reverts merge request !46595

Zack Cuddy authored 4 years ago and Bob Van Landuyt committed 4 years ago

This creates a search facet sidebar
for issues and merge requests.

This also converts the
status and confidential
filter from a dropdown
to a radio button.

Dylan Griffith authored 4 years ago and Kerri Miller committed 4 years ago

At present the merge request result page has an old design and we want
it to match the issue design which was recently updated.

It seems the best way to do this was to share code so we've extracted a
shared HAML template for both of these.

Zack Cuddy authored 4 years ago and Mark Chao committed 4 years ago

This change is behind a feature
flag :search_facets.

This was split off for the sake
of MVC and the final product
can be seen here:
!46595

This change replaces the dropdown
filter with radio buttons.

These will then be used as
the components in the
sidebar in the next MR.

Dmitry Gruzd authored 4 years ago and Natalia Tepluhina committed 4 years ago

When searching for Issues and Merge Request sometimes you don't want to
see the most accurate result. You might want to see the the newest
result.
Now you can change from Relevant results to newest or oldest results. As
we add more filtering in the future this will be even more valuable.

Terri Chu authored 4 years ago and Dylan Griffith committed 4 years ago

If a user searches for a commit in a project and only finds
one result, redirect the user to that result. This already
exists for basic search and now is enabled for advanced
search. Added a notice explaining the redirect with a
link back to search results.

Micaël Bergeron authored 4 years ago and Miguel Rincon committed 4 years ago

This adds a method to bold the search
term on the issues results page.