Skip to content
GitLab
Next
Menu
Why GitLab
Pricing
Contact Sales
Explore
Why GitLab
Pricing
Contact Sales
Explore
Sign in
Get free trial
Primary navigation
Search or go to…
Project
GitLab
Manage
Activity
Members
Labels
Plan
Issues
Issue boards
Milestones
Iterations
Requirements
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Snippets
Locked files
Build
Pipelines
Jobs
Pipeline schedules
Test cases
Artifacts
Deploy
Releases
Package Registry
Container Registry
Model registry
Operate
Environments
Terraform modules
Monitor
Incidents
Service Desk
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Code review analytics
Issue analytics
Insights
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Privacy statement
Keyboard shortcuts
?
What's new
4
Snippets
Groups
Projects
Show more breadcrumbs
GitLab.org
GitLab
Commits
fb5a34ad
Commit
fb5a34ad
authored
2 years ago
by
Valerie Burton
Browse files
Options
Downloads
Patches
Plain Diff
Update invite_group_to_project_spec to run in jobs outside nightly
parent
8b1b556f
No related branches found
No related tags found
1 merge request
!91071
Refactor invite_group_to_project_spec to Run in More Jobs Outside Nightly
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
qa/qa/page/component/invite_members_modal.rb
+7
-5
7 additions, 5 deletions
qa/qa/page/component/invite_members_modal.rb
qa/qa/specs/features/browser_ui/1_manage/project/invite_group_to_project_spec.rb
+4
-12
4 additions, 12 deletions
...owser_ui/1_manage/project/invite_group_to_project_spec.rb
with
11 additions
and
17 deletions
qa/qa/page/component/invite_members_modal.rb
+
7
−
5
View file @
fb5a34ad
...
...
@@ -62,12 +62,14 @@ def invite_group(group_name, access_level = 'Guest')
Support
::
Waiter
.
wait_until
{
has_element?
(
:group_select_dropdown_item
)
}
# Helps stabilize race condition with concurrent group API calls while searching
# TODO: Replace with `fill_element :group_select_dropdown_search_field, group_name` when this bug is resolved: https://gitlab.com/gitlab-org/gitlab/-/issues/349379
send_keys_to_element
(
:group_select_dropdown_search_field
,
group_name
)
# Workaround for race condition with concurrent group API calls while searching
# Remove Retrier after https://gitlab.com/gitlab-org/gitlab/-/issues/349379 is resolved
Support
::
Retrier
.
retry_on_exception
do
fill_element
:group_select_dropdown_search_field
,
group_name
Support
::
WaitForRequests
.
wait_for_requests
click_button
group_name
end
Support
::
WaitForRequests
.
wait_for_requests
click_button
group_name
set_access_level
(
access_level
)
end
...
...
This diff is collapsed.
Click to expand it.
qa/qa/specs/features/browser_ui/1_manage/project/invite_group_to_project_spec.rb
+
4
−
12
View file @
fb5a34ad
# frozen_string_literal: true
module
QA
# Tagging with issue for a transient invite group modal search bug, but does not require quarantine at this time
RSpec
.
describe
'Manage'
,
:transient
,
issue:
'https://gitlab.com/gitlab-org/gitlab/-/issues/349379'
do
RSpec
.
describe
'Manage'
do
describe
'Invite group'
do
shared_examples
'invites group to project'
do
it
'verifies group is added and members can access project with correct access level'
do
...
...
@@ -13,7 +12,7 @@ module QA
expect
(
project_members
).
to
have_group
(
group
.
path
)
end
Flow
::
Login
.
sign_in
(
as:
@
user
)
Flow
::
Login
.
sign_in
(
as:
user
)
Page
::
Dashboard
::
Projects
.
perform
do
|
projects
|
projects
.
filter_by_name
(
project
.
name
)
...
...
@@ -29,13 +28,11 @@ module QA
end
end
before
(
:context
)
do
@user
=
Resource
::
User
.
fabricate_or_use
(
Runtime
::
Env
.
gitlab_qa_username_1
,
Runtime
::
Env
.
gitlab_qa_password_1
)
end
let
(
:user
)
{
Resource
::
User
.
fabricate_or_use
(
Runtime
::
Env
.
gitlab_qa_username_1
,
Runtime
::
Env
.
gitlab_qa_password_1
)
}
before
do
Flow
::
Login
.
sign_in
group
.
add_member
(
@
user
,
Resource
::
Members
::
AccessLevel
::
MAINTAINER
)
group
.
add_member
(
user
,
Resource
::
Members
::
AccessLevel
::
MAINTAINER
)
project
.
visit!
end
...
...
@@ -75,11 +72,6 @@ module QA
it_behaves_like
'invites group to project'
end
after
do
project
&
.
remove_via_api!
group
&
.
remove_via_api!
end
end
end
end
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment