Merge branch...

Merge branch '442878-remove-the-default-value-for-requesting_user_id-from-unassignissuablesworker' into 'master' 

Remove default value for requesting_user_id argument

See merge request !146832



Merged-by: Stan Hu <stanhu@gmail.com>
Approved-by: Thomas Hutterer <thutterer@gitlab.com>
Approved-by: Stan Hu <stanhu@gmail.com>
Co-authored-by: Eulyeon Ko <eko@gitlab.com>

app/workers/members_destroyer/unassign_issuables_worker.rb

@@ -15,9 +15,7 @@ class UnassignIssuablesWorker
 
     idempotent!
 
-    # Remove the default value `nil` for `requesting_user_id` after 16.10.
-    # TODO: https://gitlab.com/gitlab-org/gitlab/-/issues/442878
-    def perform(user_id, entity_id, entity_type, requesting_user_id = nil)
+    def perform(user_id, entity_id, entity_type, requesting_user_id)
       unless ENTITY_TYPES.include?(entity_type)
         logger.error(
           message: "#{entity_type} is not a supported entity.",
@@ -42,9 +40,7 @@ def perform(user_id, entity_id, entity_type, requesting_user_id = nil)
         return
       end
 
-      # Remove the condition requesting_user_id after 16.10.
-      # TODO: https://gitlab.com/gitlab-org/gitlab/-/issues/442878
-      requesting_user = requesting_user_id && User.find(requesting_user_id)
+      requesting_user = User.find(requesting_user_id)
       user = User.find(user_id)
       entity = entity_type.constantize.find(entity_id)