Skip to content
GitLab
Next
Menu
Why GitLab
Pricing
Contact Sales
Explore
Why GitLab
Pricing
Contact Sales
Explore
Sign in
Get free trial
Primary navigation
Search or go to…
Project
GitLab
Manage
Activity
Members
Labels
Plan
Issues
Issue boards
Milestones
Iterations
Requirements
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Snippets
Locked files
Build
Pipelines
Jobs
Pipeline schedules
Test cases
Artifacts
Deploy
Releases
Package Registry
Container Registry
Model registry
Operate
Environments
Terraform modules
Monitor
Incidents
Service Desk
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Code review analytics
Issue analytics
Insights
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Privacy statement
Keyboard shortcuts
?
What's new
4
Snippets
Groups
Projects
Show more breadcrumbs
GitLab.org
GitLab
Commits
f7c6bed2
Commit
f7c6bed2
authored
2 years ago
by
Thong Kuah
Committed by
Suzanne Selhorn
2 years ago
Browse files
Options
Downloads
Patches
Plain Diff
While reviewing, should test the merge request locally
parent
85c761ec
No related branches found
No related tags found
2 merge requests
!96059
Draft: Add GraphQL query for deployment details
,
!95420
While reviewing, should test the merge request locally
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
doc/development/code_review.md
+2
-0
2 additions, 0 deletions
doc/development/code_review.md
with
2 additions
and
0 deletions
doc/development/code_review.md
+
2
−
0
View file @
f7c6bed2
...
...
@@ -468,6 +468,8 @@ experience, refactors the existing code). Then:
-
Offer alternative implementations, but assume the author already considered
them. ("What do you think about using a custom validator here?")
-
Seek to understand the author's perspective.
-
Check out the branch, and test the changes locally. You can decide how much manual testing you want to perform.
Your testing might result in opportunities to add automated tests.
-
If you don't understand a piece of code, _say so_. There's a good chance
someone else would be confused by it as well.
-
Ensure the author is clear on what is required from them to address/resolve the suggestion.
...
...
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment