Skip to content
Snippets Groups Projects
Commit eff23f64 authored by Brian Rhea's avatar Brian Rhea :speech_balloon:
Browse files

Merge branch 'master' into add-eos-to-dep-rem-examples

parents f6dff34e 4d6d1506
No related branches found
No related tags found
1 merge request!89182Updates to Deprecation and Removal examples
Hide whitespace changes
Inline Side-by-side
Showing
with 263 additions and 131 deletions
.gitlab/CODEOWNERS
+ 1
− 1
View file @ eff23f64
......@@ -792,7 +792,7 @@ lib/gitlab/checks/** @proglottis @toon @zj-gitlab
/doc/user/reserved_names.md @fneill
/doc/user/search/advanced_search.md @sselhorn
/doc/user/search/global_search/advanced_search_syntax.md @sselhorn
/doc/user/search/index.md @aqualls
/doc/user/search/index.md @sselhorn
/doc/user/shortcuts.md @aqualls
/doc/user/snippets.md @aqualls
/doc/user/ssh.md @eread
......
.gitlab/ci/docs.gitlab-ci.yml
+ 2
− 2
View file @ eff23f64
......@@ -44,7 +44,7 @@ docs-lint markdown:
- .default-retry
- .docs:rules:docs-lint
# When updating the image version here, update it in /scripts/lint-doc.sh too.
image: registry.gitlab.com/gitlab-org/gitlab-docs/lint-markdown:alpine-3.15-vale-2.16.1-markdownlint-0.31.1
image: ${REGISTRY_HOST}/${REGISTRY_GROUP}/gitlab-docs/lint-markdown:alpine-3.15-vale-2.16.1-markdownlint-0.31.1
stage: lint
needs: []
script:
......@@ -53,7 +53,7 @@ docs-lint markdown:
docs-lint links:
extends:
- .docs:rules:docs-lint
image: registry.gitlab.com/gitlab-org/gitlab-docs/lint-html:alpine-3.15-ruby-2.7.5-e6a8a48a
image: ${REGISTRY_HOST}/${REGISTRY_GROUP}/gitlab-docs/lint-html:alpine-3.15-ruby-2.7.5-e6a8a48a
stage: lint
needs: []
script:
......
.gitlab/ci/global.gitlab-ci.yml
+ 1
− 1
View file @ eff23f64
......@@ -281,7 +281,7 @@
- name: postgres:12
command: ["postgres", "-c", "fsync=off", "-c", "synchronous_commit=off", "-c", "full_page_writes=off"]
- name: redis:6.0-alpine
- name: elasticsearch:8.1.1
- name: elasticsearch:8.2.0
variables:
POSTGRES_HOST_AUTH_METHOD: trust
PG_VERSION: "12"
......
.gitlab/ci/reports.gitlab-ci.yml
+ 2
− 2
View file @ eff23f64
......@@ -91,7 +91,7 @@ gemnasium-python-dependency_scanning:
yarn-audit-dependency_scanning:
extends: .ds-analyzer
image: "registry.gitlab.com/gitlab-org/security-products/analyzers/npm-audit:1.4.1"
image: "${REGISTRY_HOST}/${REGISTRY_GROUP}/security-products/analyzers/npm-audit:1.4.1"
variables:
TOOL: yarn
rules: !reference [".reports:rules:yarn-audit-dependency_scanning", rules]
......@@ -102,7 +102,7 @@ yarn-audit-dependency_scanning:
extends: .default-retry
stage: test
image:
name: registry.gitlab.com/gitlab-org/security-products/package-hunter-cli:v1.3.2@sha256:7529deaef9ea21aab56bfb74ae1abbc121311affdb6ece49ce7b1c360f997ca2
name: ${REGISTRY_HOST}/${REGISTRY_GROUP}/security-products/package-hunter-cli:v1.3.2@sha256:7529deaef9ea21aab56bfb74ae1abbc121311affdb6ece49ce7b1c360f997ca2
entrypoint: [""]
variables:
HTR_user: '$PACKAGE_HUNTER_USER'
......
.gitlab/ci/review-apps/dast.gitlab-ci.yml
+ 17
− 101
View file @ eff23f64
......@@ -5,12 +5,12 @@
extends:
- .reports:rules:schedule-dast
image:
name: "registry.gitlab.com/security-products/dast:$DAST_VERSION"
name: "${REGISTRY_HOST}/security-products/dast:$DAST_VERSION"
resource_group: dast_scan
variables:
DAST_USERNAME_FIELD: "user[login]"
DAST_PASSWORD_FIELD: "user[password]"
DAST_SUBMIT_FIELD: "commit"
DAST_SUBMIT_FIELD: "name:button"
DAST_FULL_SCAN_ENABLED: "true"
DAST_VERSION: 2
GIT_STRATEGY: none
......@@ -28,7 +28,7 @@
needs: ["review-deploy"]
stage: dast
# Default job timeout set to 90m and dast rules needs 2h to so that it won't timeout.
timeout: 2h
timeout: 3h
# Add retry because of intermittent connection problems. See https://gitlab.com/gitlab-org/gitlab/-/issues/244313
retry: 1
artifacts:
......@@ -42,149 +42,65 @@
# DAST scan with a subset of Release scan rules.
# ZAP rule details can be found at https://www.zaproxy.org/docs/alerts/
# 10019, 10021 Missing security headers
# 10023, 10024, 10025, 10037 Information Disclosure
# 10040 Secure Pages Include Mixed Content
# 10056 X-Debug-Token Information Leak
# Duration: 14 minutes 20 seconds
dast:secureHeaders-csp-infoLeak:
dast:anti-clickjacking-header:
extends:
- .dast_conf
variables:
DAST_USERNAME: "user1"
DAST_ONLY_INCLUDE_RULES: "10019,10021,10023,10024,10025,10037,10040,10056"
DAST_ONLY_INCLUDE_RULES: "10020"
script:
- /analyze
# 90023 XML External Entity Attack
# Duration: 41 minutes 20 seconds
# 90019 Server Side Code Injection
# Duration: 34 minutes 31 seconds
dast:XXE-SrvSideInj:
dast:xss-persistant:
extends:
- .dast_conf
variables:
DAST_USERNAME: "user2"
DAST_ONLY_INCLUDE_RULES: "90023,90019"
DAST_ONLY_INCLUDE_RULES: "40014"
script:
- /analyze
# 0 Directory Browsing
# 2 Private IP Disclosure
# 3 Session ID in URL Rewrite
# 7 Remote File Inclusion
# Duration: 63 minutes 43 seconds
# 90034 Cloud Metadata Potentially Exposed
# Duration: 13 minutes 48 seconds
# 90022 Application Error Disclosure
# Duration: 12 minutes 7 seconds
dast:infoLeak-fileInc-DirBrowsing:
dast:insecure-http-method:
extends:
- .dast_conf
variables:
DAST_USERNAME: "user3"
DAST_ONLY_INCLUDE_RULES: "0,2,3,7,90034,90022"
DAST_ONLY_INCLUDE_RULES: "90028"
script:
- /analyze
# 10010 Cookie No HttpOnly Flag
# 10011 Cookie Without Secure Flag
# 10017 Cross-Domain JavaScript Source File Inclusion
# 10029 Cookie Poisoning
# 90033 Loosely Scoped Cookie
# 10054 Cookie Without SameSite Attribute
# Duration: 13 minutes 23 seconds
dast:insecureCookie:
dast:server-side-template-inj:
extends:
- .dast_conf
variables:
DAST_USERNAME: "user4"
DAST_ONLY_INCLUDE_RULES: "10010,10011,10017,10029,90033,10054"
DAST_ONLY_INCLUDE_RULES: "90035"
script:
- /analyze
# 20012 Anti-CSRF Tokens Check
# 10202 Absence of Anti-CSRF Tokens
# https://gitlab.com/gitlab-com/gl-security/appsec/appsec-team/-/issues/192
# Commented because of lot of FP's
# dast:csrfTokenCheck:
# extends:
# - .dast_conf
# variables:
# DAST_USERNAME: "user6"
# DAST_ONLY_INCLUDE_RULES: "20012,10202"
# script:
# - /analyze
# 10098 Cross-Domain Misconfiguration
# 10105 Weak Authentication Method
# 40003 CRLF Injection
# 40008 Parameter Tampering
# Duration: 71 minutes 15 seconds
dast:corsMisconfig-weakauth-crlfInj:
dast:server-side-template-inj-blind:
extends:
- .dast_conf
variables:
DAST_USERNAME: "user5"
DAST_ONLY_INCLUDE_RULES: "10098,10105,40003,40008"
DAST_ONLY_INCLUDE_RULES: "90035"
script:
- /analyze
# 20019 External Redirect
# 20014 HTTP Parameter Pollution
# Duration: 46 minutes 12 seconds
dast:extRedirect-paramPollution:
dast:session-fixation:
extends:
- .dast_conf
variables:
DAST_USERNAME: "user6"
DAST_ONLY_INCLUDE_RULES: "20019,20014"
script:
- /analyze
# 40022 SQL Injection - PostgreSQL
# Duration: 53 minutes 59 seconds
dast:sqlInjection:
extends:
- .dast_conf
variables:
DAST_USERNAME: "user7"
DAST_ONLY_INCLUDE_RULES: "40022"
script:
- /analyze
# 40014 Cross Site Scripting (Persistent)
# Duration: 21 minutes 50 seconds
dast:xss-persistent:
extends:
- .dast_conf
variables:
DAST_USERNAME: "user8"
DAST_ONLY_INCLUDE_RULES: "40014"
script:
- /analyze
# 40012 Cross Site Scripting (Reflected)
# Duration: 73 minutes 15 seconds
dast:xss-reflected:
extends:
- .dast_conf
variables:
DAST_USERNAME: "user9"
DAST_ONLY_INCLUDE_RULES: "40012"
DAST_ONLY_INCLUDE_RULES: "40013"
script:
- /analyze
# 40013 Session Fixation
# Duration: 44 minutes 25 seconds
dast:sessionFixation:
dast:xss-dombased:
extends:
- .dast_conf
variables:
DAST_USERNAME: "user10"
DAST_ONLY_INCLUDE_RULES: "40013"
DAST_ONLY_INCLUDE_RULES: "40026"
script:
- /analyze
.gitlab/ci/review-apps/main.gitlab-ci.yml
+ 1
− 1
View file @ eff23f64
......@@ -77,7 +77,7 @@ review-build-cng:
variables:
HOST_SUFFIX: "${CI_ENVIRONMENT_SLUG}"
DOMAIN: "-${CI_ENVIRONMENT_SLUG}.${REVIEW_APPS_DOMAIN}"
GITLAB_HELM_CHART_REF: "41d7632d9eba84f5816d808b98ccf3f5623e9fb5"
GITLAB_HELM_CHART_REF: "a6a609a19166f00b1a7774374041cd38a9f7e20d"
environment:
name: review/${CI_COMMIT_REF_SLUG}${FREQUENCY}
url: https://gitlab-${CI_ENVIRONMENT_SLUG}.${REVIEW_APPS_DOMAIN}
......
.gitlab/ci/review-apps/qa.gitlab-ci.yml
+ 2
− 0
View file @ eff23f64
......@@ -103,6 +103,7 @@ review-qa-smoke:
extends:
- .review-qa-base
- .review:rules:review-qa-smoke
retry: 1
variables:
QA_RUN_TYPE: review-qa-smoke
RSPEC_TAGS: --tag smoke
......@@ -111,6 +112,7 @@ review-qa-reliable:
extends:
- .review-qa-base
- .review:rules:review-qa-reliable
retry: 1
parallel: 10
variables:
QA_RUN_TYPE: review-qa-reliable
......
.gitlab/ci/rules.gitlab-ci.yml
+ 2
− 4
View file @ eff23f64
......@@ -175,10 +175,8 @@
- ".gitlab/ci/workhorse.gitlab-ci.yml"
.yaml-lint-patterns: &yaml-lint-patterns
- ".gitlab-ci.yml"
- ".gitlab/ci/**/*.yml"
- "data/**/*.yml"
- "lib/gitlab/ci/templates/**/*.yml"
- "*.yml"
- "**/*.yml"
.docs-patterns: &docs-patterns
- ".gitlab/route-map.yml"
......
.gitlab/ci/workhorse.gitlab-ci.yml
+ 1
− 5
View file @ eff23f64
workhorse:verify:
extends: .workhorse:rules:workhorse
image: ${GITLAB_DEPENDENCY_PROXY}golang:1.16
image: ${GITLAB_DEPENDENCY_PROXY}golang:1.17
stage: test
needs: []
script:
......@@ -20,10 +20,6 @@ workhorse:verify:
- scripts/gitaly-test-build
- make -C workhorse test
workhorse:test using go 1.16:
extends: .workhorse:test
image: ${REGISTRY_HOST}/${REGISTRY_GROUP}/gitlab-build-images:debian-${DEBIAN_VERSION}-ruby-2.7-golang-1.16-git-2.31
workhorse:test using go 1.17:
extends: .workhorse:test
image: ${REGISTRY_HOST}/${REGISTRY_GROUP}/gitlab-build-images:debian-${DEBIAN_VERSION}-ruby-2.7-golang-1.17-git-2.31
.gitlab/ci/yaml.gitlab-ci.yml
+ 17
− 2
View file @ eff23f64
# Yamllint of CI-related yaml.
# Yamllint of yaml files.
# This uses rules from project root `.yamllint`.
lint-yaml:
extends:
- .default-retry
- .yaml-lint:rules
image: pipelinecomponents/yamllint:latest
stage: lint
needs: []
script:
- yamllint --strict -f colored .
# The jobs below will not use the configuration present in `.yamllint` (it's because of the -d option)
#
# Docs: https://yamllint.readthedocs.io/en/stable/configuration.html#custom-configuration-without-a-config-file
lint-pipeline-yaml:
extends:
- .default-retry
- .yaml-lint:rules
......@@ -10,7 +25,7 @@ lint-yaml:
variables:
LINT_PATHS: .gitlab-ci.yml .gitlab/ci lib/gitlab/ci/templates data/deprecations data/removals data/whats_new
script:
- yamllint --strict -f colored $LINT_PATHS
- 'yamllint -d "{extends: default, rules: {line-length: disable, document-start: disable}}" $LINT_PATHS'
lint-metrics-yaml:
extends:
......
.gitlab/issue_templates/Geo Replicate a new Git repository type.md
+ 5
− 1
View file @ eff23f64
......@@ -48,9 +48,13 @@ Geo secondary sites have a [Geo tracking database](https://gitlab.com/gitlab-org
- [ ] Create the migration file in `ee/db/geo/migrate`:
```shell
bin/rails generate geo_migration CreateCoolWidgetRegistry
bin/rails generate migration CreateCoolWidgetRegistry --database geo
```
Geo should continue using `Gitlab::Database::Migration[1.0]` until the `gitlab_geo` schema is supported, and is for the time being exempt from being validated by `Gitlab::Database::Migration[2.0]`. This requires a developer to manually amend the migration file to change from `[2.0]` to `[1.0]` due to the migration defaults being 2.0.
For more information, see the [Enable Geo migrations to use Migration[2.0]](https://gitlab.com/gitlab-org/gitlab/-/issues/363491) issue.
- [ ] Replace the contents of the migration file with the following. Note that we cannot add a foreign key constraint on `cool_widget_id` because the `cool_widgets` table is in a different database. The application code must handle logic such as propagating deletions.
```ruby
......
.gitlab/issue_templates/Geo Replicate a new blob type.md
+ 5
− 1
View file @ eff23f64
......@@ -50,9 +50,13 @@ Geo secondary sites have a [Geo tracking database](https://gitlab.com/gitlab-org
- [ ] Create the migration file in `ee/db/geo/migrate`:
```shell
bin/rails generate geo_migration CreateCoolWidgetRegistry
bin/rails generate migration CreateCoolWidgetRegistry --database geo
```
Geo should continue using `Gitlab::Database::Migration[1.0]` until the `gitlab_geo` schema is supported, and is for the time being exempt from being validated by `Gitlab::Database::Migration[2.0]`. This requires a developer to manually amend the migration file to change from `[2.0]` to `[1.0]` due to the migration defaults being 2.0.
For more information, see the [Enable Geo migrations to use Migration[2.0]](https://gitlab.com/gitlab-org/gitlab/-/issues/363491) issue.
- [ ] Replace the contents of the migration file with the following. Note that we cannot add a foreign key constraint on `cool_widget_id` because the `cool_widgets` table is in a different database. The application code must handle logic such as propagating deletions.
```ruby
......
.gitlab/issue_templates/Service Ping reporting and monitoring.md 0 → 100644
+ 122
− 0
View file @ eff23f64
<!-- This issue template is used by https://about.gitlab.com/handbook/engineering/development/growth/product-intelligence/ for tracking effort around Service Ping reporting for GitLab.com -->
The [Product Intelligence group](https://about.gitlab.com/handbook/engineering/development/growth/product-intelligence/) runs manual reporting of ServicePing for GitLab.com on a weekly basis. This issue captures:
- Captures the work required to complete the reporting process,.
- Captures the follow-up tasks that are focused on metrics performance verification.
- Identifies any potential issues.
# New metrics to be verified
<!-- Add new metrics that must be verified -->
# Failed metrics
Broken metrics issues are marked with the ~"broken metric" label.
# Use a detached screen session to generate Service Ping for GitLab.com
## Prerequisites
1. Make sure the SSH key is added to the local SSH agent: `ssh-add`.
## Triggering
1. Add the SSH key to the local SSH agent: `ssh-add`.
1. Connect to the bastion with SSH agent forwarding: `ssh -A lb-bastion.gprd.gitlab.com`.
1. Note which bastion host machine was assigned. For example: `<username>@bastion-01-inf-gprd.c.gitlab-production.internal:~$` shows that you are connected to `bastion-01-inf-gprd.c.gitlab-production.internal`.
1. Create a named screen: `screen -S $USER-service-ping-$(date +%F)`.
1. Connect to the console host: `ssh $USER-rails@console-01-sv-gprd.c.gitlab-production.internal`.
1. Run: `ServicePing::SubmitService.new.execute`.
1. Press <kbd>Control</kbd>+<kbd>a</kbd> followed by <kbd>Control</kbd>+<kbd>d</kbd> to detach from the screen session.
1. Exit from the bastion: `exit`.
## Verification (After approximately 30 hours)
1. Reconnect to the bastion: `ssh -A lb-bastion.gprd.gitlab.com`. Make sure that you are connected to the same host machine that ServicePing was started on. For example, to connect directly to the host machine, use `ssh bastion-01-inf-gprd.c.gitlab-production.internal`.
1. Find your screen session: `screen -ls`.
1. Attach to your screen session: `screen -x 14226.mwawrzyniak_service_ping_2021_01_22`.
1. Check the last payload in the `raw_usage_data` table: `RawUsageData.last.payload`.
1. Check the when the payload was sent: `RawUsageData.last.sent_at`.
## Stop the Service Ping process
Use either of these processes:
1. Reconnect to the bastion host machine. For example, use: `ssh bastion-01-inf-gprd.c.gitlab-production.internal`.
1. Find your screen session: `$ screen -ls`.
1. Attach to your screen session: `$ sudo -u <username> screen -r`.
1. Press <kbd>Control</kbd>+<kbd>c</kbd> to stop the Service Ping process.
OR
1. Reconnect to the bastion host machine. For example, type: `ssh bastion-01-inf-gprd.c.gitlab-production.internal`.
1. List all process started by your username: `ps faux | grep <username>`.
1. Locate the username that owns ServicePing reporting.
1. Send the kill signal for the ServicePing PID: `kill -9 <service_ping_pid>`.
## Service Ping process triggering (through a long-running SSH session)
1. Connect to the `gprd` Rails console.
1. Run `SubmitUsagePingService.new.execute`. This process requires more than 30 hours to complete.
1. Find the last payload in the `raw_usage_data` table: `RawUsageData.last.payload`.
1. Check the when the payload was sent: `RawUsageData.last.sent_at`.
```plaintext
ServicePing::SubmitService.new.execute
# Get the payload
RawUsageData.last.payload
# Time when payload was sent to VersionsAppp
RawUsageData.last.sent_at
```
# Verify Service Ping in VersionsApp
To verify that the ServicePing was received in the VersionsApp do the following steps:
1. Go to the VersionsApp console and locate: `RawUsageData.find(uuid: '')`.
1. Check the object. Either:
- Go to the Rails console and check the related `RawUsageData` object.
- Go to the VersionsApp UI <https://version.gitlab.com/usage_data/usage_data_id>.
```ruby
/bin/herokuish procfile exec rails console
puts UsageData.select(:recorded_at, :app_server_type).where(hostname: 'gitlab.com', uuid: 'ea8bf810-1d6f-4a6a-b4fd-93e8cbd8b57f').order('id desc').limit(5).to_json
puts UsageData.find(21635202).raw_usage_data.payload.to_json
```
# Monitoring events tracked using Redis HLL
Trigger some events from the User Interface.
```ruby
Gitlab::UsageDataCounters::HLLRedisCounter.unique_events(event_names: 'event_name', start_date: 28.days.ago, end_date: Date.current)
```
# What to do if you get mentioned
In this issue, we keep the track of new metrics added to the Service Ping, and the metrics that are timing out.
If you get mentioned, check the failing metric and open an optimization issue.
# Service Ping manual generation for GitLab.com schedule
| Generation start date | GitLab developer handle | Link to comment with payload |
| --------------------- | ----------------------- | ---------------------------- |
| 2022-04-18 | | |
| 2022-04-25 | | |
| 2022-05-02 | | |
| 2022-05-09 | | |
| 2022-05-16 | | |
<!-- Do not edit below this line -->
/confidential
/label ~"group::product intelligence" ~"devops::growth" ~backend ~"section::growth" ~"Category:Service Ping"
/epic https://gitlab.com/groups/gitlab-org/-/epics/6000
/weight 5
/title Monitor and Generate GitLab.com Service Ping
.rubocop_todo/gitlab/namespaced_class.yml
+ 0
− 2
View file @ eff23f64
......@@ -798,7 +798,6 @@ Gitlab/NamespacedClass:
- 'app/workers/merge_request_mergeability_check_worker.rb'
- 'app/workers/merge_worker.rb'
- 'app/workers/migrate_external_diffs_worker.rb'
- 'app/workers/namespaceless_project_destroy_worker.rb'
- 'app/workers/new_issue_worker.rb'
- 'app/workers/new_merge_request_worker.rb'
- 'app/workers/new_note_worker.rb'
......@@ -821,7 +820,6 @@ Gitlab/NamespacedClass:
- 'app/workers/project_daily_statistics_worker.rb'
- 'app/workers/project_destroy_worker.rb'
- 'app/workers/project_export_worker.rb'
- 'app/workers/project_service_worker.rb'
- 'app/workers/propagate_integration_group_worker.rb'
- 'app/workers/propagate_integration_inherit_descendant_worker.rb'
- 'app/workers/propagate_integration_inherit_worker.rb'
......
.rubocop_todo/layout/line_length.yml
+ 0
− 1
View file @ eff23f64
......@@ -6216,7 +6216,6 @@ Layout/LineLength:
- 'spec/support/helpers/global_id_deprecation_helpers.rb'
- 'spec/support/helpers/graphql_helpers.rb'
- 'spec/support/helpers/javascript_fixtures_helpers.rb'
- 'spec/support/helpers/jira_service_helper.rb'
- 'spec/support/helpers/kubernetes_helpers.rb'
- 'spec/support/helpers/lets_encrypt_helpers.rb'
- 'spec/support/helpers/live_debugger.rb'
......
.rubocop_todo/lint/missing_cop_enable_directive.yml
+ 1
− 3
View file @ eff23f64
......@@ -156,7 +156,6 @@ Lint/MissingCopEnableDirective:
- 'lib/gitlab/background_migration/migrate_approver_to_approval_rules_check_progress.rb'
- 'lib/gitlab/background_migration/migrate_approver_to_approval_rules_in_batch.rb'
- 'lib/gitlab/background_migration/migrate_job_artifact_registry_to_ssf.rb'
- 'lib/gitlab/background_migration/migrate_stage_status.rb'
- 'lib/gitlab/background_migration/migrate_u2f_webauthn.rb'
- 'lib/gitlab/background_migration/populate_latest_pipeline_ids.rb'
- 'lib/gitlab/background_migration/populate_resolved_on_default_branch_column.rb'
......@@ -182,7 +181,6 @@ Lint/MissingCopEnableDirective:
- 'lib/gitlab/patch/action_cable_redis_listener.rb'
- 'lib/gitlab/patch/prependable.rb'
- 'lib/gitlab/project_search_results.rb'
- 'lib/gitlab/task_helpers.rb'
- 'lib/gitlab/testing/request_blocker_middleware.rb'
- 'lib/gitlab/testing/request_inspector_middleware.rb'
- 'lib/gitlab/testing/robots_blocker_middleware.rb'
......@@ -192,4 +190,4 @@ Lint/MissingCopEnableDirective:
- 'spec/support/capybara.rb'
- 'spec/support/cycle_analytics_helpers/test_generation.rb'
- 'spec/support/google_api/cloud_platform_helpers.rb'
- 'tooling/danger/product_intelligence.rb'
- 'tooling/danger/product_intelligence.rb'
\ No newline at end of file
.rubocop_todo/lint/mixed_regexp_capture_types.yml
+ 1
− 2
View file @ eff23f64
......@@ -10,7 +10,6 @@ Lint/MixedRegexpCaptureTypes:
- 'lib/gitlab/diff/suggestions_parser.rb'
- 'lib/gitlab/github_import/representation/note.rb'
- 'lib/gitlab/metrics/system.rb'
- 'lib/gitlab/request_profiler/profile.rb'
- 'lib/gitlab/slash_commands/issue_move.rb'
- 'lib/gitlab/slash_commands/issue_new.rb'
- 'lib/gitlab/slash_commands/run.rb'
- 'lib/gitlab/slash_commands/run.rb'
\ No newline at end of file
.rubocop_todo/migration/background_migrations.yml 0 → 100644
+ 83
− 0
View file @ eff23f64
---
Migration/BackgroundMigrations:
Exclude:
- 'ee/db/geo/post_migrate/20220202101354_migrate_job_artifact_registry.rb'
- 'db/post_migrate/20220506124021_schedule_populate_requirements_issue_id.rb'
- 'db/post_migrate/20220502173045_reset_too_many_tags_skipped_registry_imports.rb'
- 'db/post_migrate/20220425121435_backfill_integrations_enable_ssl_verification.rb'
- 'db/post_migrate/20220420214703_schedule_backfill_draft_status_on_merge_requests_corrected_regex.rb'
- 'db/post_migrate/20220420061450_backfill_null_note_discussion_ids.rb'
- 'db/post_migrate/20220407163559_schedule_purging_stale_security_scans.rb'
- 'db/post_migrate/20220331133802_schedule_backfill_topics_title.rb'
- 'db/post_migrate/20220328100457_schedule20220328_reset_duplicate_ci_runners_token_values_on_projects.rb'
- 'db/post_migrate/20220328100456_schedule20220328_reset_duplicate_ci_runners_token_encrypted_values_on_projects.rb'
- 'db/post_migrate/20220324081709_fix_and_backfill_project_namespaces_for_projects_with_duplicate_name.rb'
- 'db/post_migrate/20220324032250_migrate_shimo_confluence_service_category.rb'
- 'db/post_migrate/20220316202640_populate_container_repositories_migration_plan.rb'
- 'db/post_migrate/20220315171129_cleanup_draft_data_from_faulty_regex.rb'
- 'db/migrate/20210519154058_schedule_update_users_where_two_factor_auth_required_from_group.rb'
- 'db/post_migrate/20210302150310_schedule_migrate_pages_to_zip_storage.rb'
- 'db/post_migrate/20210304133508_schedule_remove_duplicate_vulnerabilities_findings2.rb'
- 'db/post_migrate/20210415155043_move_container_registry_enabled_to_project_features3.rb'
- 'db/post_migrate/20210421163509_schedule_update_jira_tracker_data_deployment_type_based_on_url.rb'
- 'db/post_migrate/20210423160427_schedule_drop_invalid_vulnerabilities.rb'
- 'db/post_migrate/20210427212034_schedule_update_timelogs_project_id.rb'
- 'db/post_migrate/20210506065000_schedule_backfill_traversal_ids.rb'
- 'db/post_migrate/20210511095658_schedule_migrate_project_taggings_context_from_tags_to_topics.rb'
- 'db/post_migrate/20210511142748_schedule_drop_invalid_vulnerabilities2.rb'
- 'db/post_migrate/20210514063252_schedule_cleanup_orphaned_lfs_objects_projects.rb'
- 'db/post_migrate/20210518074332_schedule_disable_expiration_policies_linked_to_no_container_images.rb'
- 'db/post_migrate/20210611080951_fix_missing_traversal_ids.rb'
- 'db/post_migrate/20210701111909_backfill_issues_upvotes_count.rb'
- 'db/post_migrate/20210722010101_reschedule_delete_orphaned_deployments.rb'
- 'db/post_migrate/20210729163312_re_schedule_latest_pipeline_id_population_with_all_security_related_artifact_types.rb'
- 'db/post_migrate/20210730104800_schedule_extract_project_topics_into_separate_table.rb'
- 'db/post_migrate/20210730170823_schedule_security_setting_creation.rb'
- 'db/post_migrate/20210816183304_schedule_copy_ci_builds_columns_to_security_scans2.rb'
- 'db/post_migrate/20210818185845_backfill_projects_with_coverage.rb'
- 'db/post_migrate/20211004110927_schedule_fix_first_mentioned_in_commit_at_job.rb'
- 'db/post_migrate/20211004120135_schedule_add_primary_email_to_emails_if_user_confirmed.rb'
- 'db/post_migrate/20211005194425_schedule_requirements_migration.rb'
- 'db/post_migrate/20211006060436_schedule_populate_topics_total_projects_count_cache.rb'
- 'db/post_migrate/20211007155221_schedule_populate_status_column_of_security_scans.rb'
- 'db/post_migrate/20211018152654_schedule_remove_duplicate_vulnerabilities_findings3.rb'
- 'db/post_migrate/20211102114802_update_vulnerability_occurrences_location.rb'
- 'db/post_migrate/20211110151350_schedule_drop_invalid_security_findings.rb'
- 'db/post_migrate/20211116111644_schedule_remove_occurrence_pipelines_and_duplicate_vulnerabilities_findings.rb'
- 'db/post_migrate/20211118194239_drop_invalid_remediations.rb'
- 'db/post_migrate/20211208122200_schedule_backfill_ci_namespace_mirrors.rb'
- 'db/post_migrate/20211208122201_schedule_backfill_ci_project_mirrors.rb'
- 'db/post_migrate/20211209203821_convert_stringified_raw_metadata_hash_to_json.rb'
- 'db/post_migrate/20211210140629_encrypt_static_object_token.rb'
- 'db/post_migrate/20211215090620_schedule_update_timelogs_null_spent_at.rb'
- 'db/post_migrate/20220107064845_populate_vulnerability_reads.rb'
- 'db/post_migrate/20220110171049_schedule_populate_test_reports_issue_id.rb'
- 'db/post_migrate/20220125122640_schedule_populate_topics_non_private_projects_count.rb'
- 'db/post_migrate/20220131000001_schedule_trace_expiry_removal.rb'
- 'db/post_migrate/20220204194347_encrypt_integration_properties.rb'
- 'db/post_migrate/20220208115439_start_backfill_ci_queuing_tables.rb'
- 'db/post_migrate/20220215190020_rerun_convert_stringified_raw_metadata_hash_to_json.rb'
- 'db/post_migrate/20220308115219_schedule_reset_duplicate_ci_runners_token_encrypted_values_on_projects.rb'
- 'db/post_migrate/20220308115502_schedule_reset_duplicate_ci_runners_token_values_on_projects.rb'
- 'db/post_migrate/20211207135331_schedule_recalculate_uuid_on_vulnerabilities_occurrences4.rb'
- 'db/post_migrate/20210604070207_retry_backfill_traversal_ids.rb'
- 'db/post_migrate/20210708130419_reschedule_merge_request_diff_users_background_migration.rb'
- 'db/post_migrate/20210823113259_steal_merge_request_diff_commit_users_migration.rb'
- 'db/post_migrate/20210825193652_backfill_cadence_id_for_boards_scoped_to_iteration.rb'
- 'db/post_migrate/20210830104800_reschedule_extract_project_topics_into_separate_table.rb'
- 'db/post_migrate/20210901153324_slice_merge_request_diff_commit_migrations.rb'
- 'db/post_migrate/20210909104800_reschedule_extract_project_topics_into_separate_table_2.rb'
- 'db/post_migrate/20211005010101_rereschedule_delete_orphaned_deployments.rb'
- 'db/post_migrate/20211028155449_schedule_fix_merge_request_diff_commit_users_migration.rb'
- 'db/post_migrate/20211208171402_reschedule_recalculate_vulnerability_finding_signatures_for_findings.rb'
- 'db/post_migrate/20220113111440_schedule_fix_incorrect_max_seats_used.rb'
- 'db/post_migrate/20220118204039_self_managed_reschedule_recalculate_vulnerability_finding_signatures_for_findings.rb'
- 'db/post_migrate/20220204095121_backfill_namespace_statistics_with_dependency_proxy_size.rb'
- 'db/post_migrate/20220212120735_schedule_fix_incorrect_max_seats_used2.rb'
- 'db/post_migrate/20220223124428_schedule_merge_topics_with_same_name.rb'
- 'db/post_migrate/20210302074524_backfill_namespace_statistics_with_wiki_size.rb'
- 'lib/gitlab/database/migrations/background_migration_helpers.rb'
- 'lib/gitlab/database/partitioning_migration_helpers/table_management_helpers.rb'
- 'spec/lib/gitlab/database/migration_helpers/restrict_gitlab_schema_spec.rb'
- 'spec/lib/gitlab/database/migrations/background_migration_helpers_spec.rb'
- 'spec/lib/gitlab/database/migrations/test_background_runner_spec.rb'
.rubocop_todo/naming/rescued_exceptions_variable_name.yml
+ 0
− 1
View file @ eff23f64
......@@ -86,7 +86,6 @@ Naming/RescuedExceptionsVariableName:
- 'app/workers/namespaces/schedule_aggregation_worker.rb'
- 'app/workers/packages/go/sync_packages_worker.rb'
- 'app/workers/project_destroy_worker.rb'
- 'app/workers/project_service_worker.rb'
- 'app/workers/projects/git_garbage_collect_worker.rb'
- 'app/workers/remove_expired_members_worker.rb'
- 'app/workers/users/create_statistics_worker.rb'
......
.rubocop_todo/rails/file_path.yml
+ 0
− 1
View file @ eff23f64
......@@ -31,7 +31,6 @@ Rails/FilePath:
- 'ee/db/fixtures/development/32_compliance_report_violations.rb'
- 'ee/lib/ee/feature/definition.rb'
- 'ee/lib/ee/gitlab/usage/metric_definition.rb'
- 'ee/lib/generators/geo_migration/geo_migration_generator.rb'
- 'ee/lib/gitlab/geo/health_check.rb'
- 'ee/lib/tasks/gitlab/seed/metrics.rake'
- 'ee/spec/db/production/license_spec.rb'
......
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment