Skip to content
Snippets Groups Projects
Verified Commit eda0a443 authored by Stan Hu's avatar Stan Hu
Browse files

Remove Git cheat sheet PDF LFS file

`spec/fixtures/git-cheat-sheet.pdf` was checked in as an LFS file in
2019, but it's not really essential since it's just a test
fixture. Having this file causes some unintended headaches:

1. We now have to pay for LFS bandwidth for GitLab mirrors.

2. When a conflicting GitLab.com SSL cert is installed (e.g. due to
JAMF), a `git clone` will fail because of HTTPS verification. We've
seen a number of people blocked as a result.

While it's useful to dogfood LFS, the downsides seem to outweight the
upsides.
parent 9f24e358
No related branches found
No related tags found
1 merge request!98816Remove Git cheat sheet PDF LFS file
VERSION merge=ours
Dangerfile gitlab-language=ruby
*.pdf filter=lfs diff=lfs merge=lfs -text
*.rb diff=ruby
workhorse/testdata/*.pdf -filter -diff -merge
......@@ -216,7 +216,7 @@
end
context 'for PDF files' do
let(:filename) { 'git-cheat-sheet.pdf' }
let(:filename) { 'sample.pdf' }
let(:expected_disposition) { 'inline;' }
let(:note) { create(:note, :with_pdf_attachment, project: project) }
......
......@@ -184,7 +184,7 @@
end
trait :with_pdf_attachment do
attachment { fixture_file_upload("spec/fixtures/git-cheat-sheet.pdf", "application/pdf") }
attachment { fixture_file_upload("spec/fixtures/sample.pdf", "application/pdf") }
end
trait :confidential do
......
File deleted
File added
......@@ -70,7 +70,7 @@
let(:doc_extension) { described_class::DOC_TYPES.sample }
let(:doc_attachment) do
"[some-doc](https://github.com/nickname/public-test-repo/"\
"files/9020437/git-cheat-sheet.#{doc_extension})"
"files/9020437/sample.#{doc_extension})"
end
let(:text) do
......
......@@ -288,7 +288,7 @@
context 'when page is a file' do
include WikiHelpers
where(:file_name) { ['dk.png', 'unsanitized.svg', 'git-cheat-sheet.pdf'] }
where(:file_name) { ['dk.png', 'unsanitized.svg', 'sample.pdf'] }
with_them do
let(:id) { upload_file_to_wiki(wiki, user, file_name) }
......
......@@ -77,9 +77,9 @@
end
if drop
find(".upload-dropzone-card").drop(File.join(Rails.root, 'spec', 'fixtures', 'git-cheat-sheet.pdf'))
find(".upload-dropzone-card").drop(File.join(Rails.root, 'spec', 'fixtures', 'sample.pdf'))
else
attach_file('upload_file', File.join(Rails.root, 'spec', 'fixtures', 'git-cheat-sheet.pdf'), make_visible: true)
attach_file('upload_file', File.join(Rails.root, 'spec', 'fixtures', 'sample.pdf'), make_visible: true)
end
page.within('#modal-upload-blob') do
......@@ -90,7 +90,7 @@
wait_for_all_requests
visit(project_blob_path(project, 'upload_image/git-cheat-sheet.pdf'))
visit(project_blob_path(project, 'upload_image/sample.pdf'))
expect(page).to have_css('.js-pdf-viewer')
end
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment