Skip to content
Snippets Groups Projects
Commit e98fd6f4 authored by Lin Jen-Shin's avatar Lin Jen-Shin :cookie:
Browse files

Merge branch 'sh-fix-caniuselite-static-analysis' into 'master' 

Fix static-analysis failure due to caniuse-lite dependency

Closes #194788

See merge request !22447
parents ff30cda5 70e1b685
No related branches found
No related tags found
2 merge requests!158514Fix CodeReviewMetrics worker failure with kwargs,!22447Fix static-analysis failure due to caniuse-lite dependency
Pipeline #107100735 passed with warnings
Stage: sync
Stage: prepare
Stage: test
Stage: post-test
Stage: review-prepare
Stage: review
Stage: qa
Stage: notification
Stage: pages
Stage: deploy
Hide whitespace changes
Inline Side-by-side
Showing
with 14 additions and 1 deletion
scripts/static-analysis
+ 14
− 1
View file @ e98fd6f4
......@@ -26,6 +26,19 @@ def emit_errors(static_analysis)
end
end
ALLOWED_WARNINGS = [
# https://github.com/browserslist/browserslist/blob/d0ec62eb48c41c218478cd3ac28684df051cc865/node.js#L329
# warns if caniuse-lite package is older than 6 months. Ignore this
# warning message so that GitLab backports don't fail.
"Browserslist: caniuse-lite is outdated. Please run next command `yarn upgrade`"
].freeze
def warning_count(static_analysis)
static_analysis.warned_results
.reject { |result| ALLOWED_WARNINGS.include?(result.stderr.strip) }
.count
end
def jobs_to_run(node_index, node_total)
all_tasks = [
%w[bin/rake lint:all],
......@@ -81,7 +94,7 @@ elsif static_analysis.all_success?
emit_warnings(static_analysis)
exit 2
exit 2 if warning_count(static_analysis).nonzero?
else
puts 'Some static analyses failed:'
......
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment