-
- Downloads
Handle Rails 6.1 ActiveModel::Errors changes
Modal errors as objects are introduced: https://github.com/rails/rails/pull/32313 model.errors.first returns ActiveModel::Error object that's why model.errors.first[1] doesn't work in Rails 6.1 We need a way that works both for 6.1 and 6.0 in order to introduce changes gradually: model.errors.values.first works for both versions. Even though treating errors as a hash is deprecated it works so we can introduce the changes in 6.0 and then fix the deprecations when we're on 6.1 (cherry picked from commit b5ecc309)
parent
2376a5ee
No related branches found
No related tags found
Showing
- app/helpers/application_settings_helper.rb 1 addition, 1 deletionapp/helpers/application_settings_helper.rb
- app/models/concerns/routable.rb 3 additions, 1 deletionapp/models/concerns/routable.rb
- app/models/user.rb 3 additions, 1 deletionapp/models/user.rb
- lib/file_size_validator.rb 1 addition, 1 deletionlib/file_size_validator.rb
- spec/lib/gitlab/ci/pipeline/chain/limit/deployments_spec.rb 1 addition, 1 deletionspec/lib/gitlab/ci/pipeline/chain/limit/deployments_spec.rb
- spec/models/concerns/chronic_duration_attribute_spec.rb 1 addition, 2 deletionsspec/models/concerns/chronic_duration_attribute_spec.rb
- spec/models/custom_emoji_spec.rb 1 addition, 1 deletionspec/models/custom_emoji_spec.rb
- spec/models/group_spec.rb 3 additions, 1 deletionspec/models/group_spec.rb
- spec/models/merge_request_diff_spec.rb 1 addition, 1 deletionspec/models/merge_request_diff_spec.rb
- spec/models/project_spec.rb 3 additions, 1 deletionspec/models/project_spec.rb
- spec/models/user_spec.rb 2 additions, 1 deletionspec/models/user_spec.rb
- spec/services/notes/build_service_spec.rb 1 addition, 1 deletionspec/services/notes/build_service_spec.rb
- spec/validators/addressable_url_validator_spec.rb 7 additions, 5 deletionsspec/validators/addressable_url_validator_spec.rb
- spec/validators/array_members_validator_spec.rb 2 additions, 2 deletionsspec/validators/array_members_validator_spec.rb
- spec/validators/devise_email_validator_spec.rb 2 additions, 2 deletionsspec/validators/devise_email_validator_spec.rb
- spec/validators/gitlab/utils/zoom_url_validator_spec.rb 1 addition, 1 deletionspec/validators/gitlab/utils/zoom_url_validator_spec.rb
- spec/validators/qualified_domain_array_validator_spec.rb 4 additions, 4 deletionsspec/validators/qualified_domain_array_validator_spec.rb
Loading
Please register or sign in to comment