Skip to content
Snippets Groups Projects
Commit d84caf3e authored by Dylan Griffith's avatar Dylan Griffith
Browse files

Delete the `blame_page_pagination` feature flag

This feature flag was introduced in 15.0, which is more than 12 milestones ago.

As part of our process we want to ensure [feature flags don't stay too long in the codebase](https://docs.gitlab.com/ee/development/feature_flags/#types-of-feature-flags).

Rollout issue: #360927

The feature flag is enabled by default. Unless it's disabled on GitLab.com, you should keep the feature-flag
code branch, otherwise, keep the other branch.

<details><summary>Remaining mentions of the feature flag (click to expand)</summary>

```

```

</details>

It is possible that this MR will still need some changes to remove references to the feature flag in the code.
At the moment the `gitlab-housekeeper` is not always capable of removing all references so you must check the diff and pipeline failures to confirm if there are any issues.
It is the responsibility of ~"group::source code" to push those changes to this branch.
If they are already removing this feature flag in another merge request then they can just close this merge request.

You can also see the status of the rollout by checking #360927 and https://gitlab.com/gitlab-com/gl-infra/feature-flag-log/-/issues/?search=blame_page_pagination&sort=created_date&state=all&label_name%5B%5D=host%3A%3Agitlab.com.

This change was generated by
[gitlab-housekeeper](https://gitlab.com/gitlab-org/gitlab/-/tree/master/gems/gitlab-housekeeper)
using the Keeps::DeleteOldFeatureFlags keep.

To provide feedback on your experience with `gitlab-housekeeper` please create an issue with the
label ~"GitLab Housekeeper" and consider pinging the author of this keep.

Changelog: removed
parent 14a81796
No related branches found
No related tags found
1 merge request!161124Delete the `blame_page_pagination` feature flag
---
name: blame_page_pagination
introduced_by_url: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/85827
rollout_issue_url: https://gitlab.com/gitlab-org/gitlab/-/issues/360927
milestone: '15.0'
type: development
group: group::source code
default_enabled: true
......@@ -16,7 +16,7 @@ def pagination?
return false if streaming?
return false if Gitlab::Utils.to_boolean(params[:no_pagination], default: false)
Feature.enabled?(:blame_page_pagination, project)
true
end
def full?
......
......@@ -115,22 +115,6 @@ def visit_blob_blame(path)
expect(page).to have_text('Loading full blame...')
end
end
context 'when feature flag disabled' do
before do
stub_feature_flags(blame_page_pagination: false)
end
it 'displays the blame page without pagination' do
visit_blob_blame(path)
within_testid 'blob-content-holder' do
expect(page).to have_css('.blame-commit')
expect(page).not_to have_css('.gl-pagination')
expect(page).not_to have_link _('Show full blame')
end
end
end
end
context 'when blob length is over global max page limit' do
......
......@@ -36,27 +36,11 @@
it { is_expected.to be_falsey }
end
context 'when `blame_page_pagination` is disabled' do
before do
stub_feature_flags(blame_page_pagination: false)
end
it { is_expected.to be_falsey }
end
end
describe '#full?' do
subject { blame_mode.full? }
it { is_expected.to be_falsey }
context 'when `blame_page_pagination` is disabled' do
before do
stub_feature_flags(blame_page_pagination: false)
end
it { is_expected.to be_truthy }
end
end
end
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment