Skip to content
Snippets Groups Projects
Commit cd7d69c9 authored by David O'Regan's avatar David O'Regan :green_heart:
Browse files

Merge branch 'tv/2023-07/docs-stable-reviewer-counterparts' into 'master'

Suggest finding stable reviewer counterparts for multi-MR features

See merge request !127083



Merged-by: David O'Regan's avatarDavid O'Regan <doregan@gitlab.com>
Approved-by: Bogdan Denkovych's avatarBogdan Denkovych <bdenkovych@gitlab.com>
Approved-by: Thong Kuah's avatarThong Kuah <tkuah@gitlab.com>
Approved-by: David O'Regan's avatarDavid O'Regan <doregan@gitlab.com>
Approved-by: François Rosé's avatarFrançois Rosé <frose@gitlab.com>
Reviewed-by: François Rosé's avatarFrançois Rosé <frose@gitlab.com>
Co-authored-by: François Rosé's avatarFrançois Rosé <frose@gitlab.com>
Co-authored-by: Tomas Vik's avatarTomas Vik <tvik@gitlab.com>
parents 1f5309ef a5d1e671
No related branches found
No related tags found
1 merge request!127083Suggest finding stable reviewer counterparts for multi-MR features
Pipeline #1050070256 passed
......@@ -295,6 +295,10 @@ up confusion or verify that the end result matches what they had in mind, to
database specialists to get input on the data model or specific queries, or to
any other developer to get an in-depth review of the solution.
If you know you'll need many merge requests to deliver a feature (for example, you created a proof of concept and it is clear the feature will consist of 10+ merge requests),
consider identifying reviewers and maintainers who possess the necessary understanding of the feature (you share the context with them). Then direct all merge requests to these reviewers.
The best DRI for finding these reviewers is the EM or Staff Engineer. Having stable reviewer counterparts for multiple merge requests with the same context improves efficiency.
If your merge request touches more than one domain (for example, Dynamic Analysis and GraphQL), ask for reviews from an expert from each domain.
If an author is unsure if a merge request needs a [domain expert's](#domain-experts) opinion,
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment