-
- Downloads
Change data consistency for workers maintained by not_owned
## What does this MR It updates workers data consistency from `:always` to `:sticky` for workers maintained by `not_owned`, as a way to reduce database reads on the primary DB. Check #462611. To reduce resource saturation on the primary node, all workers should be changed to `sticky`, at minimum. Since jobs are now enqueued along with the current database LSN, the replica (for `:sticky` or `:delayed`) is guaranteed to be caught up to that point, or the job will be retried, or use the primary. Consider updating the worker(s) to `delayed`, if it's applicable. You can read more about the Sidekiq Workers `data_consistency` in https://docs.gitlab.com/ee/development/sidekiq/worker_attributes.html#job-data-consistency-strategies. You can use this [dashboard](https://log.gprd.gitlab.net/app/r/s/iyIUV) to monitor the worker query activity on primary vs. replicas. Currently, the `gitlab-housekeeper` is not always capable of updating all references, so you must check the diff and pipeline failures to confirm if there are any issues. This change was generated by [gitlab-housekeeper](https://gitlab.com/gitlab-org/gitlab/-/tree/master/gems/gitlab-housekeeper) using the Keeps::UpdateWorkersDataConsistency keep. To provide feedback on your experience with `gitlab-housekeeper` please create an issue with the label ~"GitLab Housekeeper" and consider pinging the author of this keep. Changelog: other # Conflicts: # .rubocop_todo/sidekiq_load_balancing/worker_data_consistency.yml
parent
eb20c718
No related branches found
No related tags found
Showing
- .rubocop_todo/sidekiq_load_balancing/worker_data_consistency.yml 0 additions, 5 deletions...p_todo/sidekiq_load_balancing/worker_data_consistency.yml
- app/workers/chaos/cpu_spin_worker.rb 1 addition, 1 deletionapp/workers/chaos/cpu_spin_worker.rb
- app/workers/chaos/db_spin_worker.rb 1 addition, 1 deletionapp/workers/chaos/db_spin_worker.rb
- app/workers/chaos/kill_worker.rb 1 addition, 1 deletionapp/workers/chaos/kill_worker.rb
- app/workers/chaos/leak_mem_worker.rb 1 addition, 1 deletionapp/workers/chaos/leak_mem_worker.rb
- app/workers/chaos/sleep_worker.rb 1 addition, 1 deletionapp/workers/chaos/sleep_worker.rb
-
mentioned in merge request !171746 (merged)
-
mentioned in merge request kubitus-project/kubitus-installer!3515 (merged)
Please register or sign in to comment