Rephrase sign up with text to register with

This commit rephrases sign up with text
to register with on the redesigned Login Page.

app/views/devise/shared/_signup_omniauth_provider_list.haml

@@ -2,7 +2,7 @@
 - if Feature.enabled?(:restyle_login_page, @project)
   .gl-text-center.gl-pt-5
     %label.gl-font-weight-normal
-      = _("Create an account using:")
+      = _("Register with:")
     .gl-text-center.gl-w-90p.gl-ml-auto.gl-mr-auto
       - providers.each do |provider|
         = link_to omniauth_authorize_path(:user, provider, register_omniauth_params), method: :post, class: "btn gl-button btn-default gl-ml-2 gl-mr-2 gl-mb-2 js-oauth-login #{qa_class_for_provider(provider)}", data: { provider: provider }, id: "oauth-login-#{provider}" do

app/views/devise/shared/_terms_of_service_notice.html.haml

 - return unless Gitlab::CurrentSettings.current_application_settings.enforce_terms?
 
 %p.gl-text-gray-500.gl-mt-5.gl-mb-0
-  - if Gitlab.com?
-    = html_escape(s_("SignUp|By clicking %{button_text}, I agree that I have read and accepted the GitLab %{link_start}Terms of Use and Privacy Policy%{link_end}")) % { button_text: button_text,
-      link_start: "<a href='#{terms_path}' target='_blank' rel='noreferrer noopener'>".html_safe, link_end: '</a>'.html_safe }
+  - if Feature.enabled?(:restyle_login_page, @project)
+    - if Gitlab.com?
+      = html_escape(s_("SignUp|By clicking %{button_text} or registering through a third party you accept the GitLab%{link_start} Terms of Use and acknowledge the Privacy Policy and Cookie Policy%{link_end}")) % { button_text: button_text,
+        link_start: "<a href='#{terms_path}' target='_blank' rel='noreferrer noopener'>".html_safe, link_end: '</a>'.html_safe }
+    - else
+      = html_escape(s_("SignUp|By clicking %{button_text} or registering through a third party you accept the%{link_start} Terms of Use and acknowledge the Privacy Policy and Cookie Policy%{link_end}")) % { button_text: button_text,
+        link_start: "<a href='#{terms_path}' target='_blank' rel='noreferrer noopener'>".html_safe, link_end: '</a>'.html_safe }
   - else
-    = html_escape(s_("SignUp|By clicking %{button_text}, I agree that I have read and accepted the %{link_start}Terms of Use and Privacy Policy%{link_end}")) % { button_text: button_text,
-      link_start: "<a href='#{terms_path}' target='_blank' rel='noreferrer noopener'>".html_safe, link_end: '</a>'.html_safe }
+    - if Gitlab.com?
+      = html_escape(s_("SignUp|By clicking %{button_text}, I agree that I have read and accepted the GitLab %{link_start}Terms of Use and Privacy Policy%{link_end}")) % { button_text: button_text,
+        link_start: "<a href='#{terms_path}' target='_blank' rel='noreferrer noopener'>".html_safe, link_end: '</a>'.html_safe }
+    - else
+      = html_escape(s_("SignUp|By clicking %{button_text}, I agree that I have read and accepted the %{link_start}Terms of Use and Privacy Policy%{link_end}")) % { button_text: button_text,
+        link_start: "<a href='#{terms_path}' target='_blank' rel='noreferrer noopener'>".html_safe, link_end: '</a>'.html_safe }

locale/gitlab.pot

@@ -32325,6 +32325,9 @@ msgstr ""
 msgid "Register with two-factor app"
 msgstr ""
+msgid "Register with:"
+msgstr ""
+
 msgid "RegistrationFeatures|Enable Service Ping and register for this feature."
 msgstr ""
@@ -36539,6 +36542,12 @@ msgstr ""
 msgid "Sign-up restrictions"
 msgstr ""
+msgid "SignUp|By clicking %{button_text} or registering through a third party you accept the GitLab%{link_start} Terms of Use and acknowledge the Privacy Policy and Cookie Policy%{link_end}"
+msgstr ""
+
+msgid "SignUp|By clicking %{button_text} or registering through a third party you accept the%{link_start} Terms of Use and acknowledge the Privacy Policy and Cookie Policy%{link_end}"
+msgstr ""
+
 msgid "SignUp|By clicking %{button_text}, I agree that I have read and accepted the %{link_start}Terms of Use and Privacy Policy%{link_end}"
 msgstr ""

spec/support/helpers/login_helpers.rb

@@ -120,7 +120,7 @@ def login_via(provider, user, uid, remember_me: false, additional_info: {})
   def register_via(provider, uid, email, additional_info: {})
     mock_auth_hash(provider, uid, email, additional_info: additional_info)
     visit new_user_registration_path
-    expect(page).to have_content('Create an account using')
+    expect(page).to have_content('Create an account using').or(have_content('Register with'))
 
     click_link_or_button "oauth-login-#{provider}"
   end

spec/views/devise/shared/_signup_box.html.haml_spec.rb

@@ -7,13 +7,15 @@
   let(:terms_path) { '_terms_path_' }
 
   let(:translation_com) do
-    s_("SignUp|By clicking %{button_text}, I agree that I have read and accepted "\
-       "the GitLab %{link_start}Terms of Use and Privacy Policy%{link_end}")
+    s_("SignUp|By clicking %{button_text} or registering through a third party you "\
+      "accept the GitLab%{link_start} Terms of Use and acknowledge the Privacy Policy "\
+      "and Cookie Policy%{link_end}")
   end
 
   let(:translation_non_com) do
-    s_("SignUp|By clicking %{button_text}, I agree that I have read and accepted "\
-       "the %{link_start}Terms of Use and Privacy Policy%{link_end}")
+    s_("SignUp|By clicking %{button_text} or registering through a third party you "\
+      "accept the%{link_start} Terms of Use and acknowledge the Privacy Policy and "\
+      "Cookie Policy%{link_end}")
   end
 
   before do