Skip to content
Snippets Groups Projects
Commit cb94b4e6 authored by Gerardo Navarro's avatar Gerardo Navarro :speech_balloon:
Browse files

refactor: Apply suggestion from @marcel.amirault

- Apply wording suggestion, see
  !148704 (comment 1851173972)
- Apply wording suggestion, see
  !146523 (comment 1850163040)
parent 94285485
No related branches found
No related tags found
No related merge requests found
This commit is part of merge request !146523. Comments created here will be created in the context of that merge request.
......@@ -130,7 +130,7 @@ export default {
</gl-form-group>
<gl-form-group
:label="s__('ContainerRegistry|Push protected up to access level')"
:label="s__('ContainerRegistry|Maximum access level prevented from pushing')"
label-for="input-push-protected-up-to-access-level"
:disabled="isFieldDisabled"
>
......@@ -144,7 +144,7 @@ export default {
</gl-form-group>
<gl-form-group
:label="s__('ContainerRegistry|Delete protected up to access level')"
:label="s__('ContainerRegistry|Maximum access level prevented from deleting')"
label-for="input-delete-protected-up-to-access-level"
:disabled="isFieldDisabled"
>
......@@ -163,7 +163,7 @@ export default {
type="submit"
:disabled="isSubmitButtonDisabled"
:loading="showLoadingIcon"
>{{ __('Protect') }}</gl-button
>{{ s__('ContainerRegistry|Add rule') }}</gl-button
>
<gl-button class="gl-ml-3" type="reset">{{ __('Cancel') }}</gl-button>
</div>
......
......@@ -13808,6 +13808,9 @@ msgstr ""
msgid "ContainerRegistry|Add protection rule"
msgstr ""
 
msgid "ContainerRegistry|Add rule"
msgstr ""
msgid "ContainerRegistry|Build an image"
msgstr ""
 
......@@ -13955,6 +13958,12 @@ msgstr ""
msgid "ContainerRegistry|Manifest digest: %{digest}"
msgstr ""
 
msgid "ContainerRegistry|Maximum access level prevented from deleting"
msgstr ""
msgid "ContainerRegistry|Maximum access level prevented from pushing"
msgstr ""
msgid "ContainerRegistry|Missing or insufficient permission, delete button disabled"
msgstr ""
 
......@@ -26,10 +26,10 @@ describe('container Protection Rule Form', () => {
const findRepositoryPathPatternInput = () =>
wrapper.findByRole('textbox', { name: /repository path pattern/i });
const findPushProtectedUpToAccessLevelSelect = () =>
wrapper.findByRole('combobox', { name: /push protected up to access level/i });
wrapper.findByRole('combobox', { name: /maximum access level prevented from pushing/i });
const findDeleteProtectedUpToAccessLevelSelect = () =>
wrapper.findByRole('combobox', { name: /delete protected up to access level/i });
const findSubmitButton = () => wrapper.findByRole('button', { name: /protect/i });
wrapper.findByRole('combobox', { name: /maximum access level prevented from deleting/i });
const findSubmitButton = () => wrapper.findByRole('button', { name: /add rule/i });
const mountComponent = ({ config, provide = defaultProvidedValues } = {}) => {
wrapper = mountExtended(ContainerProtectionRuleForm, {
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment