Skip to content
Snippets Groups Projects
Verified Commit bda71e93 authored by Rahul Chanila's avatar Rahul Chanila :two: Committed by GitLab
Browse files

Fix accessibility violation for vue_shared/settings-block

Fixes aria-allowed-role axe violation

https://dequeuniversity.com/rules/axe/4.9/aria-allowed-role\?application\=axeAPI

Encountered this while adding specs in !174272

Changelog: fixed
parent 9b5f6cdc
No related branches found
No related tags found
1 merge request!174321Fix accessibility violation in settings-block shared component
......@@ -79,17 +79,19 @@ export default {
</gl-button>
</div>
<div class="gl-grow">
<h2
role="button"
<button
class="gl-w-full gl-border-0 gl-bg-transparent gl-p-0 gl-text-left"
tabindex="-1"
class="gl-heading-2 !gl-mb-2 gl-cursor-pointer"
type="button"
:aria-expanded="ariaExpanded"
:aria-controls="collapseId"
data-testid="settings-block-title"
@click="toggleExpanded"
>
{{ title }}
</h2>
<h2 class="gl-heading-2 !gl-mb-2">
{{ title }}
</h2>
</button>
<p class="gl-m-0 gl-text-subtle"><slot name="description"></slot></p>
</div>
</div>
......
......@@ -29,16 +29,20 @@ exports[`Status Page settings form default state should match the default snapsh
<div
class="gl-grow"
>
<h2
<button
aria-controls="reference-0"
aria-expanded="false"
class="!gl-mb-2 gl-cursor-pointer gl-heading-2"
class="gl-bg-transparent gl-border-0 gl-p-0 gl-text-left gl-w-full"
data-testid="settings-block-title"
role="button"
tabindex="-1"
type="button"
>
Status page
</h2>
<h2
class="!gl-mb-2 gl-heading-2"
>
Status page
</h2>
</button>
<p
class="gl-m-0 gl-text-subtle"
>
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment