Merge branch '336746-allow-to-delete-deployments-via-api' into 'master'

Remove delete_deployments_api feature flag

See merge request !94880

config/feature_flags/development/delete_deployments_api.yml

----
-name: delete_deployments_api
-introduced_by_url: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/92378
-rollout_issue_url: https://gitlab.com/gitlab-org/gitlab/-/issues/367885
-milestone: '15.3'
-type: development
-group: group::release
-default_enabled: false

lib/api/deployments.rb

@@ -151,8 +151,6 @@ class Deployments < ::API::Base
         requires :deployment_id, type: Integer, desc: 'The deployment ID'
       end
       delete ':id/deployments/:deployment_id' do
-        not_found! unless Feature.enabled?(:delete_deployments_api, user_project)
-
         deployment = user_project.deployments.find(params[:deployment_id])
 
         authorize!(:destroy_deployment, deployment)

spec/requests/api/deployments_spec.rb

@@ -483,18 +483,6 @@ def expect_deployments(ordered_deployments)
       end
     end
 
-    context 'when feature flag is disabled' do
-      before do
-        stub_feature_flags(delete_deployments_api: false)
-      end
-
-      it 'is not found' do
-        delete api("/projects/#{project.id}/deployments/#{old_deploy.id}", user)
-
-        expect(response).to have_gitlab_http_status(:not_found)
-      end
-    end
-
     context 'as a developer' do
       let(:developer) { create(:user) }