Create todos for expiring and expired SSH keys

Changelog: added

app/services/keys/expiry_notification_service.rb

@@ -15,10 +15,10 @@ def execute
       return unless allowed?
 
       if expiring_soon
-        create_expiring_soon_todos if Feature.enabled?(:todos_for_ssh_key_expiry, user)
+        create_expiring_soon_todos
         trigger_expiring_soon_notification
       else
-        create_expired_todos if Feature.enabled?(:todos_for_ssh_key_expiry, user)
+        create_expired_todos
         trigger_expired_notification
       end
     end

config/feature_flags/gitlab_com_derisk/todos_for_ssh_key_expiry.yml

----
-name: todos_for_ssh_key_expiry
-feature_issue_url: https://gitlab.com/gitlab-org/gitlab/-/issues/490325
-introduced_by_url: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/166168
-rollout_issue_url: https://gitlab.com/gitlab-org/gitlab/-/issues/497334
-milestone: '17.5'
-group: group::personal productivity
-type: gitlab_com_derisk
-default_enabled: false

spec/services/keys/expiry_notification_service_spec.rb

@@ -73,14 +73,6 @@
       it 'updates notified column' do
         expect { subject.execute }.to change { key.reload.expiry_notification_delivered_at }
       end
-
-      context 'when derisk feature flag is disabled' do
-        before do
-          stub_feature_flags(todos_for_ssh_key_expiry: false)
-        end
-
-        it_behaves_like 'does not create todo'
-      end
     end
 
     context 'when user does NOT have permission to receive notification' do
@@ -109,14 +101,6 @@
       it 'updates notified column' do
         expect { subject.execute }.to change { key.reload.before_expiry_notification_delivered_at }
       end
-
-      context 'when derisk feature flag is disabled' do
-        before do
-          stub_feature_flags(todos_for_ssh_key_expiry: false)
-        end
-
-        it_behaves_like 'does not create todo'
-      end
     end
 
     context 'when user does NOT have permission to receive notification' do