Merge branch '366605-remove-unused-banner-css' into 'master'

Remove unused css and css class selectors

See merge request !127554



Merged-by: Lukas 'Eipi' Eipert <leipert@gitlab.com>
Approved-by: Lukas 'Eipi' Eipert <leipert@gitlab.com>
Reviewed-by: Alexander Turinske <aturinske@gitlab.com>
Co-authored-by: Alexander Turinske <aturinske@gitlab.com>

ee/app/assets/javascripts/ee_trial_banner/ee_trial_banner.js

@@ -4,8 +4,6 @@ export default class EETrialBanner {
   constructor($trialBanner) {
     this.COOKIE_KEY = 'show_ee_trial_banner';
     this.$trialBanner = $trialBanner;
-    this.$mainNavbar = this.$trialBanner.siblings('.js-navbar-gitlab');
-    this.$secondaryNavbar = this.$mainNavbar.siblings('.js-page-with-sidebar');
 
     this.licenseExpiresOn = new Date(this.$trialBanner.data('licenseExpiry'));
   }
@@ -74,22 +72,8 @@ export default class EETrialBanner {
     }
   }
 
-  toggleMainNavbarMargin(state) {
-    if (this.$mainNavbar.length) {
-      this.$mainNavbar.toggleClass('has-trial-banner', state);
-    }
-  }
-
-  toggleSecondaryNavbarMargin(state) {
-    if (this.$secondaryNavbar.length) {
-      this.$secondaryNavbar.toggleClass('has-trial-banner', state);
-    }
-  }
-
   toggleBanner(state) {
     this.$trialBanner.toggleClass('hidden', !state);
-    this.toggleMainNavbarMargin(state);
-    this.toggleSecondaryNavbarMargin(state);
   }
 
   handleTrialBannerDismiss(element) {
@@ -100,8 +84,6 @@ export default class EETrialBanner {
 
     // A closed button has been clicked, dismiss the banner and handle setting the cookie
     this.toggleBanner(false);
-    this.toggleMainNavbarMargin(false);
-    this.toggleSecondaryNavbarMargin(false);
     if (getCookie(this.COOKIE_KEY)) {
       setCookie(this.COOKIE_KEY, 'false');
     }

ee/app/assets/stylesheets/pages/ee_start_trial.scss

-/* EE Trial Specific Stylesheet */
-
-/* Main Nav Overrides */
-.navbar-gitlab.has-trial-banner {
-  top: 52px;
-}
-
-.page-with-sidebar.has-trial-banner {
-  /* Secondary Nav Overrides - Old Nav */
-  margin-top: 102px;
-
-  /* Sidebar Nav Overrides - New Nav */
-  .nav-sidebar {
-    top: 102px;
-  }
-}

ee/app/views/layouts/header/_ee_subscribable_banner.html.haml

@@ -9,6 +9,7 @@
       alert_options: { data: { license_expiry: subscribable.expires_at, defer_links: "true", testid: 'subscribable_banner' }}) do |c|
       - c.with_body do
         = message
+      - c.with_actions do
         - if subscribable.block_changes?
           = link_to_button_style(path: renew_subscription_path, track_property: 'renew')
         - elsif subscribable.expired?