Explicitly define inverse of acces_level relations (b1479d39) · Commits · GitLab.org / GitLab · GitLab

Commit b1479d39 authored Jul 02, 2017 by

Bob Van Landuyt

Explicitly define inverse of acces_level relations

parent 8fd684b1

Hide whitespace changes

Inline Side-by-side

Rémy Coutable 🔴 @rymai · Jul 25, 2017

Maintainer

@reprazent Should this be backported to CE? Currently CE has has_many :"#{type}_access_levels", dependent: :destroy # rubocop:disable Cop/ActiveRecordDependent.

@reprazent Should this be backported to CE? Currently CE has `has_many :"#{type}_access_levels", dependent: :destroy # rubocop:disable Cop/ActiveRecordDependent`.
Bob Van Landuyt @reprazent · Jul 25, 2017

Maintainer

@rymai It's currently not used in CE. It's required for https://gitlab.com/gitlab-org/gitlab-ee/blob/master/app/models/concerns/protected_tag_access.rb#L10 & https://gitlab.com/gitlab-org/gitlab-ee/blob/master/app/models/concerns/protected_branch_access.rb#L10

Which is only used in https://gitlab.com/gitlab-org/gitlab-ee/blob/master/app/models/concerns/ee/protected_ref_access.rb#L67

But it couldn't hurt: to have it in CE as it could avoid conflicts in the future: https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/13068

Nice catch, thanks!

Edited Jul 25, 2017 by Bob Van Landuyt
@rymai It's currently not used in CE. It's required for https://gitlab.com/gitlab-org/gitlab-ee/blob/master/app/models/concerns/protected_tag_access.rb#L10 & https://gitlab.com/gitlab-org/gitlab-ee/blob/master/app/models/concerns/protected_branch_access.rb#L10 Which is only used in https://gitlab.com/gitlab-org/gitlab-ee/blob/master/app/models/concerns/ee/protected_ref_access.rb#L67 But it couldn't hurt: to have it in CE as it could avoid conflicts in the future: https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/13068 Nice catch, thanks!
Rémy Coutable 🔴 @rymai · Jul 25, 2017

Maintainer

@reprazent Cool, thanks a lot!

@reprazent Cool, thanks a lot!

Please register or to comment