Merge branch 'prevent-errors-parent-rollup-dates-handler' into 'master'

Prevent errors when work item does not exist

See merge request !147032



Merged-by: Nicolas Dular <ndular@gitlab.com>
Approved-by: Kassio Borges <kborges@gitlab.com>
Approved-by: Nicolas Dular <ndular@gitlab.com>
Co-authored-by: Heinrich Lee Yu <heinrich@gitlab.com>

ee/app/workers/work_items/rolledup_dates/update_parent_rolledup_dates_event_handler.rb

@@ -25,7 +25,7 @@ def self.can_handle_update?(event)
       end
 
       def handle_event(event)
-        parent = ::WorkItem.find(event.data[:id])&.work_item_parent
+        parent = ::WorkItem.find_by_id(event.data[:id])&.work_item_parent
         return if parent.blank?
 
         ::WorkItems::Widgets::RolledupDatesService::HierarchyUpdateService

ee/spec/workers/work_items/rolledup_dates/update_parent_rolledup_dates_event_handler_spec.rb

@@ -40,7 +40,7 @@
         parent = instance_double(::WorkItem)
 
         expect(::WorkItem)
-          .to receive(:find)
+          .to receive(:find_by_id)
             .with(1)
             .and_return(instance_double(::WorkItem, work_item_parent: parent))
 
@@ -58,7 +58,7 @@
     context "when work item does not have a parent" do
       it "updates the work_item hierarchy" do
         expect(::WorkItem)
-          .to receive(:find)
+          .to receive(:find_by_id)
             .with(1)
             .and_return(instance_double(::WorkItem, work_item_parent: nil))
 
@@ -71,5 +71,15 @@
         handler.handle_event(event)
       end
     end
+
+    context 'when the work item no longer exists' do
+      it 'does not raise an error' do
+        event = ::WorkItems::WorkItemCreatedEvent.new(data: { id: non_existing_record_id, namespace_id: 2 })
+
+        handler = described_class.new
+
+        expect { handler.handle_event(event) }.not_to raise_error
+      end
+    end
   end
 end