-
- Downloads
Move merge base pipeline logic to EE
`::Ci::CompareMetricsReportsService`, `::Ci::CompareCodequalityReportsService`, and `::Ci::CompareSecurityReportsService` are all EE classes. Since `use_merge_base_pipeline_for_comparison?` is related to those classes specifically, it should be in EE. This change moves the code to the EE file. To lower the risk of EE class usage happening the in the CE file in the future, we use constants instead of strings for the map keys. This means that trying to reference an EE constant inside CE will cause an undefined constant error and fail the pipeline when running tests.
parent
7b1747e3
No related branches found
No related tags found
Showing
- app/models/merge_request.rb 5 additions, 12 deletionsapp/models/merge_request.rb
- ee/app/models/ee/merge_request.rb 13 additions, 0 deletionsee/app/models/ee/merge_request.rb
- ee/spec/models/merge_request_spec.rb 38 additions, 0 deletionsee/spec/models/merge_request_spec.rb
- spec/models/merge_request_spec.rb 19 additions, 55 deletionsspec/models/merge_request_spec.rb
Loading
Please register or sign in to comment