Added Security Orchestration Policy Added policy to check...

Added Security Orchestration Policy     Added policy to check vulnerabilities_allowed property is within the range of smallint, had to refactor the code because RuboCop was giving warnings on cyclomatic complexity

ee/app/validators/json_schemas/security_orchestration_policy.json

@@ -568,7 +568,8 @@
                 "vulnerabilities_allowed": {
                   "description": "Specifies a number of vulnerabilities allowed before this rule is enforced.",
                   "type": "integer",
-                  "minimum": 0
+                  "minimum": 0,
+                  "maximum": 32767
                 },
                 "severity_levels": {
                   "description": "Specifies a list of vulnerability security levels that should be concidered to enforce this policy. Possible values: `info`, `unknown`, `low`, `medium`, `high`, `critical`.",

ee/spec/models/security/orchestration_policy_configuration_spec.rb

@@ -1241,6 +1241,30 @@
           end
         end
 
+        describe "vulnerabilities_allowed" do
+          context "when value is below the minimum" do
+            before do
+              rule[:vulnerabilities_allowed] = -1
+            end
+
+            specify do
+              expect(errors).to contain_exactly(
+                "property '/#{type}/0/rules/0/vulnerabilities_allowed' is invalid: error_type=minimum")
+            end
+          end
+
+          context "when value is above the maximum" do
+            before do
+              rule[:vulnerabilities_allowed] = 32768
+            end
+
+            specify do
+              expect(errors).to contain_exactly(
+                "property '/#{type}/0/rules/0/vulnerabilities_allowed' is invalid: error_type=maximum")
+            end
+          end
+        end
+
         describe "vulnerability_age" do
           before do
             rule[:vulnerability_age] = vulnerability_age