Fix Layout/ArgumentAlignment offenses in spec/features

Fix Layout/ArgumentAlignment offenses in spec/features

.rubocop_todo/layout/argument_alignment.yml

@@ -1034,21 +1034,6 @@ Layout/ArgumentAlignment:
     - 'ee/spec/elastic/migrate/20220119120500_populate_commit_permissions_in_main_index_spec.rb'
     - 'ee/spec/elastic/migrate/20221124090600_add_namespace_ancestry_ids_to_original_index_mapping_spec.rb'
     - 'ee/spec/elastic/migrate/20221221110300_backfill_traversal_ids_to_blobs_and_wiki_blobs_spec.rb'
-    - 'ee/spec/features/account_recovery_regular_check_spec.rb'
-    - 'ee/spec/features/admin/admin_emails_spec.rb'
-    - 'ee/spec/features/admin/admin_settings_spec.rb'
-    - 'ee/spec/features/billings/billing_plans_spec.rb'
-    - 'ee/spec/features/boards/boards_spec.rb'
-    - 'ee/spec/features/boards/swimlanes/epics_swimlanes_drag_drop_spec.rb'
-    - 'ee/spec/features/burndown_charts_spec.rb'
-    - 'ee/spec/features/dashboards/todos_spec.rb'
-    - 'ee/spec/features/epic_boards/epic_boards_spec.rb'
-    - 'ee/spec/features/groups/saml_enforcement_spec.rb'
-    - 'ee/spec/features/groups/settings/domain_verification_spec.rb'
-    - 'ee/spec/features/groups/settings/protected_environments_spec.rb'
-    - 'ee/spec/features/groups/usage_quotas/pipelines_tab_spec.rb'
-    - 'ee/spec/features/markdown/metrics_spec.rb'
-    - 'ee/spec/features/merge_request/user_sees_approval_widget_spec.rb'
     - 'ee/spec/features/namespace_user_cap_reached_alert_spec.rb'
     - 'ee/spec/features/projects/environments/environment_spec.rb'
     - 'ee/spec/features/projects/environments/environments_spec.rb'

ee/spec/features/account_recovery_regular_check_spec.rb

@@ -87,7 +87,7 @@
       end
 
       it 'hides callout on next session if user dismissed it', :js,
-          quarantine: 'https://gitlab.com/gitlab-org/gitlab/-/issues/375101' do
+        quarantine: 'https://gitlab.com/gitlab-org/gitlab/-/issues/375101' do
         visit dashboard_todos_path
 
         expect(page).to have_content(message)

ee/spec/features/admin/admin_emails_spec.rb

@@ -11,8 +11,7 @@
     gitlab_enable_admin_mode_sign_in(admin)
   end
 
-  context 'when `send_emails_from_admin_area` feature is not licensed',
-  feature_category: :system_access do
+  context 'when `send_emails_from_admin_area` feature is not licensed', feature_category: :system_access do
     before do
       stub_licensed_features(send_emails_from_admin_area: false)
       stub_application_setting(usage_ping_enabled: false)
@@ -56,8 +55,7 @@
     end
   end
 
-  context 'when `send_emails_from_admin_area` feature is licensed',
-  :js, feature_category: :system_access do
+  context 'when `send_emails_from_admin_area` feature is licensed', :js, feature_category: :system_access do
     let(:rate_limited_alert) do
       'An email notification was recently sent from the admin panel. '\
       'Please wait 10 minutes before attempting to send another message.'

ee/spec/features/admin/admin_settings_spec.rb

@@ -527,12 +527,12 @@
 
         expect(page).to have_content(
           s_('GitAbuse|Number of repositories should be between %{minNumRepos}-%{maxNumRepos}.') %
-          { minNumRepos: 0, maxNumRepos: 10000 }
+            { minNumRepos: 0, maxNumRepos: 10000 }
         )
 
         expect(page).to have_content(
           s_('GitAbuse|Reporting time period should be between %{minTimePeriod}-%{maxTimePeriod} seconds.') %
-          { minTimePeriod: 0, maxTimePeriod: 864000 }
+            { minTimePeriod: 0, maxTimePeriod: 864000 }
         )
         expect(page).to have_button _('Save changes'), disabled: true
       end

ee/spec/features/billings/billing_plans_spec.rb

@@ -315,9 +315,14 @@ def external_upgrade_url(namespace, plan)
       let(:plan) { free_plan }
 
       let!(:subscription) do
-        create(:gitlab_subscription,
-               namespace: namespace, hosted_plan: plan,
-               trial: true, trial_ends_on: Date.current.tomorrow, seats: 15)
+        create(
+          :gitlab_subscription,
+          namespace: namespace,
+          hosted_plan: plan,
+          trial: true,
+          trial_ends_on: Date.current.tomorrow,
+          seats: 15
+        )
       end
 
       before do

ee/spec/features/boards/boards_spec.rb

@@ -103,12 +103,14 @@
       from = board.lists.first
       to = list
 
-      drag_to(selector: '.board-list',
-              scrollable: '#board-app',
-              list_from_index: 0,
-              from_index: 0,
-              to_index: 0,
-              list_to_index: 1)
+      drag_to(
+        selector: '.board-list',
+        scrollable: '#board-app',
+        list_from_index: 0,
+        from_index: 0,
+        to_index: 0,
+        list_to_index: 1
+      )
 
       expect(card_weight_badge(from)).to have_content('3')
       expect(card_weight_badge(to)).to have_content('2')

ee/spec/features/boards/swimlanes/epics_swimlanes_drag_drop_spec.rb

@@ -169,14 +169,16 @@ def drag(selector: '.board-cell', list_from_index: 0, from_index: 0, to_index: 0
     # ensure there is enough horizontal space for four boards
     resize_window(2000, 1200)
 
-    drag_to(selector: selector,
-            scrollable: '#board-app',
-            list_from_index: list_from_index,
-            from_index: from_index,
-            to_index: to_index,
-            list_to_index: list_to_index,
-            perform_drop: perform_drop,
-            extra_height: 50)
+    drag_to(
+      selector: selector,
+      scrollable: '#board-app',
+      list_from_index: list_from_index,
+      from_index: from_index,
+      to_index: to_index,
+      list_to_index: list_to_index,
+      perform_drop: perform_drop,
+      extra_height: 50
+    )
   end
 
   def wait_for_board_cards(board_number, expected_cards)

ee/spec/features/burndown_charts_spec.rb

@@ -5,10 +5,13 @@
 RSpec.describe 'Burndown charts', :js, feature_category: :team_planning do
   let(:current_user) { create(:user) }
   let(:milestone) do
-    create(:milestone, project: project,
-                       group: group,
-                       start_date: Date.current,
-                       due_date: Date.tomorrow)
+    create(
+      :milestone,
+      project: project,
+      group: group,
+      start_date: Date.current,
+      due_date: Date.tomorrow
+    )
   end
 
   before do

ee/spec/features/dashboards/todos_spec.rb

@@ -14,13 +14,15 @@
     let_it_be(:target) { create(:epic, group: group) }
     let_it_be(:note) { create(:note, noteable: target, note: "#{user.to_reference} hello world") }
     let_it_be(:todo) do
-      create(:todo, :mentioned,
-             user: user,
-             project: nil,
-             group: group,
-             target: target,
-             author: user,
-             note: note)
+      create(
+        :todo, :mentioned,
+        user: user,
+        project: nil,
+        group: group,
+        target: target,
+        author: user,
+        note: note
+      )
     end
 
     before do

ee/spec/features/epic_boards/epic_boards_spec.rb

@@ -408,13 +408,15 @@ def drag(selector: '.board-list', list_from_index: 0, from_index: 0, to_index: 0
     # ensure there is enough horizontal space for four lists
     resize_window(2000, 800)
 
-    drag_to(selector: selector,
-            scrollable: '#board-app',
-            list_from_index: list_from_index,
-            from_index: from_index,
-            to_index: to_index,
-            list_to_index: list_to_index,
-            perform_drop: perform_drop)
+    drag_to(
+      selector: selector,
+      scrollable: '#board-app',
+      list_from_index: list_from_index,
+      from_index: from_index,
+      to_index: to_index,
+      list_to_index: list_to_index,
+      perform_drop: perform_drop
+    )
   end
 
   def click_value(filter, value)

ee/spec/features/groups/saml_enforcement_spec.rb

@@ -100,8 +100,9 @@
 
       it 'allows access to resource' do
         expect(page).not_to have_content('Page Not Found')
-        expect(page.title).not_to have_content(format(_('SAML single sign-on for %{group_name}'),
-        group_name: group.name) )
+        expect(page.title).not_to have_content(
+          format(_('SAML single sign-on for %{group_name}'), group_name: group.name)
+        )
         expect(page).to have_content(resource_name)
         expect(page).to have_current_path(resource_path, ignore_query: true)
       end

ee/spec/features/groups/settings/protected_environments_spec.rb

@@ -77,8 +77,13 @@
     before do
       deploy_access_level = build(:protected_environment_deploy_access_level, group: operator_group)
 
-      create(:protected_environment, :group_level, name: 'production', group: organization,
-                                                   deploy_access_levels: [deploy_access_level])
+      create(
+        :protected_environment,
+        :group_level,
+        name: 'production',
+        group: organization,
+        deploy_access_levels: [deploy_access_level]
+      )
 
       visit group_settings_ci_cd_path(organization)
     end

ee/spec/features/groups/usage_quotas/pipelines_tab_spec.rb

@@ -167,8 +167,14 @@
     include_context 'when user is allowed to see usage quotas'
 
     let!(:project) do
-      create(:project, :with_ci_minutes, amount_used: 100, shared_runners_duration: 1000, namespace: group,
-                                         shared_runners_enabled: true)
+      create(
+        :project,
+        :with_ci_minutes,
+        amount_used: 100,
+        shared_runners_duration: 1000,
+        namespace: group,
+        shared_runners_enabled: true
+      )
     end
 
     let(:per_page) { 20 }

ee/spec/features/merge_request/user_sees_approval_widget_spec.rb

@@ -50,10 +50,12 @@
       let(:members) { create_list(:user, 2) }
 
       let!(:rule) do
-        create(:approval_merge_request_rule,
-               merge_request: merge_request,
-               users: members,
-               approvals_required: 1)
+        create(
+          :approval_merge_request_rule,
+          merge_request: merge_request,
+          users: members,
+          approvals_required: 1
+        )
       end
 
       before do
@@ -80,10 +82,12 @@
         let(:code_owners) { create_list(:user, 2) }
 
         let!(:code_owner_rule) do
-          create(:code_owner_rule,
-                 merge_request: merge_request,
-                 users: code_owners,
-                 name: '*.js')
+          create(
+            :code_owner_rule,
+            merge_request: merge_request,
+            users: code_owners,
+            name: '*.js'
+          )
         end
 
         before do