Skip to content
Snippets Groups Projects
Verified Commit 91d3fcbd authored by Steve Xuereb's avatar Steve Xuereb
Browse files

Move rejected proposals in their own dir


What
---
- Move `proposal-stateless-router-with-buffering-requests.md` under
  `rejected` directory.
- Move `proposal-stateless-router-with-routes-learning.md` under
  `rejected` directory.

Why
---
To keep the root directory clean and "hide" the rejected proposals.

Signed-off-by: Steve Xuereb's avatarSteve Xuereb <sxuereb@gitlab.com>
parent 384b0a2b
No related branches found
No related tags found
2 merge requests!144312Change service start (cut-off) date for code suggestions to March 15th,!143236Move rejected proposals in their own dir
......@@ -13,8 +13,8 @@ In <https://gitlab.com/groups/gitlab-org/-/epics/11002> we first brainstormed [m
We favored the Cloudflare Worker PoC and extended the PoC with the [Cell 1.0 proposal](https://gitlab.com/gitlab-org/gitlab/-/issues/437818) to have multiple routing rules.
These PoCs help validate the [routing service blueprint](../routing-service.md),
that got accepted in <https://gitlab.com/gitlab-org/gitlab/-/merge_requests/142397>,
and rejected the [request buffering](../proposal-stateless-router-with-buffering-requests.md),
and [routes learning](../proposal-stateless-router-with-routes-learning.md)
and rejected the [request buffering](../rejected/proposal-stateless-router-with-buffering-requests.md),
and [routes learning](../rejected/proposal-stateless-router-with-routes-learning.md)
## Decision
......@@ -35,6 +35,6 @@ You can read a detailed analysis of Cloudflare workers in <https://gitlab.com/gi
## Alternatives
- We considered [Istio](https://gitlab.com/gitlab-org/gitlab/-/issues/433472) but concluded that it's not the right fit.
- We considered [Request Buffering](../proposal-stateless-router-with-buffering-requests.md)
- We considered [Routes Learning](../proposal-stateless-router-with-routes-learning.md)
- We considered [Request Buffering](../rejected/proposal-stateless-router-with-buffering-requests.md)
- We considered [Routes Learning](../rejected/proposal-stateless-router-with-routes-learning.md)
- Use WASM for Cloudflare workers which is the wrong choice: <https://blog.cloudflare.com/webassembly-on-cloudflare-workers#whentousewebassembly>
......@@ -5,7 +5,7 @@ description: 'Cells Stateless Router Proposal'
status: rejected
---
_This proposal was superseded by the [routing service proposal](routing-service.md)_
_This proposal was superseded by the [routing service proposal](../routing-service.md)_
<!-- vale gitlab.FutureTense = NO -->
......@@ -31,7 +31,7 @@ databases to be replicated across regions.
Users are not directly exposed to the concept of Cells but instead they see
different data dependent on their chosen Organization.
[Organizations](goals.md#organizations) will be a new entity introduced to enforce isolation in the
[Organizations](../goals.md#organizations) will be a new entity introduced to enforce isolation in the
application and allow us to decide which request routes to which Cell, since an
Organization can only be on a single Cell.
......
......@@ -5,7 +5,7 @@ description: 'Cells Stateless Router Proposal'
status: rejected
---
_This proposal was superseded by the [routing service proposal](routing-service.md)_
_This proposal was superseded by the [routing service proposal](../routing-service.md)_
<!-- vale gitlab.FutureTense = NO -->
......@@ -31,7 +31,7 @@ databases to be replicated across regions.
Users are not directly exposed to the concept of Cells but instead they see
different data dependent on their chosen Organization.
[Organizations](goals.md#organizations) will be a new entity introduced to enforce isolation in the
[Organizations](../goals.md#organizations) will be a new entity introduced to enforce isolation in the
application and allow us to decide which request routes to which Cell, since an
Organization can only be on a single Cell.
......
......@@ -770,7 +770,7 @@ sequenceDiagram
### Buffering requests
The [Stateless Router using Requests Buffering](proposal-stateless-router-with-buffering-requests.md)
The [Stateless Router using Requests Buffering](rejected/proposal-stateless-router-with-buffering-requests.md)
describes an approach where Cell answers with `X-Gitlab-Cell-Redirect` to redirect request to another Cell:
- This is based on a need to buffer the whole request (headers + body) which is very memory intensive.
......@@ -779,7 +779,7 @@ describes an approach where Cell answers with `X-Gitlab-Cell-Redirect` to redire
### Learn request
The [Stateless Router using Routes Learning](proposal-stateless-router-with-routes-learning.md)
The [Stateless Router using Routes Learning](rejected/proposal-stateless-router-with-routes-learning.md)
describes an approach similar to the one in this document. Except the route rules and classification
is done in a single go in a form of pre-flight check `/api/v4/internal/cells/learn`:
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment