Skip to content
Snippets Groups Projects
Commit 7d465b45 authored by Tianwen Chen's avatar Tianwen Chen 2️⃣
Browse files

Remove feature flag ci_builds_columns_size_validation

- #372770
- #407404

Changelog: changed
parent 4215d42c
No related branches found
No related tags found
No related merge requests found
......@@ -36,7 +36,7 @@ class CommitStatus < Ci::ApplicationRecord
validates :pipeline, presence: true, unless: :importing?
validates :name, presence: true, unless: :importing?
validates :stage, :ref, :target_url, :description, length: { maximum: 255 }, if: :ci_builds_columns_size_validation_enabled?
validates :stage, :ref, :target_url, :description, length: { maximum: 255 }
alias_attribute :author, :user
alias_attribute :pipeline_id, :commit_id
......@@ -321,8 +321,4 @@ def stage_name
def unrecoverable_failure?
script_failure? || missing_dependency_failure? || archived_failure? || scheduler_failure? || data_integrity_failure?
end
def ci_builds_columns_size_validation_enabled?
Feature.enabled?(:ci_builds_columns_size_validation, project)
end
end
---
name: ci_builds_columns_size_validation
introduced_by_url: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/118148
rollout_issue_url: https://gitlab.com/gitlab-org/gitlab/-/issues/407404
milestone: '16.0'
type: development
group: group::pipeline execution
default_enabled: false
......@@ -34,17 +34,6 @@ def create_status(**opts)
it { is_expected.to validate_length_of(:target_url).is_at_most(255) }
it { is_expected.to validate_length_of(:description).is_at_most(255) }
context 'when feature flag ci_builds_columns_size_validation is disabled' do
before do
stub_feature_flags(ci_builds_columns_size_validation: false)
end
it { is_expected.not_to validate_length_of(:stage).is_at_most(255) }
it { is_expected.not_to validate_length_of(:ref).is_at_most(255) }
it { is_expected.not_to validate_length_of(:target_url).is_at_most(255) }
it { is_expected.not_to validate_length_of(:description).is_at_most(255) }
end
it { is_expected.to delegate_method(:sha).to(:pipeline) }
it { is_expected.to delegate_method(:short_sha).to(:pipeline) }
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment