Fix Layout/EmptyLinesAroundAttributeAccessor offences

Fix and enable `Layout/EmptyLinesAroundAttributeAccessor`

Fix Layout/EmptyLinesAroundAttributeAccessor offences
7c4f0b8d · Vitali Tatarintev · 0428d3e6 · 7c4f0b8d · 7c4f0b8d · 7c4f0b8d
Commit 7c4f0b8d authored 3 years ago by Vitali Tatarintev
--- a/.rubocop_todo.yml
+++ b/.rubocop_todo.yml
@@ -32,13 +32,6 @@ Graphql/IDType:
 Layout/ArgumentAlignment:
  Enabled: false

-# Offense count: 54
-# Cop supports --auto-correct.
-# Configuration parameters: AllowAliasSyntax, AllowedMethods.
-# AllowedMethods: alias_method, public, protected, private
-Layout/EmptyLinesAroundAttributeAccessor:
-  Enabled: false
-
 # Offense count: 771
 # Cop supports --auto-correct.
 # Configuration parameters: EnforcedStyle, IndentationWidth.

--- a/app/mailers/application_mailer.rb
+++ b/app/mailers/application_mailer.rb
@@ -7,6 +7,7 @@ class ApplicationMailer < ActionMailer::Base
  helper MarkupHelper

  attr_accessor :current_user
+
  helper_method :current_user, :can?

  default from:     proc { default_sender_address.format }

--- a/app/models/lfs_download_object.rb
+++ b/app/models/lfs_download_object.rb
@@ -4,6 +4,7 @@ class LfsDownloadObject
  include ActiveModel::Validations

  attr_accessor :oid, :size, :link, :headers
+
  delegate :sanitized_url, :credentials, to: :sanitized_uri

  validates :oid, format: { with: /\A\h{64}\z/ }

--- a/app/models/storage/hashed.rb
+++ b/app/models/storage/hashed.rb
@@ -3,6 +3,7 @@
 module Storage
  class Hashed
    attr_accessor :container
+
    delegate :gitlab_shell, :repository_storage, to: :container

    REPOSITORY_PATH_PREFIX = '@hashed'

--- a/app/models/storage/legacy_project.rb
+++ b/app/models/storage/legacy_project.rb
@@ -3,6 +3,7 @@
 module Storage
  class LegacyProject
    attr_accessor :project
+
    delegate :namespace, :gitlab_shell, :repository_storage, to: :project

    def initialize(project)

--- a/app/models/wiki_page.rb
+++ b/app/models/wiki_page.rb
@@ -45,6 +45,7 @@ def to_key

  # The GitLab Wiki instance.
  attr_reader :wiki
+
  delegate :container, to: :wiki

  # The raw Gitlab::Git::WikiPage instance.

--- a/app/services/ci/test_failure_history_service.rb
+++ b/app/services/ci/test_failure_history_service.rb
@@ -17,6 +17,7 @@ def perform_if_needed
    MAX_TRACKABLE_FAILURES = 200

    attr_reader :pipeline
+
    delegate :project, to: :pipeline

    def initialize(pipeline)

--- a/app/services/concerns/rate_limited_service.rb
+++ b/app/services/concerns/rate_limited_service.rb
@@ -57,6 +57,7 @@ def evaluated_scope_for(service)

  prepended do
    attr_accessor :rate_limiter_bypassed
+
    cattr_accessor :rate_limiter_scoped_and_keyed

    def self.rate_limit(key:, opts:, rate_limiter: ::Gitlab::ApplicationRateLimiter)

--- a/app/services/concerns/update_repository_storage_methods.rb
+++ b/app/services/concerns/update_repository_storage_methods.rb
@@ -6,6 +6,7 @@ module UpdateRepositoryStorageMethods
  Error = Class.new(StandardError)

  attr_reader :repository_storage_move
+
  delegate :container, :source_storage_name, :destination_storage_name, to: :repository_storage_move

  def initialize(repository_storage_move)

--- a/app/services/notification_recipients/builder/merge_request_unmergeable.rb
+++ b/app/services/notification_recipients/builder/merge_request_unmergeable.rb
@@ -4,6 +4,7 @@ module NotificationRecipients
  module Builder
    class MergeRequestUnmergeable < Base
      attr_reader :target
+
      def initialize(merge_request)
        @target = merge_request
      end

--- a/app/services/notification_recipients/builder/new_note.rb
+++ b/app/services/notification_recipients/builder/new_note.rb
@@ -4,6 +4,7 @@ module NotificationRecipients
  module Builder
    class NewNote < Base
      attr_reader :note
+
      def initialize(note)
        @note = note
      end

--- a/app/services/notification_recipients/builder/new_review.rb
+++ b/app/services/notification_recipients/builder/new_review.rb
@@ -4,6 +4,7 @@ module NotificationRecipients
  module Builder
    class NewReview < Base
      attr_reader :review
+
      def initialize(review)
        @review = review
      end

--- a/app/services/notification_service.rb
+++ b/app/services/notification_service.rb
@@ -18,6 +18,7 @@
 class NotificationService
  class Async
    attr_reader :parent
+
    delegate :respond_to_missing, to: :parent

    def initialize(parent)

--- a/app/services/projects/base_move_relations_service.rb
+++ b/app/services/projects/base_move_relations_service.rb
@@ -3,6 +3,7 @@
 module Projects
  class BaseMoveRelationsService < BaseService
    attr_reader :source_project
+
    def execute(source_project, remove_remaining_elements: true)
      return if source_project.blank?


--- a/app/services/projects/lfs_pointers/lfs_download_service.rb
+++ b/app/services/projects/lfs_pointers/lfs_download_service.rb
@@ -11,6 +11,7 @@ class LfsDownloadService < BaseService
      LARGE_FILE_SIZE = 1.megabytes

      attr_reader :lfs_download_object
+
      delegate :oid, :size, :credentials, :sanitized_url, :headers, to: :lfs_download_object, prefix: :lfs

      def initialize(project, lfs_download_object)

--- a/config/initializers/http_hostname_override.rb
+++ b/config/initializers/http_hostname_override.rb
@@ -34,6 +34,7 @@ def post_connection_check(hostname)

 class Net::HTTP
  attr_accessor :hostname_override
+
  SSL_IVNAMES << :@hostname_override
  SSL_ATTRIBUTES << :hostname_override


--- a/ee/app/finders/security/findings_finder.rb
+++ b/ee/app/finders/security/findings_finder.rb
@@ -37,6 +37,7 @@ def execute
    private

    attr_reader :pipeline, :params
+
    delegate :project, :has_security_findings?, to: :pipeline, private: true

    def findings

--- a/ee/app/services/ci/pipeline_creation/drop_not_runnable_builds_service.rb
+++ b/ee/app/services/ci/pipeline_creation/drop_not_runnable_builds_service.rb
@@ -22,6 +22,7 @@ def execute

      attr_reader :pipeline
      attr_reader :runner_minutes
+
      delegate :project, to: :pipeline

      def validate_build_matchers

--- a/ee/app/services/vulnerability_external_issue_links/create_service.rb
+++ b/ee/app/services/vulnerability_external_issue_links/create_service.rb
@@ -34,6 +34,7 @@ def execute
    private

    attr_reader :user, :vulnerability, :link_type, :external_provider, :external_provider_service, :external_issue_link
+
    delegate :project, to: :vulnerability

    def create_external_issue

--- a/ee/lib/gitlab/auth/group_saml/response_check.rb
+++ b/ee/lib/gitlab/auth/group_saml/response_check.rb
@@ -7,6 +7,7 @@ class ResponseCheck
        include ActiveModel::Model

        attr_reader :xml_response, :identity
+
        delegate :name_id, :name_id_format, :xml, to: :xml_response

        validate :response_error_passthrough!